PostProcessing.bat supercedes Comskip

[zehd]

Sub, in the config screen, where you can choose Comskip, ShowAnalyzer, or none for commercial detection:

[ATTACHMENT NOT FOUND]

Could you add to the list an item that indicates Comskip/ShowAnalyzer will be handled by PostProcessing bat, just to avoid confusion, please? I would imagine that, since you already have the logic, it would only be an asthetic thing, but it would help with the confusion factor.

List
None
Comskip
ShowAnalyzer
Commerical Detection handled in PostProcessing.bat

And while you're at it, maybe an edit button, that opens the postprocessing.bat in Notepad?

That would be cool...

Thanks
Frank

[stefan]

But... gbpvr doesn't know what you have in your postprocessing.bat file, now does it?

[reboot]

Just select None, then processing will be done in postprocessing.bat (or parallelprocessing.bat).

[zehd]

All I'm saying, (as I was a newbie just a few weeks ago) that it is confusing: that I would select 'none', and yet stil have commerical detection...

That means, someone could say to themselves, I don't want it, and still get it.

Changing the choice in the menu, while not doing anything programmatically, would at least confirm to the user that he wants Commerical detection. but that GBPVR will not handle it directly.

And yes, if it were there, than I suppose there should also be a listing for PararllellProcessing.bat.

See, I program too, guys. But when I'm home, on the couch, I do not want to be a geek all the time, modiying batch files from command line, tweaking cryptic XML files etc...

Of course I can do it. I just think that 'uncle and auntie' should be able to do some configurin' too...

Just a thought, to make GBPVR for everyone...

Frank

[sub]

I do agree that it appears complex, particaularly if you start thinking about the batch files. There historic reason why it has evolved this way.

the intention of these bat files was some thing entirely different:
ParallelProcessing.bat will be run when a recording starts
PostProcessing.bat will be run after a recording completes

These batches files were not intended to be used for commercial detection at all, but some poeple do use it for this.

See, I program too, guys. But when I'm home, on the couch, I do not want to be a geek all the time, modiying batch files from command line, tweaking cryptic XML files etc...

I agree. Personally I dont think anyone but a geek should have a batch file. I dont have these batch files on my machines. I just say whether I want to use Comskip or ShowAnalyzer commercial detection (or nothing), and whether in need to run after the recording or during it. Just ignore these batch files (unless you really need them), they just make things seem more complex.

[zehd]

So, to be clear,...

If I select 'use Comskip' in the GBPVR config, then PostProcessing.bat WILL NOT run,

or...

PostProcessing.bat will always run if it exists. If I select 'use ComSkip', then I do not need an entry for it in the PostProcessing.bat, though other stuff can run with PostProcessing.bat

and finally,

If I select 'use Comskip' in config, AND have an entry in the PostProcessing.bat, that would be redundant redundant, wouldn't it?

(BTW sub, great coding!)

Frank

[sub]

If PostProcessing.bat exists, it'll will always run after every recording regardless of any other setting.

If you do have a PostProcessing.bat, I suggest you put your comskip stuff in there.

[zehd]

Thanks you sub. That was clear.

Frank

[thawk]

I also just use the post-processing bat even with comskip since if you want to have different comskip.ini settings files applied to different channels (e.g. ones with logos and ones without), or want to not bother with comskip on some channels (e.g. ad-free BBC channels in UK) the only way is to write that into the post-processing bat file

Cheers

Tim

[sub]

I also just use the post-processing bat even with comskip since if you want to have different comskip.ini settings files applied to different channels (e.g. ones with logos and ones without), or want to not bother with comskip on some channels (e.g. ad-free BBC channels in UK) the only way is to write that into the post-processing bat file

Yeah, these are the sorts of special case logic I would expect people to use it for. Its pointless building endless features into the software, instead I've provided these batch files as a mechanism for users to add any custom logic they want to run.