Deleting Failed Recordings

[cncb]

I have had some failed recordings due to bad signal quality. When I delete them from the NPVR UI it seems to not remove the (empty) files from disk.

[sub]

Do you have the logs that show the attempt?

[cncb]

I don't see any errors in the log file - it just doesn't delete it. The files are empty (0 KB) so maybe this has something to do with it?

Code:

2011-09-08 22:26:07.803    [DEBUG][47]    DeleteRecording(3270)
2011-09-08 22:26:07.803    [DEBUG][47]    DeleteRecording@1
2011-09-08 22:26:07.803    [DEBUG][47]    Cancelling wake up request for for 'RecordingOID3270'
2011-09-08 22:26:07.912    [DEBUG][47]    DeleteRecording@2
2011-09-08 22:26:07.912    [DEBUG][47]    DeleteRecording@4
2011-09-08 22:26:07.912    [DEBUG][47]    PlaybackPositionHelper.DeletePlaybackPosition(T:\The Cat in the Hat Knows a Lot About That!\The Cat in the Hat Knows a Lot About That!_20110907_09000930.ts)
2011-09-08 22:26:07.928    [DEBUG][47]    DeleteRecording@5
2011-09-08 22:26:07.928    [DEBUG][47]    DeleteRecording@exit

[johnsonx42]

Same thing here. Just had a 'family guy' recording that was zero length, somehow the recording graph never started properly, then when it tried to stop the bad graph nrecord died. After restarting the recording service, the 'family guy' recording and all the missed recordings were marked 'failed-recording service not running'. when I deleted the Family Guy recording, it says it deleted the file, but it was still there. Strangely it did succeed in deleting the extra comskip files, just not the .ts file itself.

it's at the end of the npvr.log attached; I exited npvr immediately after so you wouldn't have to go hunting for it.

[sub]

This patch should fix it.

[cncb]

This patch worked for the one failed recording I was able to try it with - thanks.