Plugin developers read

[reven]

ok ill give it a try and see how well it works.

But surely when you've released whatever version of your software, and you've missed X skin (not blue), you would have updated the blue skin when you released??

So therefore it should load that.

yes but say for instance they are running version 5 of a plugin, but the skin they are using has a skin folder for version 4 already, the skinhelper would load that skin and think all is well, but the plugin would crash since its missing all the changes in the skin. thats my only concern.

[psycik]

ok ill give it a try and see how well it works.


yes but say for instance they are running version 5 of a plugin, but the skin they are using has a skin folder for version 4 already, the skinhelper would load that skin and think all is well, but the plugin would crash since its missing all the changes in the skin. thats my only concern.

But that's what i don't understand, how can they be running my videos 5 with an old skin...hasn;t it been upgraded when you installed it.....


Ahh, it may have just sunk it, yes when mv5 was installed it had blue skin files in it. But x user has been using y skin, which wasn't included in the new install..*thunk*..now I get it.


Maybe simple version support in the skn files might be useful in this situation - but again all handled via skinHelper (and subs constructor)....

[reven]

Maybe simple version support in the skn files might be useful in this situation - but again all handled via skinHelper (and subs constructor)....

exactly why i requested a third parameter for the version number.

[dottore]

question: must a plugin use .net 2.0 for that functionality? i re-referenced the gbpvr-dll's and config.exe produces following error:

Code:

Error initializing menu plugin: C:\Programme\devnz\gbpvr\plugins\CDPlayer.dll
22.07.2006 18:41:41.413    ERROR    [1]    Ein Aufrufziel hat einen Ausnahmefehler verursacht.
22.07.2006 18:41:41.444    ERROR    [1]       bei System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandle& ctor, Boolean& bNeedSecurityCheck)
   bei System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean fillCache)
   bei System.RuntimeType.CreateInstanceImpl(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean fillCache)
   bei System.Activator.CreateInstance(Type type, Boolean nonPublic)
   bei GBPVR.Backend.Common.xc4f12ec3a8a4c96b.xb77fa95273e0c228()
22.07.2006 18:41:41.475    ERROR    [1]    Inner exception: System.IO.DirectoryNotFoundException: Ein Teil des Pfades C:\Programme\devnz\gbpvr\skin\Sassari\CDPlayer\skin.xml konnte nicht gefunden werden.
   bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   bei System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
   bei System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
   bei System.Xml.XmlDownloadManager.GetStream(Uri uri, ICredentials credentials)
   bei System.Xml.XmlUrlResolver.GetEntity(Uri absoluteUri, String role, Type ofObjectToReturn)
   bei System.Xml.XmlTextReaderImpl.OpenUrlDelegate(Object xmlResolver)
   bei System.Threading.CompressedStack.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.CompressedStack.Run(CompressedStack compressedStack, ContextCallback callback, Object state)
   bei System.Xml.XmlTextReaderImpl.OpenUrl()
   bei System.Xml.XmlTextReaderImpl.Read()
   bei System.Xml.XmlLoader.Load(XmlDocument doc, XmlReader reader, Boolean preserveWhitespace)
   bei System.Xml.XmlDocument.Load(XmlReader reader)
   bei System.Xml.XmlDocument.Load(String filename)
   bei CDPlayer.CDPlayer.reloadSkinManager() in c:\Dokumente und Einstellungen\dottore\Eigene Dateien\SharpDevelop Projects\GBPVRPlugInSkeleton\CDPlayerTask.cs:Zeile 169.
   bei CDPlayer.CDPlayer..ctor() in c:\Dokumente und Einstellungen\dottore\Eigene Dateien\SharpDevelop Projects\GBPVRPlugInSkeleton\CDPlayerTask.cs:Zeile 159.
22.07.2006 18:41:41.475    ERROR    [1]       bei System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   bei System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy)
   bei System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
   bei System.Xml.XmlDownloadManager.GetStream(Uri uri, ICredentials credentials)
   bei System.Xml.XmlUrlResolver.GetEntity(Uri absoluteUri, String role, Type ofObjectToReturn)
   bei System.Xml.XmlTextReaderImpl.OpenUrlDelegate(Object xmlResolver)
   bei System.Threading.CompressedStack.runTryCode(Object userData)
   bei System.Runtime.CompilerServices.RuntimeHelpers.ExecuteCodeWithGuaranteedCleanup(TryCode code, CleanupCode backoutCode, Object userData)
   bei System.Threading.CompressedStack.Run(CompressedStack compressedStack, ContextCallback callback, Object state)
   bei System.Xml.XmlTextReaderImpl.OpenUrl()
   bei System.Xml.XmlTextReaderImpl.Read()
   bei System.Xml.XmlLoader.Load(XmlDocument doc, XmlReader reader, Boolean preserveWhitespace)
   bei System.Xml.XmlDocument.Load(XmlReader reader)
   bei System.Xml.XmlDocument.Load(String filename)
   bei CDPlayer.CDPlayer.reloadSkinManager() in c:\Dokumente und Einstellungen\dottore\Eigene Dateien\SharpDevelop Projects\GBPVRPlugInSkeleton\CDPlayerTask.cs:Zeile 169.

i changed the code to what you wrote in the first post.

[dottore]

uh, forget it, my fault.....wrong string

[dottore]

ah, no, same error as above, even when i change the plugin name from CD Player to CDPlayer. the folder "CDPlayer" absolutely exists in the skin/Blue - directory, NOT in sassari. in this case, gbpvr should pick the blue-skin, no?

and: why is that happening in the config-app? my programming-skills are really bad, so forgive me, if it is my error ;-)

[sub]

ah, no, same error as above, even when i change the plugin name from CD Player to CDPlayer. the folder "CDPlayer" absolutely exists in the skin/Blue - directory, NOT in sassari. in this case, gbpvr should pick the blue-skin, no?

Yes, it should. If its not, then zip and attach the logs and I'll take a look why.

and: why is that happening in the config-app? my programming-skills are really bad, so forgive me, if it is my error ;-)

From the look of it, its because you've created an instance of the SkinHelper in the constructor of the plugin, which also get created in the config app. Personally, I do initialization of the skin helper in IMenuTask.Activate() method the first time it is called. This way, if the user never views that screen, then it never consumes these resources.

Code:

bei CDPlayer.CDPlayer.reloadSkinManager() in c:\Dokumente und Einstellungen\dottore\Eigene Dateien\SharpDevelop Projects\GBPVRPlugInSkeleton\CDPlayerTask.cs:Zeile 169.
bei CDPlayer.[b]CDPlayer..ctor()[/b] in c:\Dokumente und Einstellungen\dottore\Eigene Dateien\SharpDevelop Projects\GBPVRPlugInSkeleton\CDPlayerTask.cs:Zeile 159.

[sub]

ok ill give it a try and see how well it works.

Cheers.

so can you add a third param called version? and just do a string compare on a special attribute "Version"
eg

Code:

<settings>
<Version>2.54.56</Version>
....
</settings>

and if they dont match, default to the blue skin.
thats what im basically doing manually now.

if its just a string compare then each plugin can use their own version numbering.

I can see your reasoning for wanting this, so I'll add an additional constructor which can take a third requiredVersion parameter. It'll behave as you suggest above.

If this constructor is used, but the <Version> tag is not present in the skin file, it'll assume its the correct version.

As long as developers are using either of these two constructors, then I will be happy.

[reven]

I can see your reasoning for wanting this, so I'll add an additional constructor which can take a third requiredVersion parameter. It'll behave as you suggest above.

If this constructor is used, but the <Version> tag is not present in the skin file, it'll assume its the correct version.

As long as developers are using either of these two constructors, then I will be happy.

thank you.

[daphatty]

Cheers.

I can see your reasoning for wanting this, so I'll add an additional constructor which can take a third requiredVersion parameter. It'll behave as you suggest above.

If this constructor is used, but the <Version> tag is not present in the skin file, it'll assume its the correct version.

As long as developers are using either of these two constructors, then I will be happy.

The day the My Series "just works" with whatever skin I want to use will be a happy day indeed.