Audio filters and Reclock

[sub]

It's only .ts files that it doesn't work with, hence why I suggested being able to select a different audio renderer for them.

Reclock seems fine with everything else.

Iain

For the most part, the audio renderer settings are only for .ts files anyway (and .mpg files if you have <ForceMpgGraph> set to true). Otherwise windows chooses the audio renderer.

[imilne]

For the most part, the audio renderer settings are only for .ts files anyway (and .mpg files if you have <ForceMpgGraph> set to true). Otherwise windows chooses the audio renderer.

Ok, that probably means we can't fix it that way then, because we'd need to be able to disable it for .ts files but enable it for everything else. Right now, I think we can only globally enable or disable it.

How about plan c), which is a modification of the script idea:

Could you get nPVR to fire off a Notify() event before creating a graph that could be picked up by a plugin.

Code:

"BUILDING_GRAPH_TS"     (for .ts files)
"BUILDING_GRAPH_OTHER"  (for everything else)

It should be very easy to respond to that and enable/disable Reclock as needed before the graph is built and it attempted to auto-insert itself into it. It would also be cleaner and potentially quicker than messing about with external scripts.

If you could build a quick patch that did this, I could give it a go and see if it's a viable solution or not.

Iain

[Reddwarf]

Ok, that probably means we can't fix it that way then, because we'd need to be able to disable it for .ts files but enable it for everything else. Right now, I think we can only globally enable or disable it.

How about plan c), which is a modification of the script idea:

Could you get nPVR to fire off a Notify() event before creating a graph that could be picked up by a plugin.

Code:

"BUILDING_GRAPH_TS"     (for .ts files)
"BUILDING_GRAPH_OTHER"  (for everything else)

It should be very easy to respond to that and enable/disable Reclock as needed before the graph is built and it attempted to auto-insert itself into it. It would also be cleaner and potentially quicker than messing about with external scripts.

If you could build a quick patch that did this, I could give it a go and see if it's a viable solution or not.

Iain

I think the only REAL solution to this would be to get the author of Reclock to make it able to work with multiple filters in the graph.

[imilne]

I think the only REAL solution to this would be to get the author of Reclock to make it able to work with multiple filters in the graph.

I intend to ask, but my current understanding of it is that Reclock only allows one audio stream per process. It's possible that because of what it's designed to do, it won't ever be possible for it to work with multiple filters. How would it know which one to pay attention to for instance? The ultimate real solution would be to never need Reclock (not feasible with mixed fps content) or to never notice the judder (damn my eyes).

Anyway, I've done some more testing and I think my solution may work if sub would be kind enough to tweak things enough to let me try...

Iain

[Reddwarf]

I intend to ask, but my current understanding of it is that Reclock only allows one audio stream per process. It's possible that because of what it's designed to do, it won't ever be possible for it to work with multiple filters. How would it know which one to pay attention to for instance? The ultimate real solution would be to never need Reclock (not feasible with mixed fps content) or to never notice the judder (damn my eyes).

Anyway, I've done some more testing and I think my solution may work if sub would be kind enough to tweak things enough to let me try...

Iain

Hm, is there no way for reclock to know what filter is the active one? I'm pretty sure npvr has to know.

[imilne]

Hm, is there no way for reclock to know what filter is the active one? I'm pretty sure npvr has to know.

I honestly don't know. Certainly with my setup (ac3filter for mpeg and ac3 audio), you end up with two copies of its tray app running, so technically they may both be active. Perhaps sub can help out with understanding what is or isn't possible with how the graphs work and what changes would have to be made to Reclock to make it compatible. It's all black magic to me

I'd still like to test my idea too though.

[sub]

Hm, is there no way for reclock to know what filter is the active one? I'm pretty sure npvr has to know.

If the audio path is getting media samples, then it is the active one. The other audio paths get no samples.

[imilne]

For the most part, the audio renderer settings are only for .ts files anyway (and .mpg files if you have <ForceMpgGraph> set to true). Otherwise windows chooses the audio renderer.

Are you sure about this sub?

I've just discovered that if you tell Reclock to not override the default audio renderer (which is how it normally inserts itself into a graph) then it won't load for all of the following file types: .ts, .avi, .mkv, .wmv, .mp4 - this is what I would expect.

However, if I then change the audio renderer in NPVR to explicitly use Reclock, then it does load for *all* of those files, not just the .ts ones.

This would suggest that allowing an extra option to specify the renderer used for .ts files independently of the other file types might be a possible solution. Reclock could then be avoided for .ts files but used for everything else.

Alternatively, if a plugin could get the graph_started events I suggested, then it could change the <AudioRenderer> config setting, tell NPVR to reload its settings, then hopefully the graph would be built with or without Reclock as needed.

The plugin option also keeps this stuff away from users who don't care about it and means a lot less work for you too

Iain

[sub]

I double checked, and found it does use the audio renderer setting for all files. It was the audio decoders that are only used for .ts files.

It's unlikely I'd add additional renderer settings. I dont want to ugly up the Settings screen with all sorts of settings for very specific cases that very few people care about. I can probably fire an event to let you know it's about to build a graph, and it's filename.

[imilne]

It's unlikely I'd add additional renderer settings. I dont want to ugly up the Settings screen with all sorts of settings for very specific cases that very few people care about.

That's what I figured (and agree with).

I can probably fire an event to let you know it's about to build a graph, and it's filename.

So long as there's a way to know when it's Live TV too, that would be excellent.

Many thanks.

Iain