More "efficient" redraw?

[mvallevand]

ccnb, may be your right, I noticed I have a line in the GetRenderList() that returns this

Code:

if (isActivated == false)
            {
                return new List<UiElement>();
            }

isActivated is set false by my popup code.

Martin

[cncb]

Ok, but why is GetRenderList() on the plugin screen being called when NeedsRendering() for the plugin is returning false?

[sub]

Ok, but why is GetRenderList() on the plugin screen being called when NeedsRendering() for the plugin is returning false?

Probably because the screensaver is returning true from it's NeedsRendering(). Like the default one when it animates.

[cncb]

Probably because the screensaver is returning true from it's NeedsRendering(). Like the default one when it animates.

I changed my popup/screensaver to always return false for NeedsRendering() but GetRenderList() on the popup/screensaver is still called multiple times per second so I think there might be an underlying problem here...

[sub]

Given it's working for others, I'm inclined to think it will something that is being done in this plugin or screensaver, but I'm happy to take a closer look if you can provide the binary files for me to reproduce it here - without me having install extra apps on my development machine (which is currently nice and clean after a fresh Windows install on a new drive).

[cncb]

I think I have finally narrowed this down. It seems to be the black background in the popup causing it. The attached simple example plugin shows a popup with a black background when you select the single list item. I have NeedsRendering() for the popup always returning false. It sits there for several seconds not updating the time text and then all the sudden the time text is updating every second and GetRenderList() is called multiple times per second as can be seen in the log file. If I don't add the black background in GetRenderList() then this GetRenderList() call flurry never seems to occur.

I can post the whole project with source if you want. Here is how I am creating the black background/UIElement (as you suggested I do it when I asked a while ago):

Code:

Bitmap black = new Bitmap(32, 32);
Graphics g = Graphics.FromImage(black);
g.Clear(Color.Black);
g.Dispose();
_Black = new UiElement("screensaver-black", new RectangleF(0, 0, 100, 100), black, 255);

[whurlston]

Is that code in your GetRenderList()?

Try defining "_Black" as a global variable. When you need the background, set a variable to true ("_needsBlack" for the purposes of this example).

Then modify the above code with:

Code:

if (_needsBlack)
{
  if (_Black == null)
  {
    Bitmap black = new Bitmap(32, 32);
    Graphics g = Graphics.FromImage(black);
    g.Clear(Color.Black);
    g.Dispose();
    _Black = new UiElement("screensaver-black", new RectangleF(0, 0, 100, 100), black, 255);
  }
} else if (_Black != null)
{
  _Black = null;
}

Currently, it seems that you are creating and disposing the bitmap whenever you need to render _Black.

[cncb]

Is that code in your GetRenderList()?

Try defining "_Black" as a global variable. When you need the background, set a variable to true ("_needsBlack" for the purposes of this example).

No, '_Black' is a class member variable and the code above is from the constructor so it is not being created multiple times.

[whurlston]

Ah, then ignore everything I just said. Can you post the source to that test plugin?

[cncb]

Can you post the source to that test plugin?

Attached