Media Browser Integration

[lukemb3]

we could also revert his changes if that would be easier.

[mvallevand]

I've got another patch if Svekke wants it.

Martin

[lukemb3]

Yes please.

[Svekke]

Yes, you can put the patch here.

Didn't know you changed that stuff to download some specific stuff.
Give me a new patch and i will update it for you.
With your changes.

[mvallevand]

Ok I modified it to match yours as much as possible last night but I can't see if you modified anything since because github is not responding Edit github is now back and you didn't change anything so the source should be ok

- I want to leave some of the response processing after recordings that you had in originally to deal with the 500 returns on conflicts (once I understand how to add UI in a plugin)
- I removed some of the the things the user can't change on an recording timer/series Update (NextPVR limitation)
- fixed the epg update start end date

I recommend that you move CloseLiveStream directly after GetChannelStream before submitting, it is a nuisance find it as I worked on both. Alternatively make all the calls alphabetic.

Martin

[lukemb3]

Quick question, after these changes are incorporated, is it more or less feature complete, aside from the three things you mentioned earlier that you should we should add?

[lukemb3]

Also, in GetStatusInfo

https://github.com/MediaBrowser/MediaBro...ce.cs#L770

The return object has a property that is the list of Tuners. This list is then displayed on the live tv dashboard page. Is this possible? And if so, is this then possible:

https://github.com/MediaBrowser/MediaBro...ce.cs#L805

That's the reset tuner method. It's not used internally, just on the dashboard page in the event the user is having some kind of issue.

[mvallevand]

Quick question, after these changes are incorporated, is it more or less feature complete, aside from the three things you mentioned earlier that you should we should add?

As a minimum I need to work things out for multiple client from one server. The streaming API was designed for client. If there is a client id available I'd use that other I was going to modify the dictionary.

I did a good amount of testing on the weekend but the code got smashed a couple of times so I want to do that again.

I need to fiind out how to clear the cache to get to the bottom of the annoying paramater error

I will also write up more details on my suggestions for improvement.

It's not ready for release for a few weeks when 3.2.x is released so there shouldn't be a rush.

Martin

[Svekke]

I did a new merge!
The changes you made in some other code then the livestream is just for Test purpose? Or .......?

[mvallevand]

I did a new merge!
The changes you made in some other code then the livestream is just for Test purpose? Or .......?

The response handling with test was copied from your code that I started from but removing it and replacing it with exceptions seems wrong Since lukemb3 explained there is no UI I have just put them to exception.

However why are you not using git apply or a patch program to make the changes? Now I just have to remove all the commented out obsolete code and all those mvallevand regions that using github for source mgt avoids with the attached patch, just to finally get us in sync so we can go.

the syntax for patch from the command line is

patch -u -i mb3-5.patch

Depending on the version of patch in win32 you might need to reload files to use your unix style linefeeds. As a Windows app not using cr/lf causes me endless headaches in VS2012

Martin