[DEV] Installation options

[Hairy]

Wow that's really weird!

Well it was worth a shot

[McBainUK]

I still think it's a good idea though as it simplify how to distribute and apply a default theme. Testing things out now...

Works good.

svn commit:
* Installer changed to install default theme using SkinPluginHelper.exe and ThemeChanges.xml.
* Removed duplicated _CoreImages and _TaskImages contents.
* Un-installer now correctly removes SkinPlugin4 plugin folder.

[McBainUK]

What exactly is happening in known issue #2?

"Current Skin question on install - answering no to the “set current skin to the Community Skin” question when installing will cause the install to be incomplete. status: Until resolved it is recommend to click yes on this popup."

To apply the default theme the ThemeChanges.xml file is set to the theme to change to (just like when it applies whole themes or selected EditableSkinItem in the plugin).

Once the installer is finished it launches SkinPluginHelper.exe which runs as normal-loads ThemeChanges.xml, and copies the files and applies the XML edits to the CURRENT ACTIVE SKIN. So, if the active skin isn't CS-SD/HD it will copy files to whatever skin is active.

I think all that is required is to add an optional argument to the SkinPluginHelper.exe which is the skin to apply the changes to.

I still think it's a good idea using the exe to apply the default theme as it means a slightly smaller install package and more importantly inits the CurrentTheme.xml file and previews just copying and renaming a theme to ThemeChanges.xml on the SVN - no more matching the files in the _CoreImages folder to a theme file.

Thoughts?