Config.xml saving

[mvallevand]

When I hit OK to exit Config.exe I am noting that the changes I make in the Plugins /settings/PluginSettings/MusicLibrary section are being reverted. If I hit cancel the changes are kept. Does GBPVR overwrite this section?

Note the section name is MusicLibrary the plugin name is MusicLibrary3 if that makes a difference.

Martin

[whurlston]

That will happen if you are writing to the file manually. You should be updating the XMLDocument passed by the form constructor. Config will save that when it exits using "OK".

Code:

namespace MovieLibrary
{
    public partial class ConfigForm : Form
    {
        private System.Xml.XmlDocument settingsXML;
        public const string cfgSection = "MovieLibrary";

        public ConfigForm(System.Xml.XmlDocument settings)
        {
            // move settings to a global variable so we can access it from other functions
            settingsXML = settings;

            // Initialize the form;
            InitializeComponent();
          
        }
  
        // Example function
        // Fired when user clicks the plugin settings ok or cancel button
        // This is not the main config ok cancel button
        private void Button_Click(object sender, EventArgs e)
        {
            Button btn = (Button)sender;
            switch (btn.Name)
            {
                case "cmdOK":
                    // Update setting
                    settingsXML.SelectSingleNode("/settings/PluginSettings/MovieLibrary/MySetting").InnerText = "MyValue";

                    // Close the form
                    this.Close();
                    break;

                case "cmdCancel":
                    // Close the form without saving
                    this.Close();
                    break;
            }
        }
        
    }
}

[mvallevand]

Thanks whurlston that clarifies things and also the

if (!this.Plugin)

on the saves in the plugin code, I didn't account for this. The downside seems to be I can't avoid the user hitting cancel by config.exe

Martin

[whurlston]

Thanks whurlston that clarifies things and also the

if (!this.Plugin)

on the saves in the plugin code, I didn't account for this. The downside seems to be I can't avoid the user hitting cancel by config.exe

Martin

You could write the changes manually and update the xml document. Double coding but then it insures the save whether they hit OK or Cancel.

[mvallevand]

That sounds like a good idea (except the order sounds reversed).

Martin

[Ommina]

A perspective from the other side: as a user, if I hit cancel, I'd be annoyed if the changes were saved anyway.

[mvallevand]

That depends, the setting that I am saving is the database update time, and the user did already hit OK to save the change in the Plugin's Windows form. The database itself has already been committed to disk too but the next rescan won't know about it.

The proper fix is to put the scan time somewhere else maybe even in the database.

Martin