LoadRecordingSchedule()

[reven]

i have a problem in my videos where at load LoadRecordingSchedule() causes me problems and forces my videos to stop loading, and gbpvr to restart loading every plugin, trapping it in a forever loop and maxing out the cpu and ram. this problem has been in my videos for a while, and only know have i found out why. im using this code

Code:

foreach (ScheduledRecording scheduledRecording in GetScheduledRecordings())
                    {    
                        if(scheduledRecording != null)
                        {
                            if(scheduledRecording.getFileName().ToLower().EndsWith(fullName.ToLower()) && scheduledRecording.getProgramme() != null)
                            {
                                Description = scheduledRecording.getProgramme().getDescription();
                                Title = scheduledRecording.getProgramme().getTitle();
                                Subtitle = scheduledRecording.getProgramme().getSubTitle();                            
                                TimeSpan runtime = (TimeSpan)(scheduledRecording.getProgramme().getEndTime() - scheduledRecording.getProgramme().getStartTime());
                                Runtime = ""+ (runtime.Hours*60 + runtime.Minutes);
                                if(Subtitle.Length > 0)
                                {
                                    displayName = Subtitle;
                                }        
                                MyVideosTask.database.AddToDatabase(new VideoInfo(fullName,description,Title,Subtitle,Runtime,"","",Seen,null),false);
                                break;
                            }
                        }
                    }
                }

and this is GetScheduledRecordings()

Code:

private IList GetScheduledRecordings()
        {
            Logger.Verbose("entered recording schedule");
            if(ScheduledRecordings == null)
            {
                Logger.Verbose("debug 1");
                ScheduledRecordings = ScheduleHelper.getInstance().LoadRecordingSchedule();
                Logger.Verbose("debug 2");
                ScheduleLoadedAt = DateTime.Now;
                Logger.Verbose("debug 3");
            }
            else if(DateTime.Now > ScheduleLoadedAt.AddMinutes(30))
            {
                Logger.Verbose("debug 4");
                ScheduledRecordings = ScheduleHelper.getInstance().LoadRecordingSchedule();
                Logger.Verbose("debug 5");
                ScheduleLoadedAt = DateTime.Now;
                Logger.Verbose("debug 6");
            }
            Logger.Verbose("debug 7");
            return ScheduledRecordings;
        }

ignore the debug lines .

anyway when i run this the GetScheduledRecordings doesnt even get called it crashes somewhere before then (the same line of code, just before the method is called, found this out by useful debug lines ). im just wondering if anyone knows why this is happening and how i can fix this.

i put a temp fix on it by using a boolean LOADING, which i set to true when my vids is created and false once all the loading is done, and when LOADING=true i just skip this method.

i can use this fix without much problems, but if a entry in the myvids database doesnt exist for a file, it will check the recordingschedule to see if a description exists in there (and when loading it checks the virtual root + paused files... which is how i discovered the problem). paused files isnt a problem since that is refreshed whenever a videostopping event happens. but the root never gets refreshed (well hardly ever, it might do i have to check the code).

i think this is the same problem jeff was having with vidarch awhile ago.

anyway, long boring post has finished

TIA
reven.

[sub]

Are you doing this in the constructor for the plugin? If so, you should really being doing this the first time Activate() method is called in your plugin.

Loading the recording schedule can trigger the plugins to be loaded if they havn't already (primarily for the recording source plugins), which in turn will find your plugin again, which will load the recording schedule, which will load the plugins and so on and so on.

[sub]

I've added a small piece of logic to stop this happening in the next release, but I still recommend you do any initialization in the first call to Activate().

[reven]

i dont like putting it in the activate method, it just slows down the program (well the first time you enter it). i prefer for gbpvr take a few seconds longer to load, than a few seconds longer to open a plugin. the only reason the recording schedule is being loaded is when trying to find a description/title/subtitle for a unknown file, and it doesnt really happen that often (most of the videos should be in the my vids db). and its just one of the methods used to get the description
1. my vids db
2. recording schedule
3. .details file
4. use the parent

thanks for the fix thou. after thinking about it for a little longer, the bool i set should work, since if you just define the "recordings" directory for the virtual root, there shouldnt be any loose files in that folder anyway, so nothing to check for description from recordingschedule (only movies are checked with this method aswell), so i might just keep the boolean around.

well at least that bug is now fixed

[Jeff]

Yes, I had a similiar problem in that like you I was also doing lots of initialization earlier on to make the plug-in more responsive. I chnaged it so now I call my init routine the first time the GetName() method is callled, which GBPVR calls to get the button name to build the menu. This happens late enough in the process that GBPVR is settled down but still happens earlier enough fr me to start loading things in a background so that the first time Activate() is called the plug-in is usually pretty well along iun setting itself up.

Jeff

[reven]

getname, thanks for the tip, i can easily add a check in there to see if its the config getting the name or actually gbpvr.