Pre My Vids 3.2

[markm]

I'm curious, what's your thoughts on how to handle it?

The ability to play them is an obvious fix. Do you intend to make it so they don't even appear in the list, if the video is under a pin protected root?

What I was thinking would be nice, but probably not easily done, is if it remembered that you've entered a pin for an area/video. If you've entered a PIN, you can see/play them from the paused menu.

I don't think remembering that the PIN was entered would be hard. It's just a matter of knowing when it should "forget". I was thinking if you exited my videos, the pin would be forgotten and you'd have to re-enter it again.

Damn kids always complicate things. It was much easier when I didn't have to worry about them using stuff like this Now that they know how, gotta make sure they can't watch what they shouldn't, yet still allow us to.

Which leads me to another suggestion It would be really nice if when grabbing movie info, if the MPAA rating was gotten/displayed. I could care less how many stars someone rated a movie, I tend to like to know the G/PG/R type rating. That whole kid thing again

[reven]

when you click play it will just ask you for a pin like it usually does.

i dont like the idea of remembering if you inputted a pin (i decided against this awhile ago), in most cases all you have to do is input 4 numbers, it doesnt take long. and if you want to guarantee (well almost) that no unauthorized users will watch these files this is the only way to do it (was going to try remembering the pin was entered for say 10 minutes, but nah).

Which leads me to another suggestion It would be really nice if when grabbing movie info, if the MPAA rating was gotten/displayed. I could care less how many stars someone rated a movie, I tend to like to know the G/PG/R type rating. That whole kid thing again

this might already be possible, its a skinning thing (i have to check thou, i made most things skinnable this way, just have to replace @Rating in the skin file with something like @Certification, ill check later and if not available add it. and before you ask i can restrict based on the certification, its not always set, and there are different country ones (i try and get USAs one (even thou im in nz) just because its the most common, but still, no guarantee)

[reven]

i just went to fix the pin problem, and to my surprise the code was already there, so went and tried it on gbpvr, and it asked for the pin numbers for locked movies as expected. are you sure its not working?

also certification isnt available in the current version, but ive added to the next build.

[markm]

When I had quickly tested it, it wasn't asking for the pin, but I probably know why.

There's a couple of paths to my files. They're on a linux server, so I can use symlinks to redo trees as needed. Most of it stems from the various media players I've used over the years, and I haven't cleaned it all up yet

So the path I give to My Videos, is different than I use for the builtin video plugin. I will sometimes preview stuff using the builtin. My Videos seems to show these in the Paused root, and probably because there's 2 paths to the file, one protected and one not, shows the lock icon. That's my WAG, you'd know better how it figures it out.

So I guess that part isn't a bug, just my implementation. Having it show the covers is still a problem though, since for some things, the cover shouldn't be seen either :eek:

It'd be cool if that could be addressed, but if not, I'll just have to do without the Paused root.

I know you're not big on the idea of expiring the PIN, this is more me thinking outloud... Been months since I hacked at a plugin, so I'm probably wrong in my assumptions, but based on a recent post from sub, I was thinking when the plugin's Activate method was called, remembered pins would be flushed. I agree that a timeout would be ugly. The assumption here though, is that the Activate method is called each time you "enter" the plugin from the GBPVR main menu.

So basically, while you're in the plugin, pins are cached. When you leave and come back, they're flushed. I just don't know if there's any context that lets you know the user has left and come back.

[reven]

if the icon is showing up "locked" it should ask for the pin. the locked icon only shows up if the pin doesn equal "" (blank) or null. err sorry for following explaination, its just how i do things
if(pin doesnt equal "" or null)
showLockedIcon;

then when we try to play a file
if(pin doesnt equal "" or null)
askforpin()
else
playfile

so if the locked icon is shown, it *should* ask for the pin.

[reven]

markm, just so we are clear the "lock" icon does get displayed, but it doesnt ask for the pin right? (or doesnt the "lock" icon get displayed?)

[markm]

This is weird.

I just loaded it up on my test box (where I saw the problem initially), when into the Paused menu, selected a movie with a lock icon on it, and started playing it, no questions asked.

I stopped it, and selected it again from the Paused menu to play it, and was prompted for a PIN. Every time after it prompted me for a PIN.

I grabbed another movie with a lock icon, and the same thing happened, I played it once, then it kept asking for a PIN on further playback.

Now I'm unable to reproduce it NOT asking for a PIN anymore. I'm totally boggled by this.

Here's another thought on PIN's and locked items, and something I implemented in an old VB based media front end I did before slick stuff like gbpvr and myvideos was around.

Things that were PIN protected were simply hidden, period. They never appeared in any menu/folder. You'd hit a button on the remote if you wanted to "unhide" things, and you'd be prompted for the PIN then. At that point, things that were hidden were now visible.

If nobody knows it's there, nobody's going to be tempted to try and guess the PIN, or find alternate ways of getting around the PIN.

It seems like myvideos could easily behave this way by simply no longer showing anything it thinks is locked. They'd simply not appear, no name, icon, placeholder, nada.

[reven]

weird bug. ill see if i can reproduce it, but every time i try to play something its always asked me for a pin, must be something silly i over looked.

and the hidden thing, nah i prefer to show everything, in most cases the pin does what it suppose to do, keep people from playing a few files (mostly kids), just choose a pin that no one will guess. you can have like a 10digit pin if you wantto make it even harder for a kid to guess the pin.

[reven]

i had a go at fixing the "pin" bug, it might have been a refresh issue (the paused files were only being refreshed when a video stop/started now its also refreshed when you enter "paused movies").

[KingArgyle]

ive updated the zip in the first post, and it fixes some of the issues with the last one.

oh and ive added "External Player" for video and dvd (not for isos thou, im to lazy), i havent tested if the player works, but if someone can test it with say zoomplayer and see if it works, that would be great (KingArgyle was suppose to test it, but hes been on away for the last few days).

Reven I've finally had a chance to test this out. At least with GBPVR Version .9109 I can't play any videos at all regardless of whether I have the external player setting set or not. I get the following message as soon as I select a movie to play:

Code:

Method not found: Void GBPVR.Public.IPluginHelper.PlayVideoFile(System.String, System.String).   :     at MyVideosPlugin.Player.PlayVideo(String filename)
   at MyVideosPlugin.MyVideosTask.OnDoubleClick(Point location)
   at ci.c(Point A_0)
   at r.f(Object A_0, EventArgs A_1)
   at System.Windows.Forms.Control.OnDoubleClick(EventArgs e)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.ContainerControl.WndProc(Message& m)
   at System.Windows.Forms.Form.WndProc(Message& m)
   at r.a(Message& A_0)

I'm downloading .9112b right now and will see if that makes any difference. The above message shows up whether I use the external player option or not.

Will let you know how it works with .9112b

It seems to be working alright with version .9112b, now to test the external player and see if it launches zoomplayer or not.