Memory leak when updating recordings on all channels

[smiffypr]

NPVR 2.1.4 on windows xp

In a Recurring recordings, doing an update on one set for all occurrences, it takes about 5 seconds, and increases the size of NextPVR.ex by 54 MB. While updating lots, NectPVR.exe got to over 1.5GB.

[sub]

Hmmm. I'm not really sure what that could be doing that. It doesnt seem to be doing it here, but reproduce the problem there, then zip and attach the npvr.log and I'll take a look.

In a Recurring recordings, doing an update on one set for all occurrences

So to confirm - you're just going into a recurring recording, selecting update, then hitting 'ok' without changing anything?

[smiffypr]

Yes, but it has to be one set-up for all channels.
Log attached. (OK clicked at 12:01:02, update window closed at 12:01:08)
It seems to be going through the whole list of recurring recordings, which is 82 of them.

[sub]

It seems to be going through the whole list of recurring recordings, which is 82 of them.

This is normal. It does reprocess all recurring when recordings when you update a recurring recording, since it can have conflicts with any of the other recurring recordings.

I've been looking for any leaks, but I cant see any sign of any. I'm wondering if what you're seeing is a case of .NET garbage collection just not kicking in yet because the system isnt feeling like it's running short. ie, memory not being used any more, but .NET hasnt freed it up yet. I'm not really sure how we'll check that. I might be able to put in some temporary 'force garbage collection' button in the Setting screen so you can see if clicking it helps.

None of this stuff has changed since the last release, so it shouldnt be any different to pre 2.1.4.

[sub]

Any chance you could zip and attach your npvr.db3? or email it to me if you prefer - I can PM you my email address.

[smiffypr]

It isn't something which I'm likely to do often, but I thought it worth raising because of the memory use.
I have no idea what .NET garbage collection is or does, but if there are any diagnostics I can run, let me know.
npvr.db3 attached.

[sub]

If you look at the task manager while you're doing it, does the memory increase when you hit the 'ok' button, or has it already gone up just viewing the update screen.

[smiffypr]

Start NPVR, NextPVR memory usage 56,232K
Go to Recurring Recordings screen, 107,888K
Go to a "all channels" entry 124.928K
then select update 154,968k
click OK, mem usage climbs in steps to about 185,000k then drops back to 166,636k
select update again (on the same recording) 183,708k
click OK, mem usage climbs in steps to about 198,000k then drops back to 186,012k
Repeat a further 10 times, now up to 435,132k
So the biggest increase is when entering the update screen (30M) with a smaller increase when it actually does the updates (3M).

[sub]

Can you see if this helps?

Hopefully the attached patch should help. It may still climb slightly, but hopefully not the big jumps your were seeing. This problem wasnt new to 2.1.4.

[smiffypr]

That actually makes it slightly worse, 12 updates result in a size of 460,000k odd, but then it does drop over the following minute or two to stabilize at 430,240k, which is ever so slightly better.