Memory leak when updating recordings on all channels

[sub]

Do you have animation disabled in the settings screen?

[smiffypr]

I am doing it on the machine (not remotely).
I don't know what you mean by animations on the main menu. Everything is static.

[sub]

In the Settings -> General screen, is animation enabled?

[smiffypr]

It wasn't. It is now.
"dispose" now appears in the debug. See attached log.
Now after 12 updates, NextPVR.exe size is down to 330,512KB

[sub]

It wasn't. It is now.
"dispose" now appears in the debug. See attached log.

Yep, I'd worked out that was the cause. The attached patch should get the disposing working with animation disabled. I havnt been able to check this though.

Now after 12 updates, NextPVR.exe size is down to 330,512KB

Thats obviously still not right. After pressing enter on a recording what does the memory increase to? After selecting 'update', and the next popup appears, what does it increase to? If you then press 'cancel' to dismiss the popup (without updating the epg) what does it drop back to? Then what happens on the second go through the same? Then a third? Do this with the attached patch, then post the npvr.log again.

[smiffypr]

Prior to pressing enter, memory size settles at 108,956KB,
After pressing enter on a recurring, all channel recording, memory is 125,076KB
If I press "close" memory drops to 108,316KB
Repeat and its 108,300KB, repeat again, 108,304KB.

[sub]

Prior to pressing enter, memory size settles at 108,956KB,
After pressing enter on a recurring, all channel recording, memory is 125,076KB
If I press "close" memory drops to 108,316KB
Repeat and its 108,300KB, repeat again, 108,304KB.

So not leaking at all during this activity? At least that sounds like the screens arent leaking anymore, which was the problem I found.

In that test, if you replace the cancel, with ok, so that does the update, what happens with the memory on the same steps?

[smiffypr]

Prior to pressing enter, memory size settles at 108,048KB,
After pressing enter on a recurring, all channel recording, memory is 125,048KB

If I press "update" memory is 138,276KB
After I press OK, memory is 152,644KB
Repeat and its 165,512KB, repeat again, 200,868KB.

[sub]

After pressing enter on a recurring, all channel recording, memory is 125,048KB
If I press "update" memory is 138,276KB
After I press OK, memory is 152,644KB

If you go that far, but press cancel instead of ok, what does it drop back to? (i think you were previously only going to the first popup, not the second)

I think its the second popup leaking, not the actual act of updating the recording, because there is still a missing "ScheduleRecordingPopup.Dispose()" message in your logs.

[sub]

I've got to switch off for the night.