Memory leak when updating recordings on all channels

[smiffypr]

Prior to pressing enter, memory size settles at 107,756KB,
After pressing enter on a recurring, all channel recording, memory is 124,720KB

If I press "update" memory is 137,992KB
After I press "Cancel", after a few seconds,memory drops to 124,386KB
Repeat and its 140,684KB, repeat again, 146,964KB.

[sub]

I've added some more logging. Can you try again with this patch, then post the logs again?

[smiffypr]

This is with an OK not a cancel. Memory use ends up at 148.668.

[sub]

Can you see if this fixes it?

[smiffypr]

Same actions as last time, but this time the memory ends up at 116,124KB.
Repeating, 113,440KB.
And again, 115,172KB
I would call that fixed!

[smiffypr]

This is normal. It does reprocess all recurring when recordings when you update a recurring recording, since it can have conflicts with any of the other recurring recordings.

Now that you have fixed the memory leak, can I ask about the "logic" of the above without sounding like a whinger?

Surely the recurring recording which is being updated need to be checked against all pending recordings, not against all recurring recordings, many of which don't relate to any pending recordings currently, and the update of the one recurring recording won't cause any of the other recurring recordings to generate a new pending recording?

[sub]

Same actions as last time, but this time the memory ends up at 116,124KB.
Repeating, 113,440KB.
And again, 115,172KB
I would call that fixed!

Great.

[sub]

Surely the recurring recording which is being updated need to be checked against all pending recordings, not against all recurring recordings

It is checking against the pending recordings, rather than the recurring recordings, but as part of this it deletes all pending recordings then recreates them. Some recurring recordings will result in no pending recordings based on the current guide, but others will and some of those may conflict with the changes that have just been made.