2.1.4 - Recordings Plugin really slow.

[sub]

Did seem a bit faster, but it's via a vnc connection, which I had to do something, then move the mouse to get the screen to update, so its a bit deceiving.

In the logs it looks very quick now, so I'm hoping its probably just vnc making it still look slow.

I assume (looking at the logs) you removed the check onthe playback position?

Yes, I did. It wasnt intentional though. I had tried change it to only lookup the playback position when the was going to show the list item, but I implemented it wrong. The attached should fix it.

[psycik]

I'll try that in a couple of minutes....Does the watch/unwatched system need a bit of a revisit. So rather than processing a file path and looking up the DB...to store a watched flag for each recording?

This would give you the ability to add a new screen for Unwatched as part of the recordings...and I suspect be a bit faster. I only mention this after playing with XBMC lately, and the ability to show new (which you have) and show unwatched it useful.

[psycik]

Ok it's loaded...but I realise, in my clean up last night I removed all the network based playback position entries. So don't know if this is distoring results or not. I have this morning though, reinstated all of the recordings to the external machine (via recording import).

I'll run it for the day and see what happens.

[sub]

I'll try that in a couple of minutes....Does the watch/unwatched system need a bit of a revisit. So rather than processing a file path and looking up the DB...to store a watched flag for each recording?

No, shouldnt have to. The current scheme generally works well, but looks like it needs a bit of optimization. There is no reason it cant be fast. Also, the current scheme is also used for the video library resuming (where a video file may not have any associated recording object). The load-on-demand scheme in that last patch should give good performance, but if it doesnt, I do have another change in mind.

This would give you the ability to add a new screen for Unwatched as part of the recordings...and I suspect be a bit faster. I only mention this after playing with XBMC lately, and the ability to show new (which you have) and show unwatched it useful.

I could look into adding an unwatched list to recording screen. It'd be pretty straight forward.

[mvallevand]

Do the patches in this thread apply to 2.1.5? The thread says 2.1.4

Martin

[sub]

2.1.5. He started the thread when 2.1.4 was the current release though. I only ever do patches for the current release.

[psycik]

No, shouldnt have to. The current scheme generally works well, but looks like it needs a bit of optimization. There is no reason it cant be fast. Also, the current scheme is also used for the video library resuming (where a video file may not have any associated recording object). The load-on-demand scheme in that last patch should give good performance, but if it doesnt, I do have another change in mind.

Does this mean that adding watced, unwatched flags to the video library would also be relatively simple?

I could look into adding an unwatched list to recording screen. It'd be pretty straight forward.

Ok that would be cool.

[psycik]

2.1.5. He started the thread when 2.1.4 was the current release though. I only ever do patches for the current release.

Was 2.1.5 on all components? As I assume I'm now on split patches (2.1.4 for nrecord and supporting), 2.1.5+ for npvr.

[sub]

Does this mean that adding watced, unwatched flags to the video library would also be relatively simple?

In the video library I only use this info to decide whether not to present the resume prompt. I dont want to have extra popus for items in the video library so there is no place to show a unwatch button etc, so probably wouldnt add the watched/unwatch functionality there.

[psycik]

In the video library I only use this info to decide whether not to present the resume prompt. I dont want to have extra popus for items in the video library so there is no place to show a unwatch button etc, so probably wouldnt add the watched/unwatch functionality there.

Ok. Less of an issue.


So should I load down 2.1.5, and then reapply that patch you've just posted?