Replace characters in strings

[bgowland]

Initially I thought I had this working but it appears it doesn't. Not sure what I'm missing here. Trying to remove characters from channel names which are invalid for file names...

Code:

char[] InvalidPathChars = System.IO.Path.GetInvalidPathChars();
...
foreach (String chanName in chanNamesList)
{
    StringBuilder sb = new StringBuilder(chanName);
    foreach (char item in InvalidPathChars)
        sb.Replace(item.ToString(), "");
    String chanLogoFilename = sb.ToString();

    Log.WriteLine("GenerateChannelLogosFile() - Looking for logo: " + chanLogoFilename);
    // Append .jpg, .png and .gif in turn to try to find channel logo image file
    ...
}

However when I look at the logging for the channel 5*, I see...

Code:

GenerateChannelLogosFile() - Looking for logo: 5*

...so the asterisk obviously isn't being removed and my 5.png file obviously isn't being found. I just can't see what isn't working - anyone any ideas?

Cheers,
Brian

[imilne]

If it was java it'd need to be something = sb.replace as strings are immutable - you can only make new ones, not change existing ones. Might be different with a StringBuilder tho.

On my phone, hence shortish reply.

Iain

[bgowland]

If it was java it'd need to be something = sb.replace as strings are immutable - you can only make new ones, not change existing ones. Might be different with a StringBuilder tho.

As it turns out, doing it in Java was a bit of a pig but I actually got it working - it was then I realised it was looking for 5.png but the nDroid Server wasn't packaging it.

As ever, 10 minutes after posting a dev question I've worked it out (despite staring at it for 30 minutes before posting). Thinking about it * is, in fact, a valid path character, e.g., dir c:\*.* so the char[] returned by System.IO.Path.GetInvalidPathChars() doesn't include it. What I needed was...

Code:

System.IO.Path.GetInvalidFileNameChars()

...instead. Doh!!!

Cheers,
Brian

[ACTCMS]

As ever, 10 minutes after posting a dev question I've worked it out (despite staring at it for 30 minutes before posting).

We used to call that 'Structured Walkthrough' - it seldom fails...

Alex

[bgowland]

We used to call that 'Structured Walkthrough' - it seldom fails...

Alex

Yes it's pretty effective....I just wish I'd posted the question 30 minutes earlier rather than doing the "staring at my code" thing.

Cheers,
Brian

[mvallevand]

http://forums.nextpvr.com/showthread.php...post383840

Martin