Media Browser Integration

[mvallevand]

I should correct those numbers a little. If the guide has not been downloaded, it's usually 1-2 minutes, but on subsequent runs where it's just updating data, it's very fast, 10-20 seconds because it's not going to re-download images that were already downloaded.

I likely notice it more because I get the 1-3 minute hit everytime I reload to test my changes. To be fair the version of NEWA I have is doing an insane amount of logging, something like 15,000 lines per channel or more than a million on an update.

Martin

[UncleJohnsBand]

I likely notice it more because I get the 1-3 minute hit everytime I reload to test my changes. To be fair the version of NEWA I have is doing an insane amount of logging, something like 15,000 lines per channel or more than a million on an update.

Martin

Yea.... I need to back that off....

[mvallevand]

If it's fixed then I stand corrected on that. I have not worked with next pvr myself ever since I handed it off to Sven. And that was 4-6 weeks ago so I may not be fully up to date.

Fixed yes. plus There is also the other bug I mentioned. If "The Big Band Theory" is on 100s of times in the two week period, MB3 downloads it many times and saves it with a unique guid in meta data folder. Right now I have almost 5000 folder.jpg in the metadata folder and I only have 321 files with cover art in NextPVR collection (which is why I am forcing null) I don't have any Video or Music Library in MB3 so that is all from EPG downloads.

Martin

[mvallevand]

Luke, have a look at the attached, I guess there was a refresh at midnight. You can see call to the backend and then the server processes it for 4x as long with the Running ProgramImageProvider lines and I had stripped out the url so there is nothing to fetch. I working with UJB to reduce the NEWA overhead on logging etc, but that's an expensive call.

Martin

[mvallevand]

Can you review the recording management functions? Specifically CreateTimer and CreateSeriesTimer.

Then we have some unimplemented methods:

https://github.com/MediaBrowser/MediaBro...#L451-L465

They are done with the notable exception that some NextPVR features do not seem to be implemented in MB3

- selection of recording directories
- number of recordings to keep
- extend the end time of recording

NextPVR doesn't currently implement mandatory padding.

If you were to complete those I believe the guide and schedule would be fully manageable. Once those are done I can give details on what is needed for playback.Thanks.

I am looking forward to the playback details.

Martin

[lukemb3]

I'm not really a live tv user so to be honest I'm not sure what those are. If can explain each of them to me I'll get them added to our roadmap, maybe even make stubs in the interface now even though they won't be used yet.

I'll get you playback info now..

[lukemb3]

Let's start with recordings since those are much easier than live Channels. Currently two protocols are supported - file path and url. We can add more as new back-ends introduce new requirements, so if this doesn't work then let me know and I'll add support for whatever is needed.

In RecordingInfo:

Specify Path, or Url, or neither. If neither is specified then GetRecordingStream will be called, at which point you have to return an object with a Path or Url. Path is always preferred but only use that if the server machine has direct access to the recording location.

- If you specify Path or Url in GetRecordingInfo, then you can leave GetRecordingStream unimplemented because it will never be used
- If you use GetRecordingStream, you should also assign an Id to the return object. Once playback is complete CloseLiveStream will be called and that Id will be passed in, in case you need to do any house-keeping to shutdown any processes.

[lukemb3]

While we're at this, images work the same way. You either specify ImagePath, ImageUrl, or neither and then GetRecordingImage will be called (or GetChannelImage, GetProgramImage). So that's why those methods are unimplemented if you're using ImageUrl.

I did fix the issue of ProgramImageProvider getting called repeatedly. What you need to do is, if ImagePath and ImageUrl are both left blank, set HasImage to false and that will tell the core there is no image available and then GetRecordingImage will never be called.

[lukemb3]

One last thing - if you want to submit a pull request or even just post the changes, I'll be happy to integrate them, that way I can update the plugin solution with both your changes and the latest nuget packages.

[mvallevand]

While we're at this, images work the same way. You either specify ImagePath, ImageUrl, or neither and then GetRecordingImage will be called (or GetChannelImage, GetProgramImage). So that's why those methods are unimplemented if you're using ImageUrl.

I did fix the issue of ProgramImageProvider getting called repeatedly. What you need to do is, if ImagePath and ImageUrl are both left blank, set HasImage to false and that will tell the core there is no image available and then GetRecordingImage will never be called.

Let's start here because it's a nightmare, today's update was 17 minutes to the point I don't want to do anything more. NEWA time was < 1 minute and during that time MB3 is not calling NEWA, so it's internal processing.

I do I force a full refresh to test that it works?

Martin