Media Browser Integration

[mvallevand]

One last thing - if you want to submit a pull request or even just post the changes, I'll be happy to integrate them, that way I can update the plugin solution with both your changes and the latest nuget packages.

Where is the source for wmc? I want to look at it first.

Martin

[UncleJohnsBand]

What you need to do is, if ImagePath and ImageUrl are both left blank, set HasImage to false and that will tell the core there is no image available and then GetRecordingImage will never be called.

I'll check.... I wasn't aware this was occurring.

[mvallevand]

Let's start with recordings since those are much easier than live Channels. Currently two protocols are supported - file path and url. We can add more as new back-ends introduce new requirements, so if this doesn't work then let me know and I'll add support for whatever is needed.

In RecordingInfo:

Specify Path, or Url, or neither. If neither is specified then GetRecordingStream will be called, at which point you have to return an object with a Path or Url. Path is always preferred but only use that if the server machine has direct access to the recording location.

- If you specify Path or Url in GetRecordingInfo, then you can leave GetRecordingStream unimplemented because it will never be used
- If you use GetRecordingStream, you should also assign an Id to the return object. Once playback is complete CloseLiveStream will be called and that Id will be passed in, in case you need to do any house-keeping to shutdown any processes.

Path/Url was already implemented, but I modified it to use sub's /live?recording= url and not UJB's It is hard on the CPU ffmpeg is taking 20% of an i7 to transcode stream HD. In the browser seeking is pretty good considering the transcoding not you wouldn't want to use this for normal playback skipping commericials etc. Hopefully there is a native client that won't use transcoding.

There doesn't seem to be a way to resume or store the current location though. ie link the MB3 and NextPVR resume locations.

Martin

[lukemb3]

Ok, I've put up a new build that temporarily disables program image downloading while I take some time to review it. It will still download the list, but not the images.

Yea the transcoding is normal because the browsers are unable to play it natively. We'll see different results with different MB3 clients.

[mvallevand]

@lukemp3 - I was poking around and I found the issue with the epg, the dates were hard coded to gather +/- one year The fast update for 2 days was 19 seconds so the slow update will probably going down to 2 or 3 minutes.

Martin

[lukemb3]

You found an issue in your code or ours? Do you still need to see swmc source?

[mvallevand]

Neither, it's in the plugin code https://github.com/MediaBrowser/MediaBro...#L556-L557 not t using the passed parameters I'd still like to initiate a full scan to see the improvement and then add art back before sending you a diff

No on to LiveTV and then I will create and explain the wishes.

Martin

[UncleJohnsBand]

While we're at this, images work the same way. You either specify ImagePath, ImageUrl, or neither and then GetRecordingImage will be called (or GetChannelImage, GetProgramImage). So that's why those methods are unimplemented if you're using ImageUrl.

I did fix the issue of ProgramImageProvider getting called repeatedly. What you need to do is, if ImagePath and ImageUrl are both left blank, set HasImage to false and that will tell the core there is no image available and then GetRecordingImage will never be called.

I'll check.... I wasn't aware this was occurring.

Ok... looked into this and the ImagePath and ImageUrl are not coming from the NEWA JSON API.... so not sure where that is coming from.

In the JSON API I have a FanArt attribute on the epgEvent and schd segments.... it is empty if none available and is populated if it is. Sorry I can't help since I don't know where it is coming from.

[Edit] - I think the light bulb finally came on... this is not an issue with the NEWA API... I think you were providing Martin with help on how the MB3 API works.... this just confused me....sorry.

[mvallevand]

Ok... looked into this and the ImagePath and ImageUrl are not coming from the NEWA JSON API.... so not sure where that is coming from.

Yeah, those are MB3 values that come from FanArt

info.ImageUrl = string.IsNullOrEmpty(schd.FanArt) ? null : (_baseUrl + "/" + schd.FanArt);


Martin

[mvallevand]

@lukemb3 I got LiveTV playing and stopping ok, but I found a few things

- ffmpeg doesn't like the normal http stream that NextPVR produce, saying it doesn't accept Uri so I have to create another temp file
- I'm probably not returning something right but GetChannelStream() gets called twice
- to cache the file I needed to introduce a 20 second delay, or ffmpeg would just stop.
- I can't make the small video window 16x9

Martin