Files Plugin crashes when there is an ' in the file name.

[mvallevand]

I didn't see your edit until just now when I logged on to upload this draft skin, I will have a play around with my mouse (& look at that section of the skin) next time I get a chance to have a play...

I've run out of time right now but attached is my initial though on this lot of skin mods.... unfortunately to use them would need some code change your end... I have only edited the not selected element at this stage, if you could have a quick look that would be great

Thanks, the selected.png makes a lot of sense. I wonder if it should be green like NextPVR? I am mulling over the "Not in database" message since it looks busy on folders, and isn't totally true. I just noticed that tmrt has @title (Title:Subtitle) and @indb so I think displaying the name we are used to seeing in Recording in NextPVR (@title) might be good enough?

Martin

[mvallevand]

Ok, moved 8 and updated all accordingly but it immediately dies on one particular directory. It looks like it dieing one one that already exists, however when I select just the one directory, it comes back and tells me that it exists as I would expect, now I selected the last 6 again and off it goes just like it's supposed to. Intermittent random gremlins,

You are right it probably is something about testing for the files already exisiting in the dest folder. I now I just added special handling for tvshow.nfo and I know I didn't figure out whether to overright it or trash it.

Thanks for testing

Martin

[Jaggy]

Thanks, the selected.png makes a lot of sense. I wonder if it should be green like NextPVR?

I thought it may be rather confusing just showing the "watched flag" which was why I changed it's colour & add the "X's" to it.

I am mulling over the "Not in database" message since it looks busy on folders, and isn't totally true.

Which was what my comment about needing a code change your end was aimed at.... for it to work reasonably it would require an @item flag as well.

I just noticed that tmrt has @title (Title:Subtitle) and @indb so I think displaying the name we are used to seeing in Recording in NextPVR (@title) might be good enough? Martin

I'm not sure what you mean by this one???....sorry

[mvallevand]

I thought it may be rather confusing just showing the "watched flag" which was why I changed it's colour & add the "X's" to it.

Fair point

Which was what my comment about needing a code change your end was aimed at.... for it to work reasonably it would require an @item flag as well.

Sorry what do you want a count of files ? or if filtered items?

I'm not sure what you mean by this one???....sorry

I just down the backend but have a look with this change

<Text visible="@indb" text="@title" location="3.5,55" size="46,40" font="DefaultSmall" />
<!--Text visible="@notindb" text="Not Located in Database" location="3.5,55" size="46,40" font="DefaultSmall" /-->

Martin

[Jaggy]

Sorry what do you want a count of files ? or if filtered items?

I think we are talking at cross purposes on this one..... I was trying to suggest for the visible="@notindb" text="Not Located in Database" to work properly it would really need to be visible="@isItem+@notindb" text="Not Located in Database" so that text only showed on the items & didn't show up on the folders

<Text visible="@indb" text="@title" location="3.5,55" size="46,40" font="DefaultSmall" />

I'm not sure that makes it all that obvious that it's in the database (especially for someone starting out)

[mvallevand]

I think we are talking at cross purposes on this one..... I was trying to suggest for the visible="@notindb" text="Not Located in Database" to work properly it would really need to be visible="@isItem+@notindb" text="Not Located in Database" so that text only showed on the items & didn't show up on the folders

Ok, I have to think about this, I understand for folders but when filtering is off there are a lot of filename.ext that

I'm not sure that makes it all that obvious that it's in the database (especially for someone starting out)

True, although this isn't a new user plugin, it is for someone with a bigger collections of recording that they want to move between drives and they want to maintain db integrity. I have been thinking that it is pretty hard to tell which of Old_Recording_20120807_09001000.ts and Old_Recording_20120709_09001000.ts that I want to archive and I don't want to play them to figure it out.

After our selected.png discussion it made me realize that I do want a watched indicator as I want to manage watched files and these files don't have to be in the db to be watched. I am also adding a Delete as it kills two birds with one stone (if that is politically correct in your business!) and for this the more metadata including the colours may be better.

Martin

[Jaggy]

Just as a thought - reversing thing how about this to show their in the database?? (not perfect especially for long name ones but???)

Code:

    <Element name="ListItemNormal" location="27.77,15.55" size="69.26,9.52" alpha="255" alphaFade="true">
        <RoundedRect location="0.15,0.15" size="99.7,98.45" fillColor="Normal_Recording" borderColor="Accent1" radius="0.77" borderWidth="0.15"/>

        <Text visible="!@indb" text="@shortname" location="3.5,10" size="94.5,40" font="Title1" align="Left" valign="Center"/>
        <Text visible="@indb" text="@title" location="3.5,10" size="94.5,40" font="Title1" align="Left" valign="Center"/>
        <Text visible="@indb" text="@shortname" location="3.5,55" size="63,40" font="DefaultSmall" />

        <Text text="@modtime" location="68,55" size="31,40" font="DefaultSmall" align="Right" valign="Center"/>

        <Image source="selected.png" visible="@selected" location="1,5" size="2.1,90"/>
        <Text visible="@selected" text="X" location="1,10" size="2,40" font="DefaultReverseSmall"/>
        <Text visible="@selected" text="X" location="1,55" size="2,40" font="DefaultReverseSmall"/>
    </Element>

[mvallevand]

Jaggy that does highlight the difference but I want to leave as much as possible to show the full filename, especially when I have -0.ts -0-0.ts files that will have the same title. One the second line there is also the need to show failure reason somewhere.

Martin

[Jaggy]

I never said I was actually happy with it but it was the best I could come up with using what was there..... BTW I now remember showing the -0.ts etc was why I also displayed the name in the meta data as it will display longer names than in the list...

I think it's probably best at this stage if you just carry on with your modes & when you have them all done I will have a look at the skin with everything in it & see what I can do.

[cbgifford]

You are right it probably is something about testing for the files already exisiting in the dest folder. I now I just added special handling for tvshow.nfo and I know I didn't figure out whether to overright it or trash it.

Thanks for testing

Martin

You are more than welcome, this is a boon for me and I'm happy to test it. I will be using it quite extensively. I record a lot of stuff I'll probably never have the time to watch but it's nice to have the choice to choose from a huge video library. Thank YOU!