Fresh Kodi installation crashes when NextPVR plugin tries access the NPVR server

[mvallevand]

If running 3.3.14 is a problem I have hacked one of sub's most recent 4.2.4 NShared.dlls https://forums.nextpvr.com/showthread.ph...post531661 to return a different value to work around the empty <ServerMac> problem.

This patch should have just two byte difference ServerMAC is no serverMAC. With this hack Kodi PVR won't read an empty value.

Running the proper version of 3.3.14 from here https://jenkins.kodi.tv/blue/organizatio.../artifacts is better but the attached should temporarily work around the problem.

Edit update to PR92 https://jenkins.kodi.tv/blue/organizatio.../artifacts

Martin

[grouper]

I´ll try 3.14 tonight (which one to use on Linux libreelec generic btw?) and then the nshare patch. However, the crash also occurs if the npvr server is switched off, so I think it´s not a backbone issue

[mvallevand]

I´ll try 3.14 tonight (which one to use on Linux libreelec generic btw?) and then the nshare patch. However, the crash also occurs if the npvr server is switched off, so I think it´s not a backbone issue

LE isn't a Kodi build so none of those builds will work which is why I came up with the NShared patch. As I said LE is having a separate issue when it can't connect but I can't see how that is related.

Martin

[grouper]

Thanks, vpeter from LE seem to have found the issue, the false in constructor cPVRClientNextPVR CreateThread should be removed:


--- a/src/pvrclient-nextpvr.cpp 2019-03-08 23:02:24.000000000 +0100
+++ b/src/pvrclient-nextpvr.cpp 2019-03-28 12:16:43.445033631 +0100
@@ -159,7 +159,7 @@ cPVRClientNextPVR::cPVRClientNextPVR()
m_realTimeBuffer = new timeshift:ummyBuffer();
m_livePlayer = nullptr;
- CreateThread(false);
+ CreateThread();

I´ll give the updated version on the LE forum a try tonight.
Thanks for your efforts

[mvallevand]

There are two issues in play when NextPVR returns <ServerMAC></ServerMAC> empty (which I assume is VPN issue whenremote machines are involved but there might be others, no on is giving feedback) then the addon will crash. This is fixed in 3.3.14

When the addon can't connect to and IP then the control is passed back to Kodi, I do see NextPVR creating the thread in the constructor, and stopping it in the destructor, but that is not changed in 3.3.13 it goes back to
here https://github.com/kodi-pvr/pvr.nextpvr/...abc4edbe4c

I am also compiling the LE x86_64 pvr.nextpvr right now so I can give you 3.3.14 later if things cooperate.

Martin

[grouper]

There are two issues in play when NextPVR returns <ServerMAC></ServerMAC> empty (which I assume is VPN issue whenremote machines are involved but there might be others, no on is giving feedback) then the addon will crash. This is fixed in 3.3.14

...

Martin

Regarding VPN, the crash also occurs when there is no backend active in the network, so VPN has no impact on this behavior.

[mvallevand]

Regarding VPN, the crash also occurs when there is no backend active in the network, so VPN has no impact on this behavior.

As I posted there are two separate issues involved.

Martin

[grouper]

sure, you just said that no one is giving you feedback on the VPN and so I did.
Here a hint from vpeter in the LE forum:

Quote
I suspect it is timing issue. Thread is creating but not wait for creation because of false parameter. Because connect is unssuccesful object is deleted but something is going wrong in the thread probbably.

This also helps to prevent crash:

g_client = new cPVRClientNextPVR();

sleep(2);

[mvallevand]

I don't think I need to add the sleep() delay I checked and none of the other addons are doing this. The round trip to server will be a bit of a delay we will see how removing the false works out. LE is still building here.

I can understand your confusion about VPN, I relate it to why NextPVR cannot get the MAC address using standard Windows methods and not to the issue about connecting on the local LAN but they indeed both could be VPN.

Martin

[mvallevand]

@Me_ did the 32bit Windows version fix the problem?

Martin