Memory Leak in Subs WeatherPlugin

[TypQxQ]

In the WeatherPlugin source, by sub, haven't checked codemonkey's, there's a memory leak that in my ShutDown Plugin became a HUGE memory leak.

The problem is that in the render method we have:
foregroundImage = new Bitmap(720, 480);

Aperantley you must dispose of Image objects (in the right order too) or they will just add to the memmory...

As the menu is loopable (when presing down on last entry, it goes to first) in my plugin, when holding down the down key, it grew as ####....

I resolved this by adding:
   foregroundImage.Dispose();
   g.Dispose();

This should be done just before returning the compositeScreenImage.

[CodeMonkey]

Thanks, I will look at that tonight. Though when users leave the plugin I believe that would get taken care of by the garbage collector (eventually). But things that large are probably best disposed of ASAP.

[TypQxQ]

On my computer it grew with about 300Mb. And it won't be collected by the garbage collector untill you exit GB-PVR.

[sub]

No, what you've pointed out isn't a memory leak:

// allocate screen bitmap if we dont alerady have one
if (compositeScreenImage == null)
{
  compositeScreenImage = new Bitmap(720, 480);
  foregroundImage = new Bitmap(720, 480);
}

The foreground image is only allocated once, and reused on all subsequent renders().

The leak is probably the weather satellite image.