WizUIhelper 1.0.15.4 issue

[idkpmiller]

Hi JW,
I have finally got around to finishing GameZone2 and I hit upon an issue when I changed from UIhelper 1.0.15.2 to the latest on the wiki 1.0.15.4.
prior to the chnage everything is working fine.

First of all it seems gbpvr looks in the plugins directory and then looks in common for the UIhelper dll.
I can put UIhelper 1.0.15.2 in the gamezone plugin directory and all is well again but that is not really a long term solution.

The fault seems to be around the buttonlist, when I first enter the plugin if I select a button it operates correctly but the second or subsequent button selection either throw me out of gamezone or do not appear to do anything.
It doesnt matter which button(s) I press its always the same pattern; fine, then throw out.

Here is the pvrx2.exe log showing the button called "back" being pressed:

Code:

2008-03-29 12:31:59.328 VERBOSE [1] GameZone: Entering Control_OnKeyDown, command rx = Back 2008-03-29 12:31:59.328 VERBOSE [1] GameZone: Command Received as per keymappings = GameZone_Enter 2008-03-29 12:31:59.328 VERBOSE [1] GameZone: Initfilelist routine entered 2008-03-29 12:31:59.328 VERBOSE [1] GameZone: Entering UpdateFilelabels 2008-03-29 12:31:59.328 VERBOSE [1] getValue cached value: /settings/ActiveSkin : blue 2008-03-29 12:31:59.328 VERBOSE [1] GameZone: Displaying file C:\Program Files\Devnz\GBPVR\skin2\blue\gamezone\GameZone.jpg 2008-03-29 12:31:59.328 VERBOSE [1] getValue cached value: /settings/ActiveSkin : blue 2008-03-29 12:31:59.328 VERBOSE [1] GameZone: Initfilelist routine exited 2008-03-29 12:31:59.328 VERBOSE [1] WizUiButton: constructor- loading /settings/Placements/Placement[@name="ButtonList"] 2008-03-29 12:31:59.437 VERBOSE [1] ReturnToMainMenu() 2008-03-29 12:31:59.437 VERBOSE [1] GameZone is currently active 2008-03-29 12:31:59.437 VERBOSE [1] GameZone.Deactivate() called 2008-03-29 12:31:59.437 VERBOSE [1] GameZone: Deactivated 2008-03-29 12:31:59.437 VERBOSE [1] GameZone: Exited Deactivated 2008-03-29 12:31:59.437 VERBOSE [1] GameZone: Entering GetRenderList routine 2008-03-29 12:31:59.437 VERBOSE [1] currentIndex = 0 detailsViewVisibleIndex = 0 2008-03-29 12:31:59.437 VERBOSE [1] LIST: Using cached image-ListBox1(0) 2008-03-29 12:31:59.437 VERBOSE [1] LIST: Using cached image-ListBox1(0) 2008-03-29 12:31:59.437 VERBOSE [1] LIST: Using cached image-ListBox1(0) 2008-03-29 12:31:59.437 VERBOSE [1] LIST: Using cached image-ListBox1(0) 2008-03-29 12:31:59.437 VERBOSE [1] LIST: Using cached image-ListBox1(0) 2008-03-29 12:31:59.437 VERBOSE [1] Will get render list this time 2008-03-29 12:31:59.437 VERBOSE [1] GameZone: Exiting GetRenderList routine 2008-03-29 12:31:59.453 VERBOSE [1] ReturnToMainMenu()@2 2008-03-29 12:31:59.453 VERBOSE [1] System.ArgumentException: Parameter is not valid. at System.Drawing.Image.get_RawFormat() at System.Drawing.Graphics.IgnoreMetafileErrors(Image image, Int32& errorStatus) at System.Drawing.Graphics.DrawImage(Image image, Single x, Single y, Single width, Single height) at GBPVRX2.SkinHelper2.getNamedImage(Image image, String name, Hashtable parameters, XmlNode fromNode) at GBPVRX2.SkinHelper2.getNamedImage(String name, Hashtable parameters) at GBPVRX2.UiSupport.UiButton..ctor(SkinHelper2 skinHelper2, String name, RectangleF position, String normalButtonImageName, String selectedButtonImageName, Hashtable args) at GBPVRX2.UiSupport.UiButton..ctor(SkinHelper2 skinHelper2, String name, RectangleF position, String normalButtonImageName, String selectedButtonImageName) at WizUtilities.WizUiHelper.WizUiButton..ctor(SkinHelper2 skinHelper, String placementName, String caption, String normalImageName, String selectedImageName, Int32 index) at WizUtilities.WizUiHelper.WizUiButtonList..ctor(SkinHelper2 skinHelper, String placementName, String[] captions, String normalImageName, String selectedImageName, CommandCallback callback) at WizUtilities.WizUiHelper.WizUiButtonList..ctor(SkinHelper2 skinHelper, String placementName, String[] captions) at GameZone.GameZone.GameZoneTask.SetWizButtons() at GameZone.GameZone.GameZoneTask.Controls_OnKeyDown(KeyEventArgs e) at GameZone.GameZone.GameZoneTask.OnKeyDown(KeyEventArgs e) at GBPVRX2.MenuTask.x9006c1ed9ccb79de.OnKeyDown(KeyEventArgs e) at GBPVRX2.x0061b801bdf12d35.xdae9991ab918b397(Object xdf2e3583f942db7b, KeyEventArgs xc4f45905cb1fc7ba) at System.Windows.Forms.Control.OnKeyDown(KeyEventArgs e) at System.Windows.Forms.Control.ProcessKeyEventArgs(Message& m) at System.Windows.Forms.Control.ProcessKeyMessage(Message& m) at System.Windows.Forms.Control.WmKeyChar(Message& m) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ScrollableControl.WndProc(Message& m) at System.Windows.Forms.ContainerControl.WndProc(Message& m) at System.Windows.Forms.Form.WndProc(Message& m) at GBPVRX2.x0061b801bdf12d35.WndProc(Message& m) 2008-03-29 12

Here is the routine referenced in the error.

Code:

Public Sub SetWizButtons() Dim captions As String() = DirectCast(menuButtons.ToArray(GetType(String)), String()) cmdButtonList = New WizUiButtonList(skinHelper, "ButtonList", captions) ctlMgr.UpdateControl(cmdButtonList) ctlMgr.setFocus(cmdButtonList) End Sub

[JavaWiz]

I don't recall making any changes in that area.

First, I suspect your code snippet has a typing error. The line

Dim captions As String() = DirectCast(menuButtons.ToArray(GetType(String)),

should be

Dim captions As String[] = DirectCast(menuButtons.ToArray(GetType(String)),

Not sure what DirectCast method does, but hopefully it just returns a string array.


Try the attached DLL which has additional logging around the WizControlManager.UpdateControl() method and the constructor of the button list.

Additionally, there are now .ToString() methods on each control as well as on the WizControlManager.

To dump a summary:

WizInfo.LogMessage("MyPlugin", "MyMethod()", ctlMgr.ToString());

To dump a detailed listing:

WizInfo.LogMessage("MyPlugin", "MyMethod()", ctlMgr.ToString(true));

Quite a bit of detail outputs on the detail call, so use it sparingly, and only for debugging.

[idkpmiller]

hi JW,

using the supplied version of UIhelper the log for the failing button press is shown below, then as a comparison a successful button press is shown beneath that.

Failing Button press

Code:

2008-03-31 22:45:35.609 VERBOSE [1] GameZone: Entering Control_OnKeyDown, command rx = Back 2008-03-31 22:45:35.609 VERBOSE [1] GameZone: Command Received as per keymappings = GameZone_Enter 2008-03-31 22:45:35.609 VERBOSE [1] GameZone: Initfilelist routine entered 2008-03-31 22:45:35.609 VERBOSE [1] GameZone: Entering UpdateFilelabels 2008-03-31 22:45:35.609 VERBOSE [1] getValue cached value: /settings/ActiveSkin : blue 2008-03-31 22:45:35.609 VERBOSE [1] GameZone: Displaying file C:\Program Files\Devnz\GBPVR\skin2\blue\gamezone\GameZone.jpg 2008-03-31 22:45:35.609 VERBOSE [1] getValue cached value: /settings/ActiveSkin : blue 2008-03-31 22:45:35.609 VERBOSE [1] GameZone: Initfilelist routine exited 2008-03-31 22:45:35.625 VERBOSE [1] WizUiButtonList: ctor- PlacementName: ButtonList 2008-03-31 22:45:35.625 VERBOSE [1] WizUiButtonList: ctor- Captions: (DreamCast) (Kega) (Amiga) (Mame) (ePSXe) (N64) (PC Games) (VGBA) (ZSnes) (WinVice) (Favourites) (Main Menu) 2008-03-31 22:45:35.625 VERBOSE [1] WizUiButtonList: ctor- CallBack: isNull 2008-03-31 22:45:35.625 VERBOSE [1] WizUiButtonList: ctor- Building button list... 2008-03-31 22:45:35.625 VERBOSE [1] WizUiButton: constructor- loading /settings/Placements/Placement[@name="ButtonList"] 2008-03-31 22:45:35.719 VERBOSE [1] ReturnToMainMenu()

Good Button Press

Code:

2008-03-31 22:45:33.516 VERBOSE [1] GameZone: Entering Control_OnKeyDown, command rx = Mame 2008-03-31 22:45:33.516 VERBOSE [1] GameZone: Command Received as per keymappings = GameZone_Enter 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- PlacementName: ButtonList 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- Captions: (Game Info) (Back) 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- CallBack: isNull 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- Building button list... 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButton: constructor- loading /settings/Placements/Placement[@name="ButtonList"] 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButton: constructor- loading /settings/Placements/Placement[@name="ButtonList"] 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- AssertSkinElements... 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- Set index to zero... 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- Deactivate... 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: ctor- Exit... 2008-03-31 22:45:33.516 VERBOSE [1] WizControlManager: UpdateControl()- BEGIN 2008-03-31 22:45:33.516 VERBOSE [1] WizControlManager: UpdateControl()- Located control-ButtonList 2008-03-31 22:45:33.516 VERBOSE [1] WizControlManager: UpdateControl()- Dispose control element 2008-03-31 22:45:33.516 VERBOSE [1] WizUiButtonList: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizUiButton: Dispose()- ButtonList 2008-03-31 22:45:33.531 VERBOSE [1] WizControlManager: UpdateControl()- Remove from pluginControlList - 3 2008-03-31 22:45:33.531 VERBOSE [1] WizControlManager: UpdateControl()- Replacing new version in pluginControlList - 3 2008-03-31 22:45:33.531 VERBOSE [1] WizControlManager: UpdateControl()- Replaced: ButtonList 2008-03-31 22:45:33.531 INFO [1] T23 2008-03-31 22:45:33.531 VERBOSE [1] GameZone: Entering UpdateFilelabels

Each time the same routine is called which is the Setwizbutton, as I said it works fine upto the 1.15.2 version of WizUIhelper.
Does this help narrow down what might be wrong?

Thanks

Paul

[JavaWiz]

I'll have a look at it tonight, hopefully there is enough detail here to identify the issue...

[JavaWiz]

Ok, I think I found a bug in the Dispose method on the WizUiButton. Try the attached DLL to see if it resolves your problem.

[idkpmiller]

That worked great!

Thanks.

Ok, judging by the size it still has additional debug code, will you be updating your wiki version with the new version?

Oh after admiring your installer () is there any chance you would share your NSIS script assuming its NSIS of course. theres a few things I would like copy

[JavaWiz]

That worked great!

Thanks.

Ok, judging by the size it still has additional debug code, will you be updating your wiki version with the new version?

Oh after admiring your installer () is there any chance you would share your NSIS script assuming its NSIS of course. theres a few things I would like copy

I'll clean up the DLL and post to the wiki.

I use the INNO Setup (www.innosetup.com), with the ISTool addon (www.istool.org). If you'd like one of my scripts, no problem, I can send you a copy.

[JavaWiz]

I'll clean up the DLL and post to the wiki.

I use the INNO Setup (www.innosetup.com), with the ISTool addon (www.istool.org). If you'd like one of my scripts, no problem, I can send you a copy.

New version posted on the wiki.

[idkpmiller]

Thanks for the new version on the wiki.
If you could send me a copy of the script that would be great.
my email is on my profile.

Thanks

[JavaWiz]

Thanks for the new version on the wiki.
If you could send me a copy of the script that would be great.
my email is on my profile.

Thanks

Sent.