[DEV] Resources: OSD

[McBainUK]

Following on from this thread I thought I would break off the OSD discussion...

I wasn't exactly sure how to format this, here's how I presently have it. 2 sub folders - Internal Graphics and External Graphics. Internal Graphics folder has 2 files - Blue.xml and Black.xml and uses GB to generate the OSD graphics. External Graphics folder has 2 folders - Blue and Black, each contain the skin.xml and the 6 separate png's that make up the OSD (the plugin could then load the graphics based on the colour chosen)

Remembering the CS principle of separating layout from appearance (not to mention the flexabilty offered by using images instead of GB-PVR draw tags), I think that External Graphics is the only way to go.

---------------------------------------------------------------- ----------------------------------------------------------------

Looking at the resources supplied by Hairy and playing with the OSD I'd like to propose that we split the layout (XML) and appearance (images) by having two SkinPlugin entries related to OSD:

Resources\Layout\OSD\
A range of skin.xml file which defines the layout of the OSD and references the external OSD images listed below (currently only one layout option but this may change in the future, eg bigger osd text, minimal OSD etc...).

Resources\Graphics\OSD\
Set's of images and icons which make up the graphical part of the OSD.

Code:

[B]Community Skin OSD items[/B]
ChannelNumber.png
Controls.png
ShowInfo.png
StatusInfo.png
Timeline.png
Vol.png

[B]The rest of the OSD items (hardcoded in GB-PVR)[/B]
pbaspectbtn.png
pbclosebtn.png
pbdownchbtn.png
pbdvdangle.png
pbdvdexit.png
pbdvdlang.png
pbdvdmenu.png
pbdvdsub.png
pbexitbtn.png
pbffbtn.png
pbmenubtn.png
pbnextchbtn.png
pbpausebtn.png
pbplaybtn.png
pbprevchbtn.png
pbrecbtn.png
pbrwbtn.png
pbsbbtn.png
pbsfbtn.png
pbsubbtn.png
pbsubtv.png
pbttxtbtn.png
pbupchbtn.png

If you guys agree...
The work required is to add the control icons (pbaspectbtn.png - pbupchbtn.png) to the current "OSD\External Graphics\" sets, refactor the resources to show OSD in Graphics and Layout correctly and then update the SkinPluginConfig.xml and preview skin files to match. (not much work)

[Fatman_do]

Yeah, I can agree to that.

[Hairy]

Yeah again I think this is the better way to go, easier to expand. My only suggestions would be below and perhaps splitting off the control icon sets as a separate graphical choice. For any future plugins that may require transport control graphics ???

I think that External Graphics is the only way to go.

The graphical is also my preferred option, but I intentionally included the internally generated OSD's to give MVP and NMT users the option of using this format just in case the extra graphics needing to be redrawn negatively impacted them. We could try both out during the beta and add see if both maybe needed ???

[McBainUK]

Yeah again I think this is the better way to go, easier to expand. My only suggestions would be below and perhaps splitting off the control icon sets as a separate graphical choice. For any future plugins that may require transport control graphics ???

The OSD button images must be in the skin2\CommunitySkin\OSD\ folder but can be duplicated in _CoreImages\.

In the CS3 I think we had play/stop/pause etc as coreimages, could do something like that again.

Would play on the OSD be the same graphic as play in a button or are you thinking really split them off? I would vote to keep them the same myself but just make them available to plugins via a _CoreImages\ copy.

The graphical is also my preferred option, but I intentionally included the internally generated OSD's to give MVP and NMT users the option of using this format just in case the extra graphics needing to be redrawn negatively impacted them.

Nice idea, as the layout and graphics will be separate we could just add the "internal" sets as Layout\OSD\ options maybe called No Graphics with a description saying that they may be a good idea for MVP/NMT use.

Isn't it great when something fits in so nicely

[Hairy]

The naming of the control icons in the OSD folder is a little cryptic, so I was thinking of something along the lines of the skinplugin maybe renaming (Play.png, stop.png etc) and loading them as you said to the _CoreImages folder.

Isn't it great when something fits in so nicely

[Fatman_do]

The OSD button images must be in the skin2\CommunitySkin\OSD\ folder but can be duplicated in _CoreImages\.

In the CS3 I think we had play/stop/pause etc as coreimages, could do something like that again.

Those were only used in gbpvr.exe plugins and I stripped them out since they were mostly used in legacy panels which no longer function. For Xrecord, the stop button on the remote is displayed as a "remote hint" button, so I made it a stand alone graphic in that folder. If you guys want to future proof and add them back in, I'm fine with that. Right now, there isn't a need for them.

[McBainUK]

Hariy, can you email me a Black set of OSD buttons. After sorting out the Resources folder and SkinPluginConfig.xml file I'm ready for them now.

[McBainUK]

Scrap that, I've committed all the changes discussed here and on the Resources thread to the SVN so just upload some Black and Blue OSD graphics to the relevant folders in svn\shared\plugin\Resources\Graphics\OSD\

[Hairy]

If you guys want to future proof and add them back in, I'm fine with that. Right now, there isn't a need for them.

Yeah I think you're dead right here, there's no point adding something that isn't currently used. So if I'm right in thinking that adding these transport control graphics to the _CoreImages folder is just a matter of tweaking the SkinPluginConfig.xml at a later date, then just separating them as a loadable selection should be enough for future flexibility ???

[Hairy]

so just upload some Black and Blue OSD graphics to the relevant folders in svn\shared\plugin\Resources\Graphics\OSD\

If you guys are okay with it, I'll work on some style and colour variations of these control/transport icons and place them in a folder called "ControlIcons" in the "...Resources\Graphics" folder. ???

If that's alright, am I right in thinking that we're feature/element complete for a beta test?