Bug: NEWA doesn't handle an EPG update setting of 'None' in NPVR

[servalan]

Due to problems with duplicate entries in the EPG, I'm no longer running the inbuilt EPG update within NPVR, but am running it from an external script - In NPVR, the EPG Update time is set to 'None'.

Unfortunately now NEWA chokes with:

Code:

Server Error in '/' Application.
Input string was not in a correct format.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.FormatException: Input string was not in a correct format.

Source Error:

Line 301:                XmlNode EPGHour = SettingsHelper.GetInstance().GetSettingsNode("/Settings/General/EPGUpdateHour");
Line 302:                Logger.Info("Checking if it is at least one hour past the EPG update for today.... ");
Line 303:                if (DateTime.Now.Hour + 1 > Convert.ToInt32(EPGHour.InnerText))
Line 304:                {
Line 305:                    Logger.Info("It is greater than one hour since todays EPG update.... ");


Source File: c:\Documents and Settings\All Users\Application Data\NPVR\web\Login.aspx.cs    Line: 303

Stack Trace:

[FormatException: Input string was not in a correct format.]
   System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal) +7471479
   System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo info) +119
   System.Convert.ToInt32(String value) +63
   N_EWA.Login.CompleteLogin() in c:\Documents and Settings\All Users\Application Data\NPVR\web\Login.aspx.cs:303
   N_EWA.Login.Page_Load(Object sender, EventArgs e) in c:\Documents and Settings\All Users\Application Data\NPVR\web\Login.aspx.cs:85
   System.Web.Util.CalliHelper.EventArgFunctionCaller(IntPtr fp, Object o, Object t, EventArgs e) +14
   System.Web.Util.CalliEventHandlerDelegateProxy.Callback(Object sender, EventArgs e) +43
   System.Web.UI.Control.OnLoad(EventArgs e) +73
   System.Web.UI.Control.LoadRecursive() +52
   System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +2184

As a workaround, I've set NPVR to do a dummy update just before the external script kicks in, but NEWA should handle valid settings from NPVR.

External script is nothing special - it just forces the db to empty before the update:
"C:\Program Files\NPVR\NextPVR.exe" -emptyepgonly
"C:\Program Files\NPVR\NextPVR.exe" -updateepgonly

Thanks!

[UncleJohnsBand]

Thanks....patch attached.