Download recording

[VCR58]

There are a couple minor bugs I found with the web client when downloading recordings. 

#1 From the "All Recordings (List)" page, clicking on the download button does nothing.

#2 When when clicking on the download button of a recording that has a comma in the filename the download fails and an error web page is displayed. I reported this a while ago but got no response. https://forums.nextpvr.com/showthread.ph...#pid558397

[sub]

#2 When when clicking on the download button of a recording that has a comma in the filename the download fails and an error web page is displayed. I reported this a while ago but got no response. https://forums.nextpvr.com/showthread.ph...#pid558397

Just curious, were the server and web browser client both on Windows?

[VCR58]

#2 When when clicking on the download button of a recording that has a comma in the filename the download fails and an error web page is displayed. I reported this a while ago but got no response. https://forums.nextpvr.com/showthread.ph...#pid558397

Just curious, were the server and web browser client both on Windows?

The recordings with the commas came from my Linux server. 

Just now I found a show "Magnum, P.I." and started a recording on my Windows server and it also put a comma in the filename "Magnum,.P.I.S03E02.Did.You.See.the.Sunrise.ts"

[sub]

I've scheduled a a show to record tonight that has a comma in the name.

[sub]

What error message does it give you when you try to download it?

[VCR58]

What error message does it give you when you try to download it?

Here is a screenshot of the error message also included logs.

[mvallevand]

I just tried a test file with Firefox and it worked for me. Window client Debian server. So I tried with curl and it also worked.

Is it possible you are trying a file that is mp4?

Code:

curl -v "http://172.16.3.105:8866/download?recording_id=24766
*   Trying 172.16.3.105...
* TCP_NODELAY set
* Connected to 172.16.3.105 (172.16.3.105) port 8866 (#0)
> GET /download?recording_id=24766 HTTP/1.1
> Host: 172.16.3.105:8866
> User-Agent: curl/7.55.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Tue, 14 Sep 2021 12:21:38 GMT
< Content-Type: application/octet-stream
< Server: Kestrel
< Content-Length: 23772036
< Content-Disposition: attachment; filename=Yukon Gold.S04E03.Hard Rain, Bad Luck.ts
<
Warning: Binary output can mess up your terminal. Use "--output -" to tell
Warning: curl to output it to your terminal anyway, or consider "--output
Warning: <FILE>" to save to a file.

Martin

[sub]

I've managed to reproduce it. Will take a look why it's happening.

[sub]

The problem with downloading shows with commas in the name is fixed for the next build.

[sub]

#1 From the "All Recordings (List)" page, clicking on the download button does nothing.

This is also fixed for the next build.