default plugins dont use popup buttons properly

[Ted the Penguin]

ok so I know that baseskin.xml contains definitions for the default buttons reg, selected, popup, popup selected (well the popup ones are repeated like 3 times with slightly different names but whatever). TV Guide, Recordings, and I am not sure what else, havnt looked at search guide. do not use these popup button definitions in all popups, they use the default ones.

this is a problem for me because I am using sassari with black buttons, now these black buttons on a black background dont have much contrast to the white buttons, if at all, so I made the selected button red in the popups, and that made life better.

anyways, the real problem can be seen when you hit enter on a guide program and it brings up the exit, record, quick record... etc dialouge, it is a popup however no red selected button. then the next popup say with cancel and ok, uses the red buttons... the same thing happens in recordings when you select a show.

I am guessing that it is just using the wrong button name, and it should be a simple fix.

now I dont know where else it shows up, those are the only two that I noticed last night.

[MixMan]

You are right, it is the normal buttons that are used in those popups.
In the Advisor skin I added button defintions to control the witdh of those buttons. You could easily change the button image to point to the popup button image. Have a look in the Advisors tvguide skin.xml

Perhaps I should change the skin, so that it points to the popup button instead.
Maybe in next release.

[Ted the Penguin]

just to make sure youre talking about the tvguide that comes by default? or is that tv listings? (damn confusion)
anyways, that does not fix my problem on the recordings screen, since the normal buttons are used on the left as well as in the popups

[Fatman_do]

The TVGuide skin.xml file.

add:

Code:

        <CompositeImage name="SelectedButtonImage" size="214,43">
            <DrawImage filename="..\_res\btn_sel.png" size="214,43" loc="0,0"/>
            <DrawText text="@buttonText" loc="4,2" size="200,30" textStyle="ButtonText" align="Center"/>
        </CompositeImage>
        
        <CompositeImage name="NormalButtonImage" size="214,43">
            <DrawImage filename="..\_res\btn.png" size="214,43" loc="0,0"/>
            <DrawText text="@buttonText" loc="4,2" size="200,30" textStyle="ButtonText" align="Center"/>
        </CompositeImage>

Of course, change whatever specifically you are trying to do by specifying the popup images here.

[Ted the Penguin]

ok first
its FATMAN_DO's 1000th post, congrats

second, thanks for the code, I already figured that out when I skinned the theater plugin to look like sassari, damn fixed resolution.

but as i said before, thats fine for tv guide, but in the recordings screen it does not work. because it actually uses the normal buttons.

for clarification, I have sassari, changed the background to red (hue adjustment!!!) and I am using the black buttons (this problem probably exists for everyone using the black buttons).
as you know the popup is black, and the white buttons on top of that look just like the black buttons.
so I changed the popup button to the red button image so there would be contrast and the theme would be carried through.
the only solution I can think of is instead of having the transparent button as the normal one, I could make it red, so it would match the background, and then the black for selected, I guess that would work... but the code does not follow skinning convention, so I am saying that if its not a big deal it should be fixed, and I am guessing all it is is changing a few declarations.

[Fatman_do]

Right, recordings has no fix, just the TVGuide (via a workaround).

Those are things sub would have to fix.

[Ted the Penguin]

Those are things sub would have to fix.

and thats why I made this thread:p
I assume sub will read it sometime... I think its in the right place, it has to do with skinning/plugins, since nothing crashes because of it.

[sub]

Its not really something that needs to be fixed. It is currently working they way I intend.

I only use the popup buttons for the buttons that are arranged at the bottom of a popup, not for those that are listed at left. if you look at them closely you'll notice they need to look different (left align vs center align).

A year or so ago I did consider adding additional third type of button (second type of popup button), to accommodate this difference, but decided it would be too disruptive to stuff that already exists (skins, plugins etc).

[Ted the Penguin]

a bunch of plugins use their own popup button definition, there are 3 in the sassari baseskin.xml
but Ill mess around with my skin until I get to look how I want,
thanks for the quick reply