Search Patch

[UncleJohnsBand]

This is a patch to address a bug that difdiffer reported in the build 75 thread.

Check it out and let me know your results.

Edit....removed this patch...read further down for 20080624_01 patch.

[difdiffer]

I am not quite sure what your adjusted code exactly does. But it did not fix the problem I described.

Looking at the code I could make a change myself to make it work. Please review the code addition I made, and mybe you can see if you need to incroporate this in a smarter way (probably), or if I made any oversights. (My additions are in BOLD)

Basically the idea is that once program.getEndTime() is passed the 23:59 mark it becomes (on a new date) 00:00. Than the program.getEndTime(). is allways smaller than endTime, but in fact it is larger, because the date is left out of the equation. I am not programmer enough to walk through your code (not do I have the time) but comparing time and date together as one string should solve the problem.

+++++CODE++++++++++++


//Check to see if the programmme needs to fall between the two times
if (startTime.ToString("HH:mm") != "01:01" && endTime.ToString("HH:mm") != "01:01")
{
int Cmpr1 = String.Compare(startTime.ToString("HH:mm"),program.getStartTime().ToString("HH:mm"));
int Cmpr2 = String.Compare(endTime.ToString("HH:mm"),program.getEndTime().ToString("HH:mm"));
if (Cmpr1 > 0 || Cmpr2 < 0)
{
showProgram = false;
}
int Cmpr3 = String.Compare(program.getEndTime().ToString("HH:mm"),program.getStartTime().ToString("HH:mm"));
if (Cmpr3 < 0)
{
showProgram = false;
}

[difdiffer]

I have put some time in it, and this looks better. Please give me your comments:


if (showProgram)
{
//Check to see if the passed in times need to be looked at
if (startTime.ToString("HH:mm") != "01:01" || endTime.ToString("HH:mm") != "01:01")
{
//Check to see if the programmme needs to fall between the two times
if (startTime.ToString("HH:mm") != "01:01" && endTime.ToString("HH:mm") != "01:01")
{
int Cmpr1 = String.Compare(startTime.ToString("HH:mm"),program.getStartTime().ToString("HH:mm"));
int Cmpr2 = String.Compare(endTime.ToString("HH:mm"),program.getEndTime().ToString("HH:mm"));

//Check to see if the start time is smaller than the end time (Requested recording period falls within 1 day )
if (String.Compare(startTime.ToString("HH:mm"),endTime.ToString("HH:mm")) < 0)
{
//Check to see if the programmme end time is greater than the start time (program starts and ends within the same day)
if (String.Compare(program.getEndTime().ToString("HH:mm"),program.getStartTime().ToString("HH:mm")) > 0)
{
if (Cmpr1 > 0 || Cmpr2 < 0)
{
showProgram = false;
}
}
//Else the programmme end time is smaller than the start time (Prgramme passes the 24:00 mark, passing over to the next day)
else
{
showProgram = false;
}
}
//Requested recording period passes the 24:00 mark, covering more than 1 day)
else
{
//Check to see if the programmme end time is greater than the start time (program starts and ends within the same day)
if (String.Compare(program.getEndTime().ToString("HH:mm"),program.getStartTime().ToString("HH:mm")) > 0)
{
//When the programme falls within 1 day the end time of the search should be smaller. If not, the programme falls completely within the following day, making part of the valid search result.
if (Cmpr2 < 0)
{
if (Cmpr1 > 0 )
{
showProgram = false;
}
}
}
//Else the programmme end time is smaller than the start time (Prgramme passes the 24:00 mark, passing over to the next day)
else
{
if (Cmpr1 > 0 || Cmpr2 < 0)
{
showProgram = false;
}
}
}
}
else

[UncleJohnsBand]

Seems to be working...attached updated patch for people to try it out.

There is identical coding in the auto-search area of ewa which I will need to patch as well....or refactor that code to use this core search engine code....

Anyone willing to test this please do....the more people testing the more comfortable I'll be.....search has always been the most tedious thing to tweak.

Post any results here.

[UncleJohnsBand]

Has anyone other than myself and difdiffer tested this search patch?

[difdiffer]

Hi Uncle,

I have tried to update to release 77, but the search updates I made do not function correctly in that version.

E.G. if I search for a name and put start time range to 5PM till 11PM i find nothing, and the data is there 4 sure. Also when I update with your patch here (and a later version) it does not work.

However, if I use my own code, it works fine. Any clues?

Cheers

[UncleJohnsBand]

Hi Uncle,

I have tried to update to release 77, but the search updates I made do not function correctly in that version.

E.G. if I search for a name and put start time range to 5PM till 11PM i find nothing, and the data is there 4 sure. Also when I update with your patch here (and a later version) it does not work.

However, if I use my own code, it works fine. Any clues?

Cheers

Have you compared the code that is in the build and what you are using?