Skin Plugin returns to Main Menu

[McBainUK]

2009-09-03 11:52:26.482 VERBOSE [1] System.NullReferenceException: Object reference not set to an instance of an object.
at WizUtilities.WizUiHelper.AWizListItem.getProperty(String propName)
at CommunitySkin4.EditableSkinItemPopup.ActivateItem(Object o)
at WizUtilities.WizUiHelper.WizUiList.OnKeyDown(KeyEventArgs e)
at CommunitySkin4.EditableSkinItemPopup.Controls_OnKeyDown(KeyEventArgs e)
at CommunitySkin4.EditableSkinItemPopup.OnKeyDown(KeyEventArgs e)
at CommunitySkin4.SkinPluginTask.OnKeyDown(KeyEventArgs e)
at GBPVRX2.MenuTask.x9006c1ed9ccb79de.OnKeyDown(KeyEventArgs e)
at GBPVRX2.x0061b801bdf12d35.xdae9991ab918b397(Object xdf2e3583f942db7b, KeyEventArgs xc4f45905cb1fc7ba)
at System.Windows.Forms.Control.OnKeyDown(KeyEventArgs e)
at System.Windows.Forms.Control.ProcessKeyEventArgs(Message& m)
at System.Windows.Forms.Control.ProcessKeyMessage(Message& m)
at System.Windows.Forms.Control.WmKeyChar(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
at System.Windows.Forms.ContainerControl.WndProc(Message& m)
at System.Windows.Forms.Form.WndProc(Message& m)
at GBPVRX2.x0061b801bdf12d35.WndProc(Message& m)

The 2 XML 'errors' are normal. It's this part that causes the crash. I think it maybe trying to use an list item property that is null.

Roy: try the attached SkinPlugin DLL. I've added some code to detect and log this.

(attachment deleted)

[roy]

Just for grins, can you try with the most current version of MovieWiz?

Installed MovieWiz 1.0.27.0. Same problem, SkinPlugin dumps to main.

Roy: try the attached SkinPlugin DLL. I've added some code to detect and log this.

Log attached using new dll. Is this all you need?

[McBainUK]

Hmm, debug code and logs didn't help. Can you try this one and look for "TEST listItem.getProperty(item) failed" in the log file.

[roy]

New log attached. Looks like more data in it, but I don't find the string you're looking for. Is this the only log file you need?

[McBainUK]

Javawiz. Is it possible to try and reproduce this SkinPlugin crash on your PC? Would be great to run it through the WizTools debugger and see where it's crashing. I've reviews the SkinPlugin code in this area and at a loss to see what's going wrong.

Code:

public void ActivateItem(object o)
        {
            if (ctlMgr.CurrentControlName == lstOptionsList.PlacementName)
            {
                WizUiList.WizListItem listItem = (WizUiList.WizListItem)o;

                try
                {
                    object obj = listItem.getProperty("@item");
                }
                catch
                {
                    WizInfo.LogMessage(this.getName(), "EditableSkinItemPopup - ActivateItem", "TEST listItem.getProperty(item) failed");
                    return;
                }
                

                if (listItem.getProperty("@item") is EditableSkinItemOptionFolder)
                {
                    EditableSkinItemOptionFolder optionsFolder = (EditableSkinItemOptionFolder)listItem.getProperty("@item");
                    UpdateOptionsList(optionsFolder);
                }
                if (listItem.getProperty("@item") is EditableSkinItemOption)
                {
                    EditableSkinItemOption option = (EditableSkinItemOption)listItem.getProperty("@item");
                    this.m_EditableSkinItem.SelectedOption = option;
                    this.closeWithCommand("");
                }
            }
        }

[JavaWiz]

I don't get the crash on my machine.

What does your Deactivate() method do?

Do you multi-thread in here at all? I see right before the crash, Deactivate() is called, but then PreviewGenerator.GetRenderList() executes as the items are probably being disposed (in Deactivate()?).

Just guessing here.

[McBainUK]

I don't get the crash on my machine.

Shame.

Do you multi-thread in here at all?

No.

What does your Deactivate() method do?

Nothing:

Code:

/// <summary>
/// Deactivate is called when plugin shuts down
/// </summary>
public void Deactivate()
{
    WizInfo.LogMessage(this.getName(), "Deactivate()", "Called.");
    return;
}

Will have to take another look...

[JavaWiz]

Any idea why ReturnToMainMenu() is called. I think a different thread is causing this to be called which causes PVRX2 to call deactive() method. I think your thread merrily goes along and tries to continue processing even though the plugin is in the process of shutting down.

Code:

2009-09-10 12:19:53.210 ERROR [1] SkinPlugin:         EditableSkinItemOption.LoadMetadata- Could not find file 'C:\Program Files\Devnz\GBPVR\Plugins\SkinPlugin4\Resources\Graphics\Background\CS Blue\CS Blue Dark.xml'.
2009-09-10 12:19:53.220 ERROR [1] SkinPlugin:         EditableSkinItemOption.LoadMetadata- Could not find file 'C:\Program Files\Devnz\GBPVR\Plugins\SkinPlugin4\Resources\Graphics\Background\CS Blue\CS Blue.xml'.
2009-09-10 12:19:53.320 VERBOSE [1] ReturnToMainMenu()

[McBainUK]

Interesting point. Will investigate...

[roy]

Is this still on the radar?