timing.info too short, timeline inaccurate

[sub]

I agree with Martin that this method can lead to the an inconsistent timeline for some users, like time jumping backwards in timing.info.

In the attached patch it'll default to using the old scheme based on GetTickCount(), unless you have HKEY_LOCAL_MACHINE\Software\NPVR\UseClockForTimingInfo=1 (DWORD) then then it'll use the system clock to derive the timestamps.

[johnsonx42]

To actually encounter the problem though you'd have to have a recording going at the moment windows updates the time, AND try to seek while playing back in that exact spot. Possible, but very rare. But as you say, best to avoid even the possibility so making it user selectable is best.

I've now watched several shows recorded last night with the clock-based timing.info, and all have had nearly perfect comskip jumps. Some jumps are a hair early, but fairly consistent so a <ComskipStartOffest> of 500ms should make them perfect.

Thanks for creating this patch which seems to be ultimately just for me.

[sub]

I've now watched several shows recorded last night with the clock-based timing.info, and all have had nearly perfect comskip jumps. Some jumps are a hair early, but fairly consistent so a <ComskipStartOffest> of 500ms should make them perfect.

Great.

[johnsonx42]

by the way, just want to confirm the registry setting is indeed:

Code:

HKEY_LOCAL_MACHINE\Software\NPVR\UseClockForTiming Info=1

with the space? Or was that one of those phantom spaces the forum software sometimes sticks in there?

[sub]

No space. It's just the forum adding a space because it's over the maximum word length.

[johnsonx42]

got it, glad I checked.

Code:

HKEY_LOCAL_MACHINE\Software\NPVR\UseClockForTimingInfo=1(DWord)

[BrettB]

got it, glad I checked.

Code:

HKEY_LOCAL_MACHINE\Software\NPVR\UseClockForTimingInfo=1(DWord)

On a 64-bit version of Windows, should that be:

Code:

HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\NPVR\UseClockForTimingInfo=1(DWord)

?

[johnsonx42]

Yes

[pBS]

do you think this might be related to the HPET [high performance event timers] in bios settings?
may want to try changing that to see if any difference if your motherboard has it in bios..

[johnsonx42]

I have investigated HPET a bit, I've tried some windows settings to force it's use which didn't help with the clock drift issue. I haven't tried disabling it in the bios because it's a pain to access the BIOS settings on my HTPC. I may do it at some point, but for now with the patch sub so kindly provided everything is working great again.