Weather 2 Wishlist

[mikeh49]

I don't think it ever worked right for me on NPVR on a dedicated box, i.e., no NMT or other extender. It appears there is a two level images menu structure. When I select Images, I get the exception and then hit continue on the exception box, I end up at the current or forecast screen where I began. If I then go up to the hidden menu, my choices are Back and Radar (I don't have any temperature maps, etc configured. I suppose they would be on this submenu if they were configured?) Does this hep? Interesting that it works on the NMT but not the PC.

[imilne]

That's what it's doing for me too (with no extender). The reason I asked if it had ever worked was because the plugin isn't contained in a class that extends from sub's NewStyleButtonListPlugin implementation and all the menu handling code has been written by scb147 instead. This may be because of the two level menus though, I'm not sure. I'm a little uneasy about messing with that code because it would be a lot of work to change it to use sub's class (and potentially find it made no difference!).

Iain

[mikeh49]

I did some additional testing with the following results:

1. I get the exception when "entering" or "leaving" the sub-menu.
   
2. Hitting Continue on the exception box leaves me at the same screen, i.e. hidden menu visible with no change, i.e., Images still displayed.
   
3. Up arrow at this point brings up the sub=menu with Radar and Maps displayed.
   
4. Hitting Back at this point brings up the exception again.
   
5. Continue maintains the same screen, and up arrow then goes back to the highest level hidden menu.
   

Would it be possible to put the sub-menu items on the main hidden menu? I think there are just 3: radar, maps and satellite. It looks like there might be enough screen space for all three.

Since Jaggy's change to the hidden menu, I've had a couple of instances where going to Weather from main menu killed NPVR. Happened twice during this testing if I left Weather with an image displayed, and then tried to go back. I can't repeat it now though. I'll do some more testing.

[Jaggy]

While updating my JustRetro Weather skin just now I found something containing to the exception that may be interesting to someone in the know??

That is when using the mouse to navigate to the hidden menu & then to the next level for the satellite, maps etc. menu level & I don't get any exception & everything works fine unlike when using the keyboard??

[whurlston]

Here is a quick and dirty patched Weather.dll to prevent the exception being thrown. This patch also improves update speeds, especially if you are loading a lot of images.

@imline, I just placed a try/catch around line 454 of KeyHandling.cs to prevent the exception being thrown.

I have some hidden menu code for NewStyleButtonListPlugin. I will see about porting it.

[mikeh49]

Thanks a bunch! Works great on my test box, but didn't on my main HTPC. The plug-in would not load at all and there was an error message in the log. I'll check again and post the log.

You just copy the new dll into the NPVR/Plugins/Weather folder and restart NPVR, right?

[whurlston]

You just copy the new dll into the NPVR/Plugins/Weather folder and restart NPVR, right?

Yes. This is a drop in replacement for 1.0.1.2. Make sure that NPVR is closed before overwriting the old DLL.

[mikeh49]

OK, works great on the HTPC now. I did not have all the latest versions on that box, so I just transferred the whole plugin from the test box and that fixed it. Thanks again.

[Snooze]

Where can I get the version 1.0.1.2 or newer? I keep getting the exception when selecting images with the version on the wiki (version 1.0.1.0 I think is there).

[Jaggy]

If my memory servers me correctly that would be the update to the wiki download that is attached to post 55 in this thread....