NLite windows build

[mvallevand]

From the remote most of the keys return key=31 probably not worth writing them down until you have a chance to look or put the source on github so I can check.

The two top priorities should

- stop because you need a keyboard tp hit ctrl-s
- and Back Using a remote reminded me that many remotes need to use the Back key as Esc and that should not trigger the useless key=8 Fortunately my MCE remote does have a clear key that does do Esc.

While playing a recording hitting the single keyboard character and arrow keys without control do weird things After you get an OSD F, R and arrows do attempt to seek but then there are 404's 400 and then I need to exit nlite and get back in. Others just give a not a png messages.

Space does play/pause and numbers do show OSD.

If I don't hit arrows after the number the OSD disappears but the number is not cleared, not sure if that is a NextPVR thing.

Killing nlite with a video playing I need to ctrl-s on restart whether I have crashed on a seek or not.

Martin

[sub]

Hmm, I'm not really sure what to do about remotes. When it comes to the MCE remote, they send some of the buttons as keystrokes, which SDL is seeing, and the app is able to pass to NextPVR. I've done some improvements so that Stop and Back from an MCE remote work the way you're expecting, but I'm guessing you'd quickly come back and tell me other buttons on the MCE remote don't work - which is true. The only way I could implement see some of these extra buttons is doing some really Windows specific API stuff (which is probably fine, but the app isn't currently having to do that).

For the navigation keys during playback, I'll need to implement support for these directly into NLite, since it's doing the playback. In NLite these types of keys wouldn't be passed back to NextPVR.

[mvallevand]

Hmm, I'm not really sure what to do about remotes. When it comes to the MCE remote, they send some of the buttons as keystrokes, which SDL is seeing, and the app is able to pass to NextPVR. I've done some improvements so that Stop and Back from an MCE remote work the way you're expecting, but I'm guessing you'd quickly come back and tell me other buttons on the MCE remote don't work - which is true. The only way I could implement see some of these extra buttons is doing some really Windows specific API stuff (which is probably fine, but the app isn't currently having to do that).

Are sure implementing support for ctrl+key won't help? In any case the VK_ codes are often supported on Linux varieties. The WM_APPCOMMAND codes might be a problem. Perhaps have NLite map the command from an Kodi remote configuration back to what the server wants as most clients that will be supported will support Kodi remote mapping in LIRC etc.

If you implement Stop and Back, certain old MVP users will ask for Back to function like Stop

For the navigation keys during playback, I'll need to implement support for these directly into NLite, since it's doing the playback. In NLite these types of keys wouldn't be passed back to NextPVR.

If you are controlling playback then you probably want to disable the OSD mouse bar.

Martin

[sub]

Here is some my minor tweaks, to improve stop/back with an MCE remote, and the ">|" "|<" skip buttons. I haven't added WM_APPCOMMAND for the other MCE buttons.

Also fixed an issue that had snuck in somewhere along the way for trying to skip during playback leading to a 404

[mvallevand]

Ok no crashes on seeking with the keyboard but nothing with my Hauppague MCE Remote. Seeking is a bit hard to judge because as I posted before the timeline is wrong on all my files but after seeking back the timeline is not in sync with the current display position.

Martin

[mvallevand]

The server was a better place to fix this, since the URL is more accurate now, but let me know if it does cause those a problem and I'll provide an updated server that conditionally does this escaping.

This new URL breaks Kodi xnewa playback from a share because the passed filename is no longer the valid filename. How are you goig to make it conditional?

Martin

[sub]

What is the user agent when the request comes form XNEWA?

I'd have thought that since you're manipulating the string anyway to extract the filename part, and construction a share-based filename from it, you could have just added the step of unescaping it? I'm happy to do it in NextPVR based on the user agent if you prefer though.

[mvallevand]

Headers are follows from Krypton, perhaps

Code:

2016-10-13 12:03:53.645    [DEBUG][20]    method=recording.lastupdated
2016-10-13 12:03:53.645    [DEBUG][20]    parameters:
2016-10-13 12:03:53.645    [DEBUG][20]       method: recording.lastupdated
2016-10-13 12:03:53.645    [DEBUG][20]       sid: 7653ca7498994070a7dcffbaebf5f1cd
2016-10-13 12:03:53.645    [DEBUG][20]       client_ip: 172.16.3.62
2016-10-13 12:03:53.645    [DEBUG][20]       host_callback: 172.16.3.2:8866
2016-10-13 12:03:53.645    [DEBUG][20]       physical_path: C:\Users\Public\NPVR\web\
2016-10-13 12:03:53.645    [DEBUG][20]       user_agent: Python-urllib/2.7
2016-10-13 12:03:53.645    [DEBUG][20]       range:
2016-10-13 12:03:53.646    [DEBUG][20]       requested_path: /service
2016-10-13 12:03:53.646    [DEBUG][20]       verb: GET
2016-10-13 12:03:53.646    [DEBUG][20]    LastUpdated

Thinking about the the NMT does something like this too. I also pass things like WebRadio ,UPnP and YouTube URLs and I have just started on using links from Google Drive.

Unescaping does work but it means a new client for everyone.

Martin

[sub]

Thinking about the the NMT does something like this too.

NMT/MVP have a different interface controller class, and never go near this code that was escaping the URLs for sending to web clients. If you were passing something to the NMT with spaces before, then it'll still have spaces.

I also pass things like WebRadio ,UPnP and YouTube URLs and I have just started on using links from Google Drive.

Can you give me a concrete example of one that is failing?

Unescaping does work but it means a new client for everyone.

Yep, I hear you and I'm happy to post a patch that defaults to the old style for XNEWA. In general, I think these correctly escaped URLs are right thing to do, since they're supposed to be URLs and should be in a valid format, so should default to that.

What clientID are you using with your requests? Does that identify XNEWA?

[mvallevand]

NMT/MVP have a different interface controller class, and never go near this code that was escaping the URLs for sending to web clients. If you were passing something to the NMT with spaces before, then it'll still have spaces.

Probably at the end of this I i will need to connect an NMT to confirm.

Can you give me a concrete example of one that is failing?

Non work unescaped here I just show you what is extracted before and after I unescape them

Code:

13:22:09 T:8124   DEBUG: /stream?f=K%3A%5C12%20Monkeys%5C12%20Monkeys.S02E01.Year%20of%20the%20Monkey.ts
13:22:09 T:8124   DEBUG: /stream?f=K:\12 Monkeys\12 Monkeys.S02E01.Year of the Monkey.ts

13:24:08 T:8124   DEBUG: /stream?f=%5C%5C172.16.3.244%5CMovies%5CValley%20Girl%5CValley%20Girl%20(1983).ts
13:24:08 T:8124   DEBUG: /stream?f=\\172.16.3.244\Movies\Valley Girl\Valley Girl (1983).ts

13:25:28 T:13592   DEBUG: /stream?f=https%3A%2F%2Fdrive.google.com%2Fuc%3Fexport%3Ddownload%26id%removed
13:25:28 T:13592   DEBUG: /stream?f=https://drive.google.com/uc?export=download&id=removed

What clientID are you using with your requests? Does that identify XNEWA?

Yes but technically I send KNEWA+MAC ID since I changed to KNEWA for Kodi.

Martin