[DEV] TV Guide Rows change

[johnsonx42]

I'm curious if you guys have looked at the change I made to the method of selecting the number of rows in the TV Guide. My method may be more elegant, but I'm unsure whether it gains anything.

I was pondering the idea of alternate TV Guide layouts, but I don't know that there's any need or demand for that. One that occurs to me is a widescreen layout where the listings go to the bottom of the screen and the selected show details appear on the side. Another might be a guide that shows 3 hours of programs instead of 2, if that is possible (I see there's a setting for that in config.xml, but it doesn't seem to do anything).

If there are to be alternate layouts, then having the selection of the number of rows separated from the selection of the base layout certainly makes sense.

Discuss?

[Hairy]

I think this idea makes more sense if we can come up with some useful alternative TV Guide layouts. As you said if we can, then we can use the "...Resources\Layout\TVGuide" folder for these different layouts and have the number of rows selected separately.

The trick is coming up with useful alternative layouts

a guide that shows 3 hours of programs instead of 2, if that is possible (I see there's a setting for that in config.xml, but it doesn't seem to do anything).

I think currently, PVRX2 can only display 2 hours.

[Fatman_do]

Yeah, if you feel alternative guides or improvements can be made, we can certainly add them. Might get a chance to look at your changes tonight or Friday.

[johnsonx42]

oops, I was just looking at what I committed to the SVN for this change (r256), and I made several errors. There's a bunch of extra skin.xml files in there that aren't supposed to be there, and I also let some unrelated changes sneak into the committed SkinPluginConfig.xml. I should have been more careful when I copied my changes from my test environment to the commit directories... please forgive, and I'll fix it tonight.

[johnsonx42]

fixed, now at r257

[Fatman_do]

Ok, thanks, planning on taking a look this weekend. Been quite busy of late. A second job does that to your free time.

[johnsonx42]

just a simple re-arrangement, but I think it works... (a few more tweaks though, possibly pending the new variables sub added for the next release)

what do you think?

[Fatman_do]

Looks good.