something is creating rougue folders in skin2 folder

[mvallevand]

What about this in SkinPluginHelper\Helper.cs

line 239 DestinationDirectory.FullName + @"\" + SourceSubDirectory.Name),

or maybe the ones that don't do the "\\"

Martin

[whurlston]

What about this in SkinPluginHelper\Helper.cs

line 239 DestinationDirectory.FullName + @"\" + SourceSubDirectory.Name),

or maybe the ones that don't do the "\\"

Martin

The @ symbol tells it that the string does not need to be escaped so that shouldn't be it.

@"\" is the same thing as "\\"

Can one of you post your SkinPluginHelper.exe.log so I can double check something?

[JavaWiz]

It has to be that, the iplayer plugin or Music, since those are the only ones you have in common. I'm guessing it's the CS4 code though.

Downloading the code now to take a look.

Do either of those use the WizUtilities? There are a couple of methods in WizInfo that may be related to this, in particular this one:

Code:

/// <summary>
        /// Copy files from Blue Skin directory to current skin directory if they don't exist.
        /// Plugins should implement this method, so the plugin will run under other skins.
        /// </summary>
        /// <param name="skinSubDir">target Skin sub directory</param>
        public static void populateSkinDirectoryIfNeccessary(string skinSubDir)
        {
            WizInfo.LogMessage("WizUiHelper", "populateSkinDirectoryIfNecessary()", skinSubDir, LOGLVL.INFO);
            string targetSkin = GBPvrSkinRootDirectory() + skinSubDir;
            targetSkin = targetSkin.Replace(@"\skin\", @"\skin2\");
            WizInfo.LogMessage("WizUiHelper", "populateSkinDirectoryIfNecessary()", "TargetSkin: " + targetSkin, LOGLVL.INFO);
            string blueSkin = GBPvrStandardSkinDirectory() + skinSubDir;
            blueSkin = blueSkin.Replace(@"\skin\", @"\skin2\");
            WizInfo.LogMessage("WizUiHelper", "populateSkinDirectoryIfNecessary()", "BlueSkin: " + blueSkin, LOGLVL.INFO);
            if (!Directory.Exists(targetSkin))
            {
                WizInfo.LogMessage("WizUiHelper", "populateSkinDirectoryIfNecessary()", "I don't think " + targetSkin + " directory exists", LOGLVL.INFO);
                try
                {
                    Directory.CreateDirectory(targetSkin);
                }
                catch (Exception e)
                {
                    WizInfo.LogMessage("WizUiHelper", "populateSkinDirectoryIfNecessary()", "Bummer, guess I was wrong. " + e.Message, LOGLVL.INFO);
                }
            }
            string[] files = Directory.GetFiles(blueSkin, @"*.*");
            for (int i=0; i < files.Length; i++)
            {
                string fileName = Path.GetFileName(files[i]);
                if (!File.Exists(targetSkin + "\\" + fileName))
                {
                    File.Copy(files[i], targetSkin + "\\" + fileName);
                }
            }

[whurlston]

Not sure if they do, but that could be it:

string targetSkin = string targetSkin = GBPvrSkinRootDirectory() + skinSubDir;

If for some reason GBPvrSkinRootDirectory() doesn't return a string ending with "\" and they don't pass a skinSubDir starting with it, that could cause the issue.

As an off topic ramble: Did anyone know that C# can use unix style paths with forward slashes such as Directory.CreateDirectory("skin2/myplugin"); ? I just recently stumbled on that.

[JavaWiz]

Not sure if they do, but that could be it:



If for some reason GBPvrSkinRootDirectory() doesn't return a string ending with "\" and they don't pass a skinSubDir starting with it, that could cause the issue.

As an off topic ramble: Did anyone know that C# can use unix style paths with forward slashes such as Directory.CreateDirectory("skin2/myplugin"); ? I just recently stumbled on that.

Here is the code for GBPvrSkinRootDirectory():

Code:

[SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]<summary>[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#008000][SIZE=2][COLOR=#008000] Get PVRX2-GBPVR skin root directory.[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]</summary>[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]<returns></returns>[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]public[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]static[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]string[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2] GBPvrSkinRootDirectory()[/SIZE]
[SIZE=2]{[/SIZE]
[SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]return[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2] GBPvrLegacySkinRootDirectory().Replace([/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]"\\skin\\"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2], [/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]"\\skin2\\"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2]);[/SIZE]
[SIZE=2]}[/SIZE]

and GBPvrLegacySkinRootDirectory():

Code:

[SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]<summary>[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#008000][SIZE=2][COLOR=#008000] Get GBPVR Legacy skin root directory.[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]</summary>[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]///[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#808080][SIZE=2][COLOR=#808080]<returns></returns>[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]public[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]static[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]string[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2] GBPvrLegacySkinRootDirectory()[/SIZE]
[SIZE=2]{[/SIZE]
[SIZE=2][COLOR=#008000][SIZE=2][COLOR=#008000]//return GBPVR.Public.PluginHelperFactory.getPluginHelper().GetSkinRootDirectory();[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]string[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2] rsDir = cfgGetString([/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]"RootSkinDirectory"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2], [/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]@"\skin\"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2]);[/SIZE]
[SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]string[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2] curSkin = cfgGetString([/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]"ActiveSkin"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2], [/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]"blue"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2]);[/SIZE]
[SIZE=2][COLOR=#0000ff][SIZE=2][COLOR=#0000ff]return[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2] GBPvrRootDir + rsDir + curSkin + [/SIZE][SIZE=2][COLOR=#a31515][SIZE=2][COLOR=#a31515]@"\"[/COLOR][/SIZE][/COLOR][/SIZE][SIZE=2];[/SIZE]
[SIZE=2][COLOR=#008000][SIZE=2][COLOR=#008000]//return cfgGetString("RootSkinDirectory");[/COLOR][/SIZE]
[/COLOR][/SIZE][SIZE=2]}[/SIZE]

So, it looks like it should always end with a '\'

[whurlston]

Yup, it will always end with the backslash so it shouldn't be caused by WizTools then. It has to be some code in one of the other plugins. I'll try to load them up this weekend and test them if it hasn't been found by then.

[roy]

I see this also. Right now I only get the moviewiz folder for whichever cs skin I switch to, but I have seen other plugin folders before. The folder is created upon startup of GBPVR.

Found this in PVRX2.exe.log:

Code:

2009-08-26 09:23:10.366    INFO    [1]    WizUiHelper:   populateSkinDirectoryIfNecessary()- MovieWiz
2009-08-26 09:23:10.366    INFO    [1]    WizUiHelper:   populateSkinDirectoryIfNecessary()- TargetSkin: C:\Program Files\Devnz\GBPVR\.\skin2\Community-SDMovieWiz
2009-08-26 09:23:10.366    INFO    [1]    WizUiHelper:   populateSkinDirectoryIfNecessary()- BlueSkin: C:\Program Files\Devnz\GBPVR\.\skin2\Community-SDMovieWiz
2009-08-26 09:23:10.366    INFO    [1]    WizUiHelper:   populateSkinDirectoryIfNecessary()- I don't think C:\Program Files\Devnz\GBPVR\.\skin2\Community-SDMovieWiz directory exists

Maybe this is helpful.

[JavaWiz]

Hmm... Roy, what version of WizUiHelper.DLL do you have?

[roy]

Hmm... Roy, what version of WizUiHelper.DLL do you have?

Looks like 1.0.20.1, per the log attached.

[roy]

OK, I just installed the latest WizDLLs from the wiki (WizDLLs_setup_V2009_07_08.exe), and seems to have resolved it. No more directories created.

edit: However, now when using the skin plugin, I get dumped back to the main menu when selecting a directory. Seems it may be related to wiz, at the end of the attached log.