reduce and clean up logging to web.log

[reven]

current web.log logs a lot of information, that gets logged every 100ms or so, this results in a log file full of things like

Code:

2012-11-28 21:08:10.132    [DEBUG][4]    about to read 50000 from location 80000000  (current length = 80158688)
2012-11-28 21:08:10.132    [DEBUG][4]    read@3.1
2012-11-28 21:08:10.132    [DEBUG][4]    About to send 50000 bytes
2012-11-28 21:08:10.133    [DEBUG][4]    Sent 50000 bytes
2012-11-28 21:08:10.133    [DEBUG][4]    RollingFile.Position returning 80050000
2012-11-28 21:08:10.133    [DEBUG][4]    RollingFile.Length returning 80170160
2012-11-28 21:08:10.133    [DEBUG][4]    <Files>
  <Length>80170160</Length>
  <File offset="0">R:\LiveTV\live-TV2SD-1516-18.ts</File>
  <Duration>178668</Duration>
  <Complete>0</Complete>
</Files>

2012-11-28 21:08:10.133    [DEBUG][4]    about to read 50000 from location 80050000  (current length = 80158688)
2012-11-28 21:08:10.133    [DEBUG][4]    read@3.1
2012-11-28 21:08:10.133    [DEBUG][4]    About to send 50000 bytes
2012-11-28 21:08:10.133    [DEBUG][4]    Sent 50000 bytes
2012-11-28 21:08:10.133    [DEBUG][4]    RollingFile.Position returning 80100000
2012-11-28 21:08:10.133    [DEBUG][4]    RollingFile.Length returning 80170160
2012-11-28 21:08:10.133    [DEBUG][4]    <Files>
  <Length>80170160</Length>
  <File offset="0">R:\LiveTV\live-TV2SD-1516-18.ts</File>
  <Duration>178668</Duration>
  <Complete>0</Complete>
</Files>

this has a few issues
1. log files are hard to find key pieces of info
2. log files are rolled over quickly due to file size and only contains logging details for the past few minutes

this information is great sure, but perhaps all the redundant info like this which happens so often be omitted (or only turned on if configured too, default is off) and only log it if there is an issue. then you can leave log info like this

Code:

2012-11-28 21:09:56.929    [DEBUG][17]    Got Web Request (192.168.1.40): /service    method=recording.list&filter=pending&sid=206f7f94bffc4a45bb7815b20f513a6b
2012-11-28 21:09:56.929    [DEBUG][17]    method=recording.list
2012-11-28 21:09:56.929    [DEBUG][17]    parameters:
2012-11-28 21:09:56.929    [DEBUG][17]       method: recording.list
2012-11-28 21:09:56.929    [DEBUG][17]       filter: pending
2012-11-28 21:09:56.929    [DEBUG][17]       sid: 206f7f94bffc4a45bb7815b20f513a6b
2012-11-28 21:09:56.929    [DEBUG][17]       client_ip: 192.168.1.40
2012-11-28 21:09:56.929    [DEBUG][17]       host_callback:
2012-11-28 21:09:56.929    [DEBUG][17]       physical_path: C:\Users\Public\NPVR\web\
2012-11-28 21:09:56.929    [DEBUG][17]       user_agent:
2012-11-28 21:09:56.930    [DEBUG][17]       range:
2012-11-28 21:09:56.930    [DEBUG][17]       requested_path: /service

in there and easier to find.

[imilne]

Sub (I think) stated that he preferred the logs to be full-debug by default as then people don't need reminded to switch them to that mode when reporting issues. I think this is a good idea.

If an option is added to reduce their verbosity then it shouldn't be the default. But I agree it would be handy to have.

Iain

[reven]

i get having debug by default, but i believe this is over kill for this since the log files roll over way to quickly and you can lose the logging info you require with the file roll over.

[sub]

If you bump the thread in a couple of weeks when I'm back in NZ, I'll remove some of this stuff. There is an extra verbose mode of logging, and I'll probably move these messages to that, which I can ask people to enable if needed.

[reven]

cheers will do.

[mvallevand]

Great I'll bump it too. If at all possible, maybe at the thread live like you do for NDigitalHost, I'd like to see web.log broken into the three logs one for standard web.log, one for xbmc client noise, and one for nmt client noise. I'd like to see the streaming NextPVR client noise separated out in NRecord too.

Martin

[reven]

bump as requested

[sub]

I've reduced this streaming logging for the next release.

[reven]

cheers