Toggle option for SRT subtitles

[imilne]

You can currently toggle DVB/DVD subtitles on or off, but SRT subtitles can only be turned on - you can't disable them again without quitting the video.

Could we have a "Disabled" option added to the popup subtitles box for SRT stuff too please?

Iain

[sub]

If you press ctrl-x, does it allow you to disable the subtitles?

[imilne]

No, that just seems to pop up the same box that Alt+Y does.

Iain

[sub]

Yes, but if you choose 'disabled' from that list, does the subtitles go away? I just tried it here, and the SRT subtitles go away fine.

[imilne]

I don't see disabled in either list though. Just "SRT Subtitles" as the only entry. Want some logs?

Iain

[sub]

Odd. I've got Disabled listed as an option. I'll check the code.

[sub]

What type of file are you playing? Is this a .ts file?

[imilne]

No, these are blu-ray rips in .mkv containers. Disabled shows up as an option for broadcast stuff and DVDs though.

Iain

[sub]

This should get 'Disabled' to show up for file types other than .ts.

[imilne]

Sorry, sub, that still doesn't work for me I'm afraid. I tried with both ctrl+x and alt+y and with SRT files that had the .default.srt bit added and without. The logs don't seem to show much, but here they are anyway...

Iain