couple of issues with recording.recurring.save method

[reven]

im having a couple of issues with recording.recurring.save web call. probably something silly im doing

Code:

http://batman:8866/service?method=recording.recurring.save&recurring_id=113&directory_id=%5BJohn%5D&day_mask=255&timeslot=true&only_new=false&keep=4&pre_padding=6&post_padding=9&sid=91e8facf2665418b8efd7d4577c3c96b

that gives me a result of "Invalid args".

looking at the logs, the error is quite obvious

Code:

method=recording.recurring.save&recurring_id=113&directory_id=%5BJohn%5D&day_mask=255&timeslot=true&only_new=false&keep=4&pre_padding=6&post_padding=9&sid=91e8facf2665418b8efd7d4577c3c96b
2014-01-03 22:03:12.083    [DEBUG][30]    method=recording.recurring.save
2014-01-03 22:03:12.083    [DEBUG][30]    parameters:
2014-01-03 22:03:12.083    [DEBUG][30]       method: recording.recurring.save
2014-01-03 22:03:12.083    [DEBUG][30]       recurring_id: 113
2014-01-03 22:03:12.083    [DEBUG][30]       directory_id: %5BJohn%5D
2014-01-03 22:03:12.083    [DEBUG][30]       day_mask: 255
2014-01-03 22:03:12.083    [DEBUG][30]       timeslot: true
2014-01-03 22:03:12.083    [DEBUG][30]       only_new: false
2014-01-03 22:03:12.083    [DEBUG][30]       keep: 4
2014-01-03 22:03:12.083    [DEBUG][30]       pre_padding: 6
2014-01-03 22:03:12.083    [DEBUG][30]       post_padding: 9
2014-01-03 22:03:12.083    [DEBUG][30]       sid: 91e8facf2665418b8efd7d4577c3c96b
2014-01-03 22:03:12.083    [DEBUG][30]       client_ip: 192.168.1.23
2014-01-03 22:03:12.083    [DEBUG][30]       host_callback: batman:8866
2014-01-03 22:03:12.083    [DEBUG][30]       physical_path: C:\Users\Public\NPVR\web\
2014-01-03 22:03:12.083    [DEBUG][30]       user_agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36
2014-01-03 22:03:12.083    [DEBUG][30]       range:
2014-01-03 22:03:12.083    [DEBUG][30]       requested_path: /service
2014-01-03 22:03:12.083    [DEBUG][30]       verb: GET
2014-01-03 22:03:12.084    [ERROR][30]    neither event_id or start_time/end_time specified

however I dont have an event oid since im updating a "Recurring Recording", which might not have any events in the currently available epg, and if im updating one that has "Any Channel, Any Time", there is no start/stop. can this be updated so if a recurringid is passed, that is accepted?

also whenever i call it passing in an event_id for a new recurrence, eg:

Code:

http://batman:8866/service?method=recording.recurring.save&event_id=1737902&day_mask=255&timeslot=false&only_new=true&keep=0&pre_padding=2&post_padding=4&sid=7b92c163f82940b7b7be90397309fd58

it always returns the very first recurring recording as a result and not the newly created one. not sure if im just doing something wrong on this one or not...

[sub]

I found why this is happening and fixed it for the next build.

Unfortunately I can't post a patch right now since my build is now incompatible with 3.1.x.

[reven]

any chance i could get a build with your change (non public one)? i really should of tested this before you finalized 3.1...

[sub]

I can't give you a build right now, since I'm mid way through some changes, and the app is currently in a broken state. I should be able to give you a build in a few days though.

[reven]

cheers sub

[reven]

just got this error when trying to schedule a recording

Code:

<rsp stat="failed">
<err code="11" msg="Failed to schedule recurring recording"/>
</rsp>

logs indicate that there is conflicts

Code:

2014-01-04 11:11:49.182    [DEBUG][22]    Checking if multi-record possible...
2014-01-04 11:11:49.184    [DEBUG][22]    Checking if multi-record possible...

could you please post a list of all the error codes (never knew about "11") and does "11" only mean there is conflicts? if not, how do you detect the problem was a conflict?

[sub]

11 is "unexpected error". I've changed it to 7 for the next build, which is a more appropriate "no available tuner" error code, and add some info in the body about the conflicts.

[sub]

Most of the codes will mean nothing to you, but:

public const int NOERROR = 0;
public const int ERROR_LOGIN_FAILED = 1;
public const int ERROR_INVALID_ARGUMENTS = 2;
public const int ERROR_VERSION_DEPRECATED = 3;
public const int ERROR_UNKNOWN_DEVICE = 4;
public const int ERROR_UNKNOWN_CHANNEL = 5;
public const int ERROR_RECORDING_NOT_FOUND = 6;
public const int ERROR_NO_TUNER = 7;
public const int ERROR_INVALID_SESSION = 8;
public const int ERROR_INVALID_RESOLUTION = 9;
public const int ERROR_NOT_IMPLEMENTED = 10;
public const int ERROR_UNEXPECTED = 11;
public const int ERROR_CELLULAR_DISABLED = 12;

[reven]

cheers for that, instead of returning 11 (unexpected) could you return no_turner (7) if theres a conflict? or perhaps return a new conflict message? and even better if it could also return the conflicting recording ids (cold just be a comma separated list in the error message)

[sub]

Yes, as mentioned two posts above, I've modified it to return 7, no tuner, and provide list of the recordings conflicts.