PostProcessing.sh and a ' in Show Name

[tjzi422xlk]

I had a problem with calling PostProcessing.sh for a show that has a ' in the title. I've pasted the log lines from when PostProcessing was called:

2019-09-26 21:00:00.361 [DEBUG][8] Starting: bash -c "'/var/opt/nextpvr/scripts/PostProcessing.sh' '/mnt/NextPVR/Recordings/Carols Second Act/Season 01/Carols Second Act.S01E01.Pilot.ts' 12 1946 21 'Carol's Second Act'"
2019-09-26 21:00:00.375 [ERROR][82] bash: -c: line 0: unexpected EOF while looking for matching `''
2019-09-26 21:00:00.376 [ERROR][82] bash: -c: line 1: syntax error: unexpected end of file

Looks like the last argument being passed(show name?) is causing the problem. I seem to remember there was a fix earlier for something like this and the show name does not contain the ' in the file name, so maybe that's what I was thinking of.

Thanks

[mvallevand]

Are you running the current version which posting logs would have shown? I know I pointed this out to sub before.

Martin

[geniepro]

Yes, the issue happens in the latest build as well - I use the docker version

[donbrew]

Why not use the pass "#1" with quotes

[mvallevand]

The problem is the bash command sub submits fails so the script cannot fix it. I guess a fix didn't make the last build.

Martin

[sub]

The problem is the bash command sub submits fails so the script cannot fix it. I guess a fix didn't make the last build.

It did make into the build, and covered several characters, but didn't happen to include single quote character, which needed to be handled differently than the other special characters anyway.

There is a fix for single quote character in the next build.

[tjzi422xlk]

I updated to 5.0.0.191006 and it looks like there is still a problem with a single quote in the show name.
There is a post about a problem with the install - I got around it by downloading the NPVR.zip separately and copying it to the /tmp directory.

Here is the portion of the log where I tested a recording:

2019-10-06 08:30:00.289 [DEBUG][8] Starting: bash -c "'/var/opt/nextpvr/scripts/PostProcessing.sh' '/mnt/NextPVR/Recordings/Mister Rogers Neighborhood/Season 15/Mister Rogers Neighborhood.S15E12.ts' 671 2529 21 $'Mister Rogers' Neighborhood'"
2019-10-06 08:30:00.301 [ERROR][56] bash: -c: line 0: unexpected EOF while looking for matching `''
2019-10-06 08:30:00.301 [ERROR][56] bash: -c: line 1: syntax error: unexpected end of file

I did a little testing and it looks like something like this will work:

bash -c "'/var/opt/nextpvr/scripts/PostProcessing.sh' '/mnt/NextPVR/Recordings/Mister Rogers Neighborhood/Season 15/Mister Rogers Neighborhood.S15E12.ts' 671 2529 21 $'Mister Rogers\' Neighborhood'"

Thanks

[tjzi422xlk]

I did some more testing and it looks like this might be the answer and still preserve the single quote:

bash -c "'/var/opt/nextpvr/scripts/PostProcessing.sh' '/mnt/NextPVR/Recordings/Mister Rogers Neighborhood/Season 15/Mister Rogers Neighborhood.S15E12.ts' 671 2529 21 'Mister Rogers'\'' Neighborhood'" - note, it is single quote,backslash,single quote,single quote after Rogers - it's hard to see.

In my PostProcessing script I echo'd the $1 $2 $3 $4 $5 variables and this is the output:

/mnt/NextPVR/Recordings/Mister Rogers Neighborhood/Season 15/Mister Rogers Neighborhood.S15E12.ts 671 2529 21 Mister Rogers' Neighborhood

[mvallevand]

I updated to 5.0.0.191006  and it looks like there is still a problem with a single quote in the show name.

If you updated with the deb installer note that it is currently not doing any updates.  https://forums.nextpvr.com/showthread.php?tid=59830

Martin

[mvallevand]

I can confirm that this is still an issue with the latest build

Code:

2019-10-07 09:18:09.444    [DEBUG][8]    Starting: bash -c "'/var/opt/nextpvr/scripts/ParallelProcessing.sh' '/home/martin/recordings/Milo Murphys Law/Season 01/Milo Murphys Law.S01E03.Rooting for the Enemy; Sunny Side Up.ts' 228 21755 1550 $'Milo Murphy's Law'"
2019-10-07 09:18:09.472    [ERROR][64]    bash: -c: line 0: unexpected EOF while looking for matching `''
2019-10-07 09:18:09.472    [ERROR][64]    bash: -c: line 1: syntax error: unexpected end of file

Martin