Watching in-progress recording goes past end of recording

[cncb]

If I watch half a recording, it shows the progress indicator and partially watched icon as expected. I can resume playback correctly. However, it seems to internally mark the recording as Watched. That is, it shows the Watched indicator at the top folder level for the show and I can only "Mark as unwatched" in the context menu for the recording. If mark it as unwatched and then mark it as watched, this doesn't stick (it switches back to unwatched when I restart Kodi). This is the case for both with/without MySQL.

[mvallevand]

You did find another state change where Kodi isn't calling the backend marking are recording as watched that is already at position 0.  Not really a logical selection but the attached hopefully addresses that. 

I notice that when marking as record as unwatched it can take a while for the selection bar to change to unwatched but when it not highlighted it does show. Eventually it shows.  That is all core.

There is also still something funny going on though I am seeing this https://imgur.com/a/dzjXu97  on a resume (top is first time from zero the bottom is the same file after Kodi restart) I do think the time choice better I just don't know if I can add another hack to fix it.



Martin

[cncb]

That seems to fix the toggle of watched.  Is there any way to address the issue below?

If I watch half a recording, it shows the progress indicator and partially watched icon as expected.  I can resume playback correctly.  However, it seems to internally mark the recording as Watched.  That is, it shows the Watched indicator at the top folder level for the show and I can only "Mark as unwatched" in the context menu for the recording.

[mvallevand]

After reading the code it turns out the watched status relates to the play count.  When you click watch or watch to the end the play count increments.  When the play count increases it is already watched which is why you can't mark it watched.  Also the playback position indicator (which I considered partially watched) overrides the watch status.

This update attempts to workaround that issue properly on load so it will be normal until the recording is watched or you re-open a previously watched recording. 

There still is no way in Kodi to reset the playback position on a watched recording to EOF because it is already watched.  You'd have to unwatch and then watch to trigger that.

Martin

[cncb]

Looks good.  Seems to be working just like Leia now.  Thanks again for all your work on this.

[mvallevand]

Leia doesn't work quite the same. if you click watched it will save the watched status in a local database but it will clear the NextPVR database so only the one client will know it is watched. Using MySQL you might not have noticed but if you used the web client or any client not connected to you'd see it as unwatched.

Thanks for the testing.

Martin

[mvallevand]

@cncb Since you are a MySQL user do you think it is better to have an option to turn of the sync with the backend totally and then the resume and play count would be managed solely be Kodi?

Independence might be good for people with lots of boxes, or Kodi setup with multpole logins and it might helps with kids or guests too, but MySQL use will take more management since one machine configured wrong will wipe out everyone so it is really an expert setting

Martin

[cncb]

Yes, that would a useful option. I was actually going to suggest that during testing but assumed it could not be done.

[mvallevand]

Give this a go and see now it works.   Resume points should be totally isolated from NextPVR with this setting.  It actually causes less traffic with NextPVR because there is a lot of back and fourth with clients when the resume point changes.  Downside again is other clients won't see them.

The settings will be stored in MyVideos119.db if you want to browse MySQL.  Resume is in the bookmark table timeInSeconds and playCount is in the files table.

It's the full zip for the settings dialog etc. 
 
Martin

[cncb]

It works but I think the option is "reversed".  That is, if "Store local resume points" is enabled, it appears to sync with the NPVR server.  It stores it locally in the database when disabled.