UK OTA EPG New Programmes

[mvallevand]

It looks the any day query is creating a type 2 query not a type 3.

Martin

[sub]

Actually you could be right - kind of difficult to follow this. It's been a really long time since I looked at this code, and it's complicated.

It would have been more clear cut if these calls had used &recurring_type=x, which specs our more clearly what type of recurring recording they are:

Code:

switch (int.Parse(parameters["recurring_type"]))
{
     case 1: // Record Season (NEW episodes on this channel)
         dayMask = DayMask.ANY;
         onlyNewEpisodes = true;
         timeslot = false;
         break;

     case 2: // Record Season (All episodes on this channel)
         dayMask = DayMask.ANY;
         timeslot = false;
         break;

     case 3: // Record Season (Daily, this timeslot)
         dayMask = DayMask.ANY;
         timeslot = true;
         break;

     case 4: // Record Season (Weekly, this timeslot)
         if (epgEvent != null)
         {
             dayMask = (DayMask)(1 << ((int)epgEvent.StartTime.ToLocalTime().DayOfWeek));
         }
         else if (existingRecurring != null)
         {
             dayMask = (DayMask)(1 << ((int)existingRecurring.StartTime.ToLocalTime().DayOfWeek));
         }
         else
         {
             if (parameters.ContainsKey("start_time"))
             {
                 long fileTime = long.Parse(parameters["start_time"]) * 10000000L + 116444736000000000L;
                 DateTime tempStartTime = DateTime.FromFileTimeUtc(fileTime); // already UTC
                 dayMask = (DayMask)(1 << ((int)tempStartTime.ToLocalTime().DayOfWeek));
             }
         }
         timeslot = true;
         break;

     case 5: // Record Season (Monday-Friday, this timeslot)
         dayMask = DayMask.MONDAY | DayMask.TUESDAY | DayMask.WEDNESDAY | DayMask.THURSDAY | DayMask.FRIDAY;
         timeslot = true;
         break;

     case 6: // Record Season (Weekends, this timeslot)
         dayMask = DayMask.SATURDAY | DayMask.SUNDAY;
         timeslot = true;
         break;

     case 7: // Record Season (All Episodes, All Channels)
         dayMask = DayMask.ANY;
         channelOID = 0;
         timeslot = false;
         break;

}

[mvallevand]

Just get in a telephone booth and go back 12 years and make the change. It turns out Weekly, Weekdays and Weekends do set timeslot recordings so Daily is the main problem. The only other issue would be NextPVR doesn't support mixed days from the day mask so NextPVR also makes it an Any Episode type.

@ShadowMask not sure if it helps for now, but if your shows are Mon-Friday, Weekly or Sat-Sunday timeslots will already be created. For the series I record this has never been something I would have used in testing which explains some of the confusion in this thread.

Martin

[sub]

I think some of that stuff was actually added later, so not overly surprising we didn't use it at the time.

I think it was added at the same time I added the NextPVR v5 web app, because I found it too hard to replicate the same recording types as NextPVR.exe typically produced.

[mvallevand]

Yes I found old code in Kodi too, it was using type=7 rather than recurring_type=7 which probably changed around the same time The XML still shows type. Anyway I have the change ready, since Daily is the default it is good to have it working as timeslot.

Martin

[mvallevand]

@ShadowMask if you would like to test the change in the Kodi daily timeslot timer I created an LE build here https://forums.nextpvr.com/showthread.ph...#pid590907 where the next build is being tested.

Martin

[ShadowMask]

@ShadowMask if you would like to test the change in the Kodi daily timeslot timer I created an LE build here https://forums.nextpvr.com/showthread.ph...#pid590907 where the next build is being tested.

Martin

@mvallevand I tried to test this but it didn't seem to make a difference, setting a timer with the defaults (Recording: Repeating guide) still results in a Series link all episodes scheduler beig created in npvr, not a Daily timeslot?

All I did was delete the old pvr.nextpvr from the addons folder and replace it with the 21.1.0.1 zip contents.

Do I need to do anything else to get this to work correctly?

Thanks

[mvallevand]

Not sure about your approach but you should install the addon using install from zip file. As a minimum Kodi would need to restart since Linux would keep using the old binary.

Martin

[ShadowMask]

Not sure about your approach but you should install the addon using install from zip file.  As a minimum Kodi would need to restart since Linux would keep using the old binary.

Martin

I can confirm this does work, I needed to do the reboot as you said.

I now get more options in kodi, the default in kodi is still Recording: repeating (guide), but I can now see there is also a seperate Recording: repeating (all episodes) entry as well.

If I set a timer using the default Recording: repeating (guide), the resulting scheduler in npvr is now record series, daily this timeslot. If I use the Recording: repeating (all episodes) option in kodi, the scheduler is set correctly to record series (all episodes)

So, this looks to be working great.
Thanks Martin

[mvallevand]

Great thanks for testing both these changes, and I will ask sub to push the change and it will flow to everyone over the next little while, your LE box will get the official patch too.

The only minor issue now should be that NextPVR doesn't allow arbitrary days for the timeslot and those that match the defined rules will still become all episode recordings like you found was happening with a daily selection. At least we know this now.

Martin