comskip is skipping comskipping

[soccerdad]

Or better titled, "I don't know how to write a batch file to do this"

OK, I put comskip.exe and associated files in the C:Users\Public\NPVR folder. I know it works because I dropped a file on it and it starts. I wrote the following batch file and have it saved a PostProcessing.bat and put it in the same folder as comskip.exe:
c:
cd "c:Users\Public\NPVR\comskip.exe %1"

At the end of the recording nothing happens. I see in the log:

2010-06-18 17:02:01.755 [DEBUG][6] Starting: C:\Users\Public\NPVR\PostProcessing.bat D:\Recordings D\Maury\Maury_20100618_16001700.ts 7

I assume the .bat is incorrect, but I don't know what is wrong. Ideas for a poor comskipless soul?...

[Ton]

Hi,

Not sure if it's you're posting, but the batch-file should read something like:

c:
cd \Users\Public\NPVR\
comskip.exe "%1"

[soccerdad]

Thanks, it still did not work so I launched the string copied from the logs to the command line (after putting a pause in the .bat file) and it looks like it starts comskip but is complaining it is not an mpeg. Very odd. Then I copied the same recording and dropped it on comskip.exe and it started processing right away.
[ATTACHMENT NOT FOUND]

The only odd thing I see on the string I copied is the very end is .ts 7 I am not sure what the 7 is for?

[speising]

obviously, the argument to postprocessing .bat isn't enclosed in quotes.
hm.
try

SET FILE=%*
SET FILE=%FILE:~0,-2%
comskip.exe "%FILE%"

[soccerdad]

obviously, the argument to postprocessing .bat isn't enclosed in quotes.
hm.
try

It might be obvious to you.... I have no idea what the % and "" are for, but I can copy anything!

Your try seemed to work when I did it from a c prompt. I will set another one up to record and see what happens.

Thanks

[speising]

arguments are separated by whitespace, if not enclosed in quotes.
so, in your screenshot, comskip gets as filename only "D:\recordings", the first part of the filepath.
%* is just all arguments together, the rest is a little batch trickery, cutting away the last two characters, ie " 7", or the channel number. might not work though with channels > 9, come to think of it, because of the last space.

SET FILE=%*
SET FILE=%FILE:~0,-2%
if "%FILE:~-1%"==" " set FILE=%FILE:~0,-1%
comskip.exe "%FILE%"

[soccerdad]

Well it WORKED! Thanks for the help. Now off to find the post to disable autoskip... I will then post back with a short how to for others like me that are users and semi hackers.

[ElihuRozen]

I think you'll find the version with this line:
comskip "%1"
will work when called by NPVR. When you called it from the command line, it wasn't able to keep the file name parameter separate from the channel parameter. When it is called by NPVR, it will be able to keep them apart. One reason the channel is passed in is that you might want to use a different command line or version of the comskip.ini for handling the output fom different channels. Especially for those of us still using GBPVR, since comskip can be instructed to handle .ts files from digital channels differently than .mpg from analog channels. In NPVR, of course, everything is .ts.

[pBS]

nope, with comskip "%1", if the incoming filename already has quotes, you'll get 2 sets and end up quoting nothing... eg: ""filename.ext""

use this: comskip "%~1"
which removes any existing quotes and adds a pair, so you always have only one pair of quotes..
the ~ removes quotes on the param if there are any...

[soccerdad]

Sorry to be such a pain, but the more I read, the more confused I get. But at least I am comforted by seeing not everyone thinks about this differently! Anyway, I still have the problem if the added channel number at the end is anything different than 1 digit.

I am not sure why sub sends the channel number in the string, or if there is way to keep it from doing that. I will have 1-4 digit channel numbers.