MDAPI Systray Icon

[observer_11]

From this DVBN thread:

Longstanding nuisance with the MDAPI systray icon remaining after exit in GBPVR. If I manually hover the mouse pointer over top it disappears. MDAPI has always behaved this way regardless of software versions. Not a huge issue, more of a wishlist fix for future.

Already have a fix for this, only works for a single active instance of mdapi though. It actually is a bug in gbpvr.

It would be nice if this could be fixed in a future version, currently I have to exit the GUI and hover the systray icon (or reboot the HTPC) in order to reset MDAPI. This problem forces me to have to enable the option for Re-use MDAPI Filter.

[JePe]

And the bug is a missing Release call on the mdapi COM object...

IMDAPIFilter *IMyObject;

// Now we will intialize COM
hr = CoInitialize(0);

// Use the SUCCEEDED macro and see if we can get a pointer
// to the interface
if(SUCCEEDED(hr))
{
hr = CoCreateInstance( CLSID_MyObject, NULL, CLSCTX_INPROC_SERVER,IID_IMyObject, (void**) &IMyObject);

hr = IMyObject->Release();//missing
}

// Uninitialize COM
CoUninitialize();

[sub]

It should be released if you dont have the 'reuse MDAPI filter' enabled. This was required until very recent versions of the filter that fixed other bugs.

The reason it didnt release it was because old versions of the mdapi filter would crash during the release, and would crash the process. The app would instead create an instance of the MDAPI filter when it was first needed, and not release it, and continue to use the single instance until the app was closed.

[observer_11]

It should be released if you dont have the 'reuse MDAPI filter' enabled.

It doesn't seem to release - when I disable Reuse MDAPI Filter I literally end up with several instances of the MDAPI icon in the systray and no subsequent channel changes work. :confused:

[sub]

I'll put it on my list of things to check for the next release.

[JePe]

It should be released if you dont have the 'reuse MDAPI filter' enabled. This was required until very recent versions of the filter that fixed other bugs.

The reason it didnt release it was because old versions of the mdapi filter would crash during the release, and would crash the process. The app would instead create an instance of the MDAPI filter when it was first needed, and not release it, and continue to use the single instance until the app was closed.

It doesn't even release upon application exit, so if you can look at it, would be nice.

[sub]

When reusing the MDAPI filter it purposefully wouldnt call Release() even when the app exited, since the user would see an ugly crash message. At app shutdown it'd call the IMDAPIFilter->Close() method to remove the tray icon. In later versions of the MDAPI filter some bright spark changed the interface without versioning it, so apps using it would have no way of knowing if it had a version of the MDAPI filter with the Close() method in the right place in the interface, so this may or may not work for you. (probably will with older versions though - versions that only had three methods on IMDAPIFilter inteface)

I'll look into why it wasnt being released with 'reuse MDAPI filter' disabled though.

I intend to keep the existing behaviour with the 'reuse MDAPI filter' setting enabled, because I'm still using a very old version of the MDAPI filter. As the saying goes, if aint broke...

[JePe]

Ok, I'm getting the point. I was indeed under the impression that 'reuse MDAPI filter' enabled keeps mdapi alive within gbpvr even if you're not watching livetv but releases mdapi upon application exit. Apparently this crashed gbpvr. If you're keeping the existing behaviour, then we'll have to create a workaround in mdapi to keep track of created references and destroy them ourselves.

The Agarwal version also has more than 3 methods in the interface so I'm curious to what version you're referring to.