Community Skin version 1.0 released.

[Jeff]

A couple of comments.

1. I have been working to create my own theme and it seems to me that the sense of Selected and SelectiveActive for list and icon items are backwards. For example, in the settings plugin, there is no concept of SelectedActive vs SelectiveInactive. In this case, I think that SelectedActive should always be use for list items, since by definition all lists are active when selected. Right now the skin is using Selected. For things like MyVideos and the Video Archive plug-in which have the concept of selected items in inactive lists I think that the selected, inactive item should be Selected and the selected, active item should be SelectedActive. Right now they are reversed.

2. I think that the community skin is installing its version of blue over the default GBPVR version of blue. This is a bad thing because it breaks the automatic fallback capabilities of GBPVR. If the community skin is not up to date for a given plug-in rather than using the blue skin (which all plug-ins support) it tries to use the community version of blue, which causes errors.

Jeff

[sub]

2. I think that the community skin is installing its version of blue over the default GBPVR version of blue.

Is it doing this? If so, then dont!!

[Fatman_do]

A couple of comments.
1. I have been working to create my own theme and it seems to me that the sense of Selected and SelectiveActive for list and icon items are backwards. For example, in the settings plugin, there is no concept of SelectedActive vs SelectiveInactive. In this case, I think that SelectedActive should always be use for list items, since by definition all lists are active when selected. Right now the skin is using Selected. For things like MyVideos and the Video Archive plug-in which have the concept of selected items in inactive lists I think that the selected, inactive item should be Selected and the selected, active item should be SelectedActive. Right now they are reversed.

To be honest with you, I am not sure where that all started, but that can change if it makes more sense. I got confused many times as well since some plugins used the verbal description you are referring too, but needed a different image. I'll look at it and probably make the change if I can't find a reason to keep it how it is now.

2. I think that the community skin is installing its version of blue over the default GBPVR version of blue. This is a bad thing because it breaks the automatic fallback capabilities of GBPVR. If the community skin is not up to date for a given plug-in rather than using the blue skin (which all plug-ins support) it tries to use the community version of blue, which causes errors.

Jeff

The Community skin does nothing with the blue skin. At least it shouldn't. The .nsi script file is installed in the gbpvr root directory so you can take a look at it. Also, in the \Skin\Community\ folder, you should see an install log. Does that indicate something being done to the blue folder?

The latest version of Blue is a similar concept, but it is different. It uses _CoreImages and slightly different names for some things. That might be what you are seeing. That has caused some problems with other skins and the fall-back method, which requires the _CoreImages folder to be copied to those other skins.

[Jeff]

The Community skin does nothing with the blue skin. At least it shouldn't. The .nsi script file is installed in the gbpvr root directory so you can take a look at it. Also, in the \Skin\Community\ folder, you should see an install log. Does that indicate something being done to the blue folder?

The latest version of Blue is a similar concept, but it is different. It uses _CoreImages and slightly different names for some things. That might be what you are seeing. That has caused some problems with other skins and the fall-back method, which requires the _CoreImages folder to be copied to those other skins.

I just noticed the install script and had read through it right before your post. You are right. I could have sworn that the skin I had was working fine before, but I probably just hadn't used those particular plug-in (system and photo library) since upgrading to the latest rev of GBPVR.

My problem is related to not find some of the core images. It seems like the whole idea of the fallback is to not have to copy files to other skins. It is kind of weird if the use of _CoreImages breaks that. Shouldn't GBPVR treat the image path as relative to the actual skin file used?

Jeff

[sub]

I think its just some scenario that I never tested with fallback mechanism, and none of the pre-release testers noticed it either, so it made it out with the current release. It copes with a few image fallback things, but not this specific one. I'll fix it in the next release.

[Fatman_do]

Jeff,

What about just renaming those images from ..SelectedActive to ..SelectedInactive?

That sounds more intuitive, plus I don't have to change every plugin skin file.

[Jeff]

Yes, that had occurred to me as well as the less work solution. I think it would be good however if the text styles we renamed to match to. Right now now you have ListTestSelected, ListTestNormal, and ListTestActive. If you changed it to ListTestInactive and the image to ...Inactive that would make their naming structure match. You could also change to the text style to ListTestSelectedInactive, but that just makes a longer name to type. As far as updating the skins inmass goes, isn;t there some Windows tool to help? In the unix world you could use awk to automate things like that.

Jeff

[Fatman_do]

I have an app that can do this. I planned on globally matching text styles also.

[Fatman_do]

Latest Build: http://www.megaupload.com/?d=SXJLCGRE

ChangeLog:

• Common Dialogs updated to 2.00.
  
• "Active" globally changed to "Inactive".
  
• Word wrap issues in standard library fixed.
  
• My Series BigIcon tweak (reported by McBainUK)
  
• My Series Details tweak (reported by McBainUK)
  
• DVD Ripper updated to 2.00.
  
• SuDoku updated to 2.00.
  
• Theater updated to 2.00 & tweaked refresh text in list display box.
  
• MusicBox no changes, ready for 2.00 as good as it will ever get.
  
• FastFind (XSearch) ready for 2.00 as good as it will ever get (maybe).
  

[Jeff]

Looking good. I have another suggestion. I've noticed that you using named colors for most, but not all things. In particular, I think it would be useful if the ScreenName and HintText styles used named colors so that plug-in skins could reuse these colors if they have other custom text styles that they would like to match in terms of color to these common styles.

Code:

    <!-- Screen Text-->    
        <TextStyle name="ScreenName" color="#2562b0" typeFace="Arial" size="32" style="bold" /><!--Max size=32 -->
        <TextStyle name="HintText" color="White" typeFace="Arial" size="13" style="bold"/> <!--Added-->    
        
        <TextStyle name="ScreenText" color="ScreenText" typeFace="Arial" size="13" style="bold" />
        <TextStyle name="ScreenTextLarge" color="ScreenText" typeFace="Arial" size="16" style="bold" />
        <TextStyle name="ScreenTag" color="ScreenTag" typeFace="Arial" size="14" style="bold" />
        <TextStyle name="ScreenTagLarge" color="ScreenTag" typeFace="Arial" size="16" style="bold" />

Jeff