Why isn't broadcast.firstAired set in the GetEpg function in pvrclient-nextpvr.cpp?

[sub]

What do you mean by "original air date and new episode flag and signifcance fields are available in the API to Kodi"? Is there a way a skin can query npvr api and pull the data in? Im new to addon coding in kodi but if this is possible it would be the easiest method to get the data i want into a skin.

Ive been trying all sorts of methods to get the kodi epg updated for first air date but they all end in some sort of brick wall either on the npvr addon side not populating data or the kodi side not having a method to update epg data besides a direct db edit.

NextPVR is sending original air date, first run flag, significance (premiere, finale etc) data to Kodi. The addon doesn't currently use this data though. We hadn't explicitly added this ourselves because Kodi didn't seem to use it, and there was no way for us to test it.

The cPVRClientNextPVR::GetEpg() function in pvrclient-nextpvr.cpp already pulls most of the info out of this response, like name/description/subtitle, start/end time, etc. Someone would just need to add the few lines of code to pull out the additional <firstrun>, <original> and <significance> from the xml, and set them in the Kodi structures.

The only method i can see to make a work around for myself is to basically gank bits of the npvr addon and build my own addon that replicates the transferEpgEntry functionality but with real data from the npvr API. Your addon though is a serious piece of code and im not familiar with python very well as im a C#/sql developer mostly.

The way it's supposed to work, is you'd create yourself a GitHub account, you'd fork the https://github.com/kodi-pvr/pvr.nextpvr repository, make the changes, then submit a pull request (which is effectively asking someone to merge your changes into the master set of files)

[mvallevand]

There is no Kodi internal support for first run or significance and first aired has almost no skin support and when it works you need to pop open the description which is not very useful in a guide. Also first aired is not the same as new since often international programs can still be new in countries after they are broadcast in the originating country.

I proposed adding (N) to the title but got no feedback since I believe visible indication is best for at a glance browsing but a better change is in the mainline code ksoo is not interested in doing this because he considers it a big change.

Martin

[nogoer]

NextPVR is sending original air date, first run flag, significance (premiere, finale etc) data to Kodi. The addon doesn't currently use this data though. We hadn't explicitly added this ourselves because Kodi didn't seem to use it, and there was no way for us to test it.

The cPVRClientNextPVR::GetEpg() function in pvrclient-nextpvr.cpp already pulls most of the info out of this response, like name/description/subtitle, start/end time, etc. Someone would just need to add the few lines of code to pull out the additional <firstrun>, <original> and <significance> from the xml, and set them in the Kodi structures.

The way it's supposed to work, is you'd create yourself a GitHub account, you'd fork the https://github.com/kodi-pvr/pvr.nextpvr repository, make the changes, then submit a pull request (which is effectively asking someone to merge your changes into the master set of files)

I didnt realize i was able to do that. I do have a git account and this is really a minor change to the one file so ill go and see about doing that. thank you

There is no Kodi internal support for first run or significance and first aired has almost no skin support and when it works you need to pop open the description which is not very useful in a guide. Also first aired is not the same as new since often international programs can still be new in countries after they are broadcast in the originating country.

I proposed adding (N) to the title but got no feedback since I believe visible indication is best for at a glance browsing but a better change is in the mainline code ksoo is not interested in doing this because he considers it a big change.

Martin

Things have to start somewhere and they cant get anywhere until the data is there for the skins to use. Just having the firstaired value populated is the beginning and then skins can take it from there. Any confusing issues due to international airings can be worked out at a later time and is sort of out of scope for what i would expect users to expect from this data. Kodi does have support for first aired and its part of the backend in spite of skins not really using it.

[mvallevand]

If you create a pr make sure to create a pr against the Kodi Estuary skin to so that it can be tested. That is why I didn't bother last time around.

Martin

[nogoer]

If you create a pr make sure to create a pr against the Kodi Estuary skin to so that it can be tested. That is why I didn't bother last time around.

Martin

First i need to figure out how to get setup to build my edited version of the addon. Im on windows so im having some issues tryng to make the build but im sure its just because im not famliar with it all. Once i figure this out ill know what to do to fork and edit estuary and get the data actually displayed and tested.

Thanks

[mvallevand]

I'm back from a trip and see on the Kodi forum that this is being addressed in the backend for Matrix if you don't submit a PR I will include it in my next builds.

Martin

[sub]

I'm back from a trip ...

Welcome back! Hope you had a good time.

[mvallevand]

It was a wonderful trip tough to comeback to see the leaves changing colours. Nice to see a computer screen and feel a keyboard though, you can only do so much on a small screen.

Martin

[sub]

Great - glad you had a good trip.

Nice to see a computer screen and feel a keyboard though, you can only do so much on a small screen.

I know that feeling well