NPVR - VMR9 have wrong AR (WinXP)

[hoborg]

Nothing changed for me with latest patch.

And i am on ATI5770.

BTW, the patch you posted today broke playback of not interlaced videos - now they have black borders around pictures or they are oversan with wrong AR. Was OK with patch you posted first on this thread.
The scaling problem was only with interlaced videos, rest was OK.

[hoborg]

Looks like i will stay on GB-PVR for long time.

I can enable FFDshow deinterlacing and output MPEG-2 as progresive, but this will decrease picture quality + framerate and increase CPU usage :/

[sub]

Have you got a progress MPEG-2 sample? All the MPEG-2 Sources I have here are interlaced.

[hoborg]

Have you got a progress MPEG-2 sample? All the MPEG-2 Sources I have here are interlaced.

This happend on all video formats.

BTW, can i ask why nPVR needs to touch the Size X/Y sliders when opening video? Should not this be set just after user hit F7? At last if VMR7/9 is used.
If video will be opened like in Graphstudio, the problem won't happend until user hit F7.
I still have at last one sample with wrong AR - it does not work correctly even when EVR is in use, but no problem in Graphstudio.
Just for test, can you create patch with disabled AR definition (F7) - to open video like in Graphstudio - is that possible?

For example, since i am on digital LiveTV, i didnt used F7 in GB-PVR for ~1year now.

[sub]

BTW, can i ask why nPVR needs to touch the Size X/Y sliders when opening video?

It has to. It basically needs to do this to make sure the video plays with the correct aspect ratio. For example, if you've got a 16:9 window, and try to play 4:3 video, then it needs to use the VMR SetOutputRect() API to tell the video it needs to appear in the middle of the window with black bars on the sides. SetOutputRect() is effectively the Size and Offset sliders in the VMR9 render settings.

If you wanted a version that didnt call SetOutputRect, than it'll be stuck in the 'Full' aspect ratio, and whatever video you watch will fill the screen.

When you press F7 to the 'Full' aspect ratio, then the Offsets are set to (0,0) and the Size is set to (1,1), which is the defaults that work in VMR9. Any other aspect ratio mode uses values other than these, and will see the problem.

For example, since i am on digital LiveTV, i didnt used F7 in GB-PVR for ~1year now.

Thats because you're not using the VMR9 renderer, so you dont see this bug in the renderer. Instead it's using Direct3D.

[hoborg]

sub:
So no way out?

I am not programer, so maybe my questions can be stupid for you :/.
If i open video in graphstudio, all is OK, i can change increase/decrease window size without problem and AR is still correct. Such a thing is not possible? Just increase window size to fullscreen, but not fill whole screen.
Simply just like Graphstudio doing it, i think you understand what i mean.

Strange i newer saw this issue before, for example MPC-HC or MediaPortal didnt have such problem, both should use VMR9 renderer, but maybe it is modified in some way.

[imilne]

No luck with the latest patch for me either. I'm using an ATI HD 4550 btw. I'll give it a try with VMR9 in Windows 7 later on if I get the chance; just to see.

Even if you can't fix it for XP (I'm moving to Windows 7/EVR at some point anyway), it would still be nice if you could make it remember the last used aspect ratio, so if you have it set to, for example, "remove letterbox", then next time you play a video that's what it uses straight away.

Thanks as always for taking the time to look at these problems.

[sub]

sub:
So no way out?

I am not programer, so maybe my questions can be stupid for you :/.
If i open video in graphstudio, all is OK, i can change increase/decrease window size without problem and AR is still correct. Such a thing is not possible? Just increase window size to fullscreen, but not fill whole screen.
Simply just like Graphstudio doing it, i think you understand what i mean.

Its complicated to explain, but the app needs to do this way. A lot of the reason stems from how the alpha blended OSD graphics need overlaid onto the video, with the graphics staying in the same position, while the video is moved into different positions within the window as your change aspect ratio modes.

I can get the video to appear in the correct place on the screen, but the OSD graphics get stuffed up. For example, NPVR shows a panel at the bottom of the screen that contains a filename and description of the video, and the timeline. If you're playing a downloaded movie, with a super wide 2.35 aspect ratio, then a person viewing this on a 4:3 screen would end up with huge black bars above and below the video maintain the correct aspect ratio, with the video filling the smaller portion in the middle. Normally NPVR would display it's OSD graphics in the normal fixed spot at the bottom of the window (in the black bar in this case). If I dont control the size/offset settings in the renderer, then I can get the video to appear in the correct location, but the OSD would go with it - ie the info and timeline would be miles away from the bottom of the screen, and squished (short and wide) into the bottom part of the video in the middle of the screen. (also breaking stuff like the ability to click on the timeline to skip etc)

When you're in a tool like GraphStudio/GraphEdit, you're not having to deal with stuff like OSD graphic placement etc, so people usually dont go as far as a adjusting stream placement in the renderer. NPVR has to move the video around by tweaking the offset/size settings on the video stream.

Strange i newer saw this issue before, for example MPC-HC or MediaPortal didnt have such problem, both should use VMR9 renderer, but maybe it is modified in some way.

I dont know about MPC-HC, but MediaPortal was like GBPVR and used a custom allocator presenter to draw all its frames using Direct3D rather than using VMR9's renderer. Some apps resize the actual window to be the same shape as the video, or they dont show any OSD graphics, so the problems arent relevent to these.

[sub]

This patch adds a VMR9Custom renderer option, which uses Direct3D for rendering with VMR9.

[mvallevand]

This patch adds a VMR9Custom renderer option, which uses Direct3D for rendering with VMR9.

Wow, assuming this works out, I think it's time to give NPVR a name and make it real.

Martin