[WIP] New Confluence Skin for XNEWA

[pkscout]

OK, here's an updated skin that should address all the outstanding issues. In the detail screen you can know wrap between the recording details and the action buttons using just up and down arrows. I also made a similar change in the Dashboard for getting between Upcoming and What's New. The channel icons should now show up in their original aspect ratio, and I fixed that scrollbar issue. You're right, I don't have enough recordings for the scrollbar to ever activate, so please check that if you can.

[mvallevand]

Everything works nicely including the scrollbar except the Dashboard onright doesn't toggle list I don't know what the dash as a value means and having to scroll the full list of 10 item isn't the best for me changing the - to 248 or 249 fixes it for me so I thing this is will be.

Martin

[pkscout]

That's fine. The dash really just means no action for that item. I originally had it set the way you've put it, but I changed it because, like the details, it was kind of non-obvious to se the right arrow to get from one to the other. But now it's a hidden shortcut, as the up and down do get you from one list to the other.

[pkscout]

Here's a new version of XNEWA based on the 2.4.0 code. This one granularizes basically all the various labels so that it's easier to build skin overlays for other skins. I coded out any reuse of labels and added separate ones (e.g. the channel label in ALL RECORDINGS is now only used for channels, there is a new label for program counts). I also coded out any formatting and moved it into the skin files. Lastly, XNEWA now displays dates/times based on the region set in XBMC. So if you have your region set to US(24h), all times will be in 24 hour format (like 17:04). If you chose US(12h), you'll get something like 5:04 PM. If you choose a non-US region, your date will match the date format for your region.

I updated both the Confluence and Default skins, and both seem to be working. I didn't make any other changes to the Default skin other than to make sure it worked with the new labels. Hopefully all this looks OK. If we get all this stabilized, I'd like to go back and create documentation for all the labels. That way if someone else wants to skin XNEWA to match another skin it will be a bit easier.

[pkscout]

P.S. I think I found a bug in xnewa.getRecordingsSummary. When you get the list of dates from this call, they are all off by one day from the correct information. So in the All Recordings list something will show a date of Monday, May 12 (which is wrong). When you go to the detail for the recording, it shows the correct Sunday, May 11. No other screen seems to be showing that, and if you go into the recording list for a show with more than one recording (which calls xnewa.getRecentRecordings), then all the dates are correct.

I've "fixed" it for now by changing the date by doing t['start'] + datetime.timedelta(days=-1) in the affected area. That fix is NOT in 2.4.1~beta1 above.

[mvallevand]

Here's a new version of XNEWA based on the 2.4.0 code. This one granularizes basically all the various labels so that it's easier to build skin overlays for other skins. I coded out any reuse of labels and added separate ones (e.g. the channel label in ALL RECORDINGS is now only used for channels, there is a new label for program counts). I also coded out any formatting and moved it into the skin files. Lastly, XNEWA now displays dates/times based on the region set in XBMC. So if you have your region set to US(24h), all times will be in 24 hour format (like 17:04). If you chose US(12h), you'll get something like 5:04 PM. If you choose a non-US region, your date will match the date format for your region.

I updated both the Confluence and Default skins, and both seem to be working. I didn't make any other changes to the Default skin other than to make sure it worked with the new labels. Hopefully all this looks OK. If we get all this stabilized, I'd like to go back and create documentation for all the labels. That way if someone else wants to skin XNEWA to match another skin it will be a bit easier.

I'll check tonight. I am a bit reluctant to start documenting things because when I remove SOAP I want to clean up all the python structure. I took this from the original author Ton and sort of hacked it together as I learned python. I probably will rename a lot of the function names, I get lost with all those underscores. It might be a python style but I am not used to it at all.

I've "fixed" it for now by changing the date by doing t['start'] + datetime.timedelta(days=-1) in the affected area. That fix is NOT in 2.4.1~beta1 above.

Your fix might only work because you are gmt -10 and most of your shows are "tomorrow" Could you check if the time the fix I put in for _recurr2dict_json work by any chance with SOAP?

Martin

[pkscout]

I'll check tonight. I am a bit reluctant to start documenting things because when I remove SOAP I want to clean up all the python structure. I took this from the original author Ton and sort of hacked it together as I learned python. I probably will rename a lot of the function names, I get lost with all those underscores. It might be a python style but I am not used to it at all.

Yea, I know how it is to inherit a project. I think it was a year or two before all the code in Artist Slideshow made any sense to me. I was planning on limiting the scope of the documentation just to the label/control numbers, what they are, and which are required. I'm happy to wait until things are more stable and then do documentation then for the skin part.

Your fix might only work because you are gmt -10 and most of your shows are "tomorrow" Could you check if the time the fix I put in for _recurr2dict_json work by any chance with SOAP?

I'll look. What's odd is that this issue only crops up when loading the recording summaries. And it's not just that "today," "tomorrow," and "yesterday" aren't calculating right. The date that is shown is one day off on the first All Recordings Screen. That same exact show on every other screen shows the correct date/time.

[mvallevand]

Yea, I know how it is to inherit a project. I think it was a year or two before all the code in Artist Slideshow made any sense to me.

I still need to have the browser open to search out python syntax so I am not there yet.

I was planning on limiting the scope of the documentation just to the label/control numbers, what they are, and which are required.

Ok, that seems like it limited to the xml skins and nextpvr\*.py which allows me to focus on getting rid of SOAP.

I'll look. What's odd is that this issue only crops up when loading the recording summaries. And it's not just that "today," "tomorrow," and "yesterday" aren't calculating right. The date that is shown is one day off on the first All Recordings Screen. That same exact show on every other screen shows the correct date/time.

There is no timezone on the summary like there is on many other screens, from last night

summary = {'count': 4, 'start': datetime.datetime(2014, 6, 22, 6, 30), 'title': 'Halt and Catch Fire'}

vs the schedule reoc

"StartTime": "2014-06-23T06:30:00Z",
"EndTime": "2014-06-23T07:30:00Z",
"Title": "Halt and Catch Fire",

So this still fails for me, with the changed code in _sum2dict_json. Back to the drawing board.

Martin

[pkscout]

Yea, I just figured out basically the same thing.

I looked at a recording in the NextPVR client, and it shows The Last Ship recorded from 5:59pm - 7:03pm on 22 June 2014. The same show when queried using the RecordingSummary reports back it started recording at 03:59:04 on June 23, 2014. So that's exactly 10 hours off.

I did find one other thing. The RecordingSummary uses the SOAP call no matter what. There doesn't seem to be a JSON call corresponding to /public/ScheduleService/RecordingsSummary, at least not on my version of NEWA (which I'm pretty sure is current, it's whatever is installed with NPVR 3.2.9). So the JSON call generates a 405 error and then falls back to the SOAP call. I can't find a JSON call documented at all for the RecordingSummary.

[mvallevand]

I did find one other thing. The RecordingSummary uses the SOAP call no matter what. There doesn't seem to be a JSON call corresponding to /public/ScheduleService/RecordingsSummary, at least not on my version of NEWA (which I'm pretty sure is current, it's whatever is installed with NPVR 3.2.9). So the JSON call generates a 405 error and then falls back to the SOAP call. I can't find a JSON call documented at all for the RecordingSummary.

Right there was no API so that is what I added in this release and it is added to NEWA 2.13

Martin