Gotham build of pvr.nextpvr

[mvallevand]

If you are using Gotham for Windows, I took 1.8.4 from the Opdenkamp and applied sub's Timeshift frodo 12.3 changes and it seems to work ok. This has a proper xbmc.log logging

21:31:46 T:28304 DEBUG: AddOnLog: NextPVR PVR Client: CloseLiveStream
21:31:46 T:28304 DEBUG: AddOnLog: NextPVR PVR Client: Telling backend of live session closure

and it has much less debug log spam too.

These should overwrite the file(s) in %ProgramFiles\XBMC\addons\pvr.nextpvr and need to be reapplied when you update the nightly.

sub I also tried to fix genre support but for some reason genre is not returned to xbmc like it is to the browser the difference seems to be the range request

Code:

2013-10-29 23:01:03.106    [DEBUG][26]    Got Web Request (172.16.3.53): /service    method=channel.listings&channel_id=7981&start=1383098047&end=1383360847&sid=1393e910153241ed8844042a2f4c2598
2013-10-29 23:01:03.107    [DEBUG][26]    method=channel.listings
2013-10-29 23:01:03.107    [DEBUG][26]    parameters:
2013-10-29 23:01:03.107    [DEBUG][26]       method: channel.listings
2013-10-29 23:01:03.107    [DEBUG][26]       channel_id: 7981
2013-10-29 23:01:03.107    [DEBUG][26]       start: 1383098047
2013-10-29 23:01:03.107    [DEBUG][26]       end: 1383360847
2013-10-29 23:01:03.107    [DEBUG][26]       sid: 1393e910153241ed8844042a2f4c2598
2013-10-29 23:01:03.107    [DEBUG][26]       client_ip: 172.16.3.53
2013-10-29 23:01:03.107    [DEBUG][26]       host_callback: 172.16.3.2:8866
2013-10-29 23:01:03.107    [DEBUG][26]       physical_path: C:\Users\Public\NPVR\web\
2013-10-29 23:01:03.107    [DEBUG][26]       user_agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0
2013-10-29 23:01:03.107    [DEBUG][26]       range:
2013-10-29 23:01:03.107    [DEBUG][26]       requested_path: /service
2013-10-29 23:01:03.107    [DEBUG][26]       verb: GET
2013-10-29 23:01:03.128    [DEBUG][26]    <?xml version="1.0" encoding="utf-8" ?>
vs
2013-10-29 22:54:14.103    [DEBUG][26]    Got Web Request (172.16.3.53): /service    method=channel.listings&channel_id=7981&start=1383098047&end=1383360847&sid=1393e910153241ed8844042a2f4c2598
2013-10-29 22:54:14.103    [DEBUG][26]    method=channel.listings
2013-10-29 22:54:14.103    [DEBUG][26]    parameters:
2013-10-29 22:54:14.103    [DEBUG][26]       method: channel.listings
2013-10-29 22:54:14.103    [DEBUG][26]       channel_id: 7981
2013-10-29 22:54:14.103    [DEBUG][26]       start: 1383098047
2013-10-29 22:54:14.103    [DEBUG][26]       end: 1383360847
2013-10-29 22:54:14.103    [DEBUG][26]       sid: 1393e910153241ed8844042a2f4c2598
2013-10-29 22:54:14.103    [DEBUG][26]       client_ip: 172.16.3.53
2013-10-29 22:54:14.103    [DEBUG][26]       host_callback: 172.16.3.2:8866
2013-10-29 22:54:14.103    [DEBUG][26]       physical_path: C:\Users\Public\NPVR\web\
2013-10-29 22:54:14.103    [DEBUG][26]       user_agent: XBMC/13.0-ALPHA9 Git:20131029-0303047 (Windows NT 6.1;WOW64;Win64;x64; http://xbmc.org)
2013-10-29 22:54:14.103    [DEBUG][26]       range: bytes=0-
2013-10-29 22:54:14.103    [DEBUG][26]       requested_path: /service
2013-10-29 22:54:14.103    [DEBUG][26]       verb: GET

Martin

[sub]

sub I also tried to fix genre support but for some reason genre is not returned to xbmc like it is to the browser the difference seems to be the range request

What's broken about the genre? I get the coloring and the expected genre in XBMC.

[mvallevand]

What's broken about the genre? I get the coloring and the expected genre in XBMC.

There's no genre markup in the xml I get here and it looks like you are looking for field genre_type and genre_subtype I don't ever see in the api https://github.com/sub3/xbmc-pvr-addons/...extpvr.cpp

I thought I would try to use broadcast.iGenreType = EPG_GENRE_USE_STRING to just output the genre field as text but it isn't included either

Martin

[sub]

There's no genre markup in the xml I get here and it looks like you are looking for field genre_type and genre_subtype I don't ever see in the api https://github.com/sub3/xbmc-pvr-addons/...extpvr.cpp

Ah, that's right... There was a small change that wasn't committed, which corrected this. I posted the binaries for it, but thinking back, it look like it wasn't going to be included in Frodo so I decided to include it later when I made Gotham changes, but that never happened.

For the record, if the user agent indicates xbmc, then you get a <genre> tag, otherwise you get <genre_type> and <genre_subtype>.

[mvallevand]

If you look at my output above, when user agent include XBMC I got nothing, when it is mozilla I get genre

Code:

<l>
   <id>39838990</id>
   <name>A History of Scotland</name>
   <description>God&apos;s Chosen People: Neil Oliver presents the story of the Covenanters.</description>
   <start>1383109200000</start>
   <end>1383112800000</end>
   <genre>Series</genre>
</l>

<l>
   <id>39838990</id>
   <name>A History of Scotland</name>
   <description>God&apos;s Chosen People: Neil Oliver presents the story of the Covenanters.</description>
   <start>1383109200000</start>
   <end>1383112800000</end>
</l>

Martin

[sub]

Sorry, I got it backwards, but it only works if you have xbmc-genre-translation.xml in the data directory.

[sub]

Ah, ignore everything I told you earlier in this thread

I'm pretty sure the genre stuff is there and working, but you don't get the genre because you'd need to add your mappings to xbmc-genre-translation.xml. The default file provides all the mappings straight from the DVB spec, of name to type/subtype, since this was what XBMC genre mapping was designed around (from TVHeadEnd). No such defined mapping exists for genre strings from Schedules Direct. If someone creates one though, I'm happy to include it in future versions of the file.

[mvallevand]

Ah, ignore everything I told you earlier in this thread

I'm pretty sure the genre stuff is there and working, but you don't get the genre because you'd need to add your mappings to xbmc-genre-translation.xml. The default file provides all the mappings straight from the DVB spec, of name to type/subtype, since this was what XBMC genre mapping was designed around (from TVHeadEnd). No such defined mapping exists for genre strings from Schedules Direct. If someone creates one though, I'm happy to include it in future versions of the file.

Right now genre from non-xmblc doesn't work right anyway because I don't see them merged all merged Movie;Comedy so I don't know how to map that as Movie type Comedy subtype in the xml file

Maybe it be possible to support the genre (with all the Schedules Direct genres together? XBMC supports this protocol

Code:

if (pListingNode->FirstChildElement("genre") != NULL && pListingNode->FirstChildElement("genre")->FirstChild()->Value() != NULL)
        {
                  broadcast.iGenreType  = EPG_GENRE_USE_STRING;
          broadcast.iGenreSubType = 0;
          char genreDescription[128];
          PVR_STRCPY(genreDescription,pListingNode->FirstChildElement("genre")->FirstChild()->Value());
          broadcast.strGenreDescription = genreDescription;
        }

and it might make the logic in NextPVR a lot easier (I think).

Martin

[sub]

Are you kidding - how long do you think it'd take to get that change into XBMC

Much easier to make any changes on the PC side.

[mvallevand]

XBMC has had that since Feb they did it for argustv

Martin