[WIP] New Confluence Skin for XNEWA

[mvallevand]

1- There seems to be some kind of new(or retrograde) bug in XNEWA_Connect.py. With the 2.40~beta1 if I go to All Recordings I get a message that the NextPVR server can't be contacted. The home screen loads fine, as does everything else. I copied XNEWA_Connect.py from the 2.3.1~beta5 I had and everything worked fine after that. I've attached a log of the problem. I do see a 405 being returned from NEWA.

The 405 is expected since I a call a function not yet in your NEWA. For some reason the exception handling isn't working

Change

Code:

try:
            schObj.recurr_priority = 0
        except:
            print 'Update to NEWA required'

to

Code:

if hasattr(schObj,'recurr_priority') == True:
            schObj.recurr_priority = 0
        else:
            print 'Update to NEWA required'

2- I think the "classic" skin still needs to be the default. The Confluence skin is not stand alone (it has references to include and image files only available in Confluence). So if someone is using a skin other than Confluence, the skin I did won't work. I'd suggest they be listed as "Default" and "Confluence."

I have to think about this since Default doesn't work with all skins either

The obvious disadvantage is that the user can't opt for the Classic skin if there is a skin specific skin available.

And for now I do want to give the user the option.

Martin

[mvallevand]

I have to think about this since Default doesn't work with all skins either

Ok thought about it and Default as a choice doesn't mean anything to a user so I renamed the choice and folder to Confluence and Confluence is the setting Default Classic remains Classic as the choice, but the folder is Default. This may not seem logical, but having a Default will help on skin development, plus allow for common skins if needed.

2.4.0-beta2
- Classic is renamed back to Default
- fixed workaround for a SOAP change from UJB
- fixed a few more Windows filename issues

Martin

[Maxcore]

great job martin !

[mvallevand]

Thanks Maxcore pkscout deserves all the credit, there is far more work reskinning this then I ever wanted to attempt, but it is indeed a nice and welcome update.

Martin

[Maxcore]

Great , i want know if you or pkscout use github for the project ? i like see the evolution

[mvallevand]

The current source is in each zip that's as far as I take it.

Martin

[pkscout]

Great , i want know if you or pkscout use github for the project ? i like see the evolution

I didn't use github for this since I wasn't the primary maintainer. Mostly all you would have seen is:

1- broken
2- still broken
3- WTF, why doesn't this work
4- Oh god, the inhumanity
5- Oh, I see
6- works

[pkscout]

2.4.0-beta2
- Classic is renamed back to Default
- fixed workaround for a SOAP change from UJB
- fixed a few more Windows filename issues

I found one more bug. On line 84 of schedules.py, the detailDialog creation is missing the new setting for the skin (self.settings.XNEWA_SKIN), so it uses the Default skin's dialog box no matter which skin you select. Once I added that in, I get the Confluence recurring schedule detail if I'm using the Confluence skin option.

I went through every other screen, and that's the only one I found like that.

[mvallevand]

Thanks I thought I had search out all the .detailDialog call but missed it. I'll include it in the next update, likely on the live repo.

Martin

[pkscout]

OK, remember how I said I was done. I lied (kind of).

I was wandering through Confluence today and noticed that it uses a really big blade to show video details. I decided to switch the detail dialog boxes over to that because it's more consistent with Confluence and gives more space. I've attached a zip of the updated skin and screenshots. If you like the original version of the detail dialogs better, that's fine with me.