periodically re-load comskip .edl file when watching in progress recording?

[johnsonx42]

Just like the title says...

I've got comskip doing a pretty good job of marking commercials on the fly, and npvr does properly load the .edl file when I start watching a recording in progress, but it never re-loads it to pick up any new skip points as the recording proceeds, nor by extension does it load the completed comskip file which may have more accurate skip points after the recording is complete.

an implementation I think would work well would be to read the .edl file after every auto-skip, and also any time the user presses [PLAY], the theory being that the user has auto-skip disabled and is pressing PLAY to activate the manual comskip, or playback has reached a commercial that hadn't yet been marked, so the user presses [PLAY] to prompt the program to re-read the .edl.

loading the .edl file when the user presses [PLAY] would also nicely cover the case where the user doesn't have comskip creating skip points on the fly, but would like to pick up the completed .edl file when the recording and comskip finish.

(this wouldn't only apply to watching an in-progress recording either; while I do run comskip in parallel, some may run it in postprocessing instead. so they may begin watching a completed recording which comskip is still processing, so having it load/re-load the .edl while watching would apply there too)

[mvallevand]

Just like the title says...

For this to work well Timing.Info would likely need to be reloaded too.

Martin

[sub]

This patch checks for an updated comskip file length every 20 seconds or so, and will reload if changed.

[ww4397]

This patch checks for an updated comskip file length every 20 seconds or so, and will reload if changed.

Can't wait to try this! Perfect for time-shifting long sporting events and watching them before they are over. I've always had to Stop and then re-Start the recording to get the updated edl file read.

[stustunz]

Will this work with x-newa on a rpi?

[sub]

No - it's only playing directly in NextPVR.

xnewa can request the comskip points as often as it wants though, so nothing to stop Martin implementing something similar.

[johnsonx42]

For this to work well Timing.Info would likely need to be reloaded too.

Martin

I think sub added code quite a long time ago to use timing.info while watching in-progress recordings, as I think I (and others) made some fuss about skips being off and even going the wrong way particularly when watching long in-progress recordings such as the olympics.

This patch checks for an updated comskip file length every 20 seconds or so, and will reload if changed.

thanks sub, I will put this through it's paces tomorrow night.

[johnsonx42]

sorry sub, this doesn't seem to work at all. I started watching America's Got Talent at 20:17:31.706, it loaded the initial skip point fine (just one commercial was marked by that point), but never loaded any more. I kept checking the timeline to see if anything was changing, but waited patiently until I got to the 2nd commercial to see if it skipped even though the timeline never changed; it didn't. The log doesn't seem to show any new messages, nothing indicating it re-reading the skip points.

After I stopped playback I started it again from the beginning just to verify that comskip had indeed marked more commercials, and the second time (at 20:32:55.961) it loaded 3 commercial skip points.

Yes, I triple-checked that the NextPVR.exe I'm running is the one from your post above.

Log attached in case it helps.

[johnsonx42]

wait, hold on a second, I think I figured something out... testing

[johnsonx42]

ok, nevermind, I thought maybe I wasn't really running from the updated file due to the way I copied it in, but I deleted and replaced it from the .zip and got the same result.

Another log is attached just in case it's of any help whatsoever, along with the current .edl file.