Don't allow existing files to be overwritten

[Aydan]

Hi there,

i'm using GBpvr for several months now and it works really good. But there's some things that might need fixing. Especially that the recorder will overwrite a recorded file if the service is restarted while a recording is running, meaning as soon as the service restarts it will create a file with the same name as it created before the restart and this will delete the already recorded part of the show. I think that fixing this is rather simple. Just check for existing files and add a suffix like "_1" to the file name if it already exists.

It would also be nice if the service needn't be restarted for changes to take effect, but i'm shure this has been mentioned before.

Keep up the great work

Aydan

[stu8080]

I have a feeling that this has been a frustration for many people, and knowing how fast things get fixed on this project, I assume its not a simple fix.
Id love to see this changed though for the odd times i reboot without thinking about whats recording, or when i dont care about the program enough to wait to change something.

[reboot]

I use renamerecordings in parallelprocessing.bat
It will rename the recording, so if you restart the recording service, then next portion will be renamed with the _1 extention, etc.
Not a great method, but it does work.

[stu8080]

i never thought of that! nice one reboot

Does it affect comskip/SA running parallel though do you think?

[Jeff]

It would also be nice if the service needn't be restarted for changes to take effect, but i'm shure this has been mentioned before.
Aydan

Why is it that you need to restart the service? What changes are you making while recordings are going on?

Jeff

[stu8080]

im often recording 5-6 shows in a row in the evening - exactly the time when im home from work and trying things out, although GB-PVR is pretty much perfect for me at the moment and so i'll most likely leave it well alone if i can help it!

[reboot]

i never thought of that! nice one reboot

Does it affect comskip/SA running parallel though do you think?

If you don't use the check marks in gbpvr's config, but set up a "parallelprocessing.bat" yourself, then it all works.
As an example, here's my parallelprocessing.bat:

Code:

@echo off
Rem ParallelProcessing.bat
Rem This script will be run automatically by GBPVR when found after a recording is finished
Rem To enable it put this file inside your GBPVR default program directory (C:\Program Files\devnz\gbpvr\)
Rem together with Comskip.exe, Comskip.ini and Comskip.dictionary
Rem The script is called with two parameters
Rem %1 is the fully qualified name of the recorded mpeg file.
Rem %2 is the channel number of the recording
echo Prostprocessing.bat invoked on %1 recorded from channel %2 >>postprocessing.log

Rem The part below can be used to not run Comskip on certain channels, please modify for your conveniance.
Rem The channel numbers that should be skipped are the numbers between the double quotes ("").
Rem You can add "if" lines as much as you want
Rem To disable this behaviour use channel numbers outside the normal range, put a "rem" before the "if" or delete the "if" lines

Rem list of channels to not run comskip on
Rem if "%2" == "27" goto eof:
Rem if "%2" == "36" goto eof:

Rem this trick also makes it possible to have dedicated comskip.ini file for certain channels.
if "%2" == "7" goto channel7:
REM if "%2" == "4" goto channel7:
REM if "%2" == "6" goto channel7:
if "%2" == "15" goto channel15:

Rem use the default comskip.ini for all other channels
goto generic:

:channel7
comskip --ini=comskipcbs7.ini %1
goto continue:
:channel15
comskip --ini=comskipshcase15.ini %1
goto continue:

:generic
Rem The actual run of Comskip. Only one parameter, the name of the mpeg file to process.
Rem Comskip will read its settings from the Comskip.ini found in the same directory as Comskip.exe
Rem Both are supposed to be in the GBPVR default program directory. (C:\Program Files\devnz\gbpvr\)
comskip %1
:continue
REM end comskip section------------------------
Rem Once the commercials have been identified you can run comclean to delete the commercials from the recording.
Rem Do this only when you are not using the Skip function in the GBPVR viewer.
REM the following calls videoredo to edit the file, then renamerecordings.
cscript //nologo "C:\Program Files\VideoReDoPlus\vp.vbs" "%~dpn1.VPrj" "%~dpn1_Cleaned.mpg" /t1 /q
Rem RENAME the old .mpg file and rename the new one to the old name
move "%~dpn1.mpg" "%~dpn1_original.mpg"
move "%~dpn1_cleaned.mpg" "%~dpn1.mpg"

RenameRecordings -t %1 > renamerecordings.log
REM the next line renames the _original file back to the gbpvr named file with time and date
move "%~dpn1_original.mpg" "%~dpn1.mpg"

REM start transcoder process----------------------------------
REM start /min /low getnewname.vbs
REM end this is what works-----------------------------

REM Testing mencoder section------------------
REM This is the transcoding portion
REM cd "C:\Program Files\devnz\gbpvr\"
REM start /min /low mTranscode_0p0p3.vbs
REM end mencoder test section ------------------

:eof

You would change the whole top portion, if you're using SA, and simply call SA to run first.
You would change the parameters for the editing to comclean or comclean 2 if you're not using videoredo.
The last portion is for automatic transcoding to avi. Just leave it REM'd out if you're not using the same programs/settings.

[stu8080]

Excellent! I can stop worrying about the odd powercut then!

Im still tweaking my comskip so dont dare use comclean... Im looking forward to Jere's 'learning' version of SA, should make things far easier.

[Aydan]

Why is it that you need to restart the service? What changes are you making while recordings are going on?

Jeff

Well, it's not when I restart the service myself but when it happens unintentionally like a power outage that bothers me.

Also it's generally bad practice to let any program overwrite user data. That's one thing I always avoid in my programs. Either ask the user, append or start another file.

I don't understand what might be the problem in coding this into gbpvr. On file creation just check for existence and either rename the existing one (not preferred by me) or choose another name for the new file.

CU

Aydan