Commercials? Not showing in v0.98.13

[dfdario]

Since 0.98.08b detected commercials were showed as dark green on the progress bar while in playback.
New version 0.98.13 (You did a very good job indeed) won’t show commercials tags. I've not deeply investigated but seems nothing is wrong in the log files.
Have I missed something (a new feature like 999)?

No log attached because yesterday night was really too late, or early in the morning, it depends

[sub]

It shouldnt be any different, and I've not seen any other reports of problems with this (yet).

It seems to still be working fine here.

[lseats]

I suspect this is the same thing I see on the MVP. If I don't have auto-skipping on I don't see the commercial indicators. If I turn on auto-skipping with 999 or in the config I do see them.

[sub]

Well yes, if its disabled then its not going to show the commercials or do the skipping. I'm assuming that if it worked of him in the past, then he still has it enabled. The release wouldnt have disabled it.

[Carlito]

So with the new 999 tweak, we can't manually skip commercials if it's off?
I assumed it only turned off automatically skipping them. Am I wrong here?

[sub]

If you want to every skip commercials automatically, then you're supposed to have the option enabled in the config app. My intention is that if while a show is playing, you find the ad detection is wrong, then you can disable auto commercial skipping by pressing 999.

[sub]

So with the new 999 tweak, we can't manually skip commercials if it's off?

Actually, re-reading this I'm not 100% clear what you're saying. Of couse you can manually skip ads. You've got a skip button on your remote.

[Carlito]

sorry for being unclear.
What i meant was that if we turn off auto skip (via 999) then can I still hit the play button on my remote to skip over commercials?

[sub]

No. It will totally ignore the comskip information if it is disabled with 999.

[lseats]

The 999 toggle works for me on the MVP regardless of whether it is turned on or off in the config.

It always reads the comskip.txt file and the skip points are always there.

The "problem" is what is displayed on the OSD.

When auto-skipping is turned off you see a solid bright green bar - you don't see the dark green skip areas, but they are there and manul skipping does work.

When auto-skipping is turned on you do see the dark green skip areas.