NPVR 2.1.4 - Picture Library bug

[ShiningDragon]

Ok - I'll to add some more bugs for you in the next release.

It's like easteregghunting. *buck*

Problem:
While browsing through my .jpg pictures i got a freezing nPVR. The logfile is telling the following.

Code:

2011-07-03 02:36:46.594    [ERROR][17]    Unexpected error background loading preview images: System.Runtime.InteropServices.ExternalException: Allgemeiner Fehler in GDI+.
   bei System.Drawing.Image.Save(String filename, ImageCodecInfo encoder, EncoderParameters encoderParams)
   bei System.Drawing.Image.Save(String filename, ImageFormat format)
   bei System.Drawing.Image.Save(String filename)
   bei NUtility.ImageCache.GetImage(String sourceFile, Int32 width, Int32 height, Boolean fixedAspectRatio, Boolean requiresAutoRotation)
   bei NUtility.ImageCache.PreloadImage(String sourceFile, Int32 width, Int32 height, Boolean fixedAspectRatio, Boolean requiresAutoRotation)
   bei NextPVR.Libraries.BaseLibrary.WorkerThread()
2011-07-03 02:36:46.594    [DEBUG][18]    CheckCache() indicates:\\192.168.0.11\MEDIEN\Privat\Fotos\2008\06 (Juni)\21. (Samstag)\2008-06-21_160142.jpg is not cached.
2011-07-03 02:36:46.647    [DEBUG][18]    File: \\192.168.0.11\MEDIEN\Privat\Fotos\2008\06 (Juni)\21. (Samstag)\2008-06-21_160142.jpg  Orientation: 1
2011-07-03 02:36:46.647    [DEBUG][17]    File: \\192.168.0.11\MEDIEN\Privat\Fotos\2008\06 (Juni)\21. (Samstag)\2008-06-21_160142.jpg  Orientation: 1
2011-07-03 02:36:46.680    [DEBUG][18]    Loading disk file: \\192.168.0.11\MEDIEN\Privat\Fotos\2008\06 (Juni)\21. (Samstag)\2008-06-21_160142.jpg:224,241:True (and cached to C:\Users\Public\NPVR\Thumbs\F19E67D41E12EA61CB3F71618503119.jpg)
2011-07-03 02:36:46.680    [DEBUG][17]    Loading disk file: \\192.168.0.11\MEDIEN\Privat\Fotos\2008\06 (Juni)\21. (Samstag)\2008-06-21_160142.jpg:224,241:True (and cached to C:\Users\Public\NPVR\Thumbs\F19E67D41E12EA61CB3F71618503119.jpg)
2011-07-03 02:36:46.681    [ERROR][17]    Unexpected error background loading preview images: System.Runtime.InteropServices.ExternalException: Allgemeiner Fehler in GDI+.
   bei System.Drawing.Image.Save(String filename, ImageCodecInfo encoder, EncoderParameters encoderParams)
   bei System.Drawing.Image.Save(String filename, ImageFormat format)
   bei System.Drawing.Image.Save(String filename)
   bei NUtility.ImageCache.GetImage(String sourceFile, Int32 width, Int32 height, Boolean fixedAspectRatio, Boolean requiresAutoRotation)
   bei NUtility.ImageCache.PreloadImage(String sourceFile, Int32 width, Int32 height, Boolean fixedAspectRatio, Boolean requiresAutoRotation)
   bei NextPVR.Libraries.BaseLibrary.WorkerThread()

Something about "AutoRotation".

[sub]

Does help if you empty your 'C:\Users\Public\NPVR\Thumbs' cache directory?

[ShiningDragon]

Nope, this was a completely fresh install of npvr 2.1.4 (uninstalled 2.0.3 before, removed any registry entries, deleted all npvr related folders).

[sub]

I cant really see anything changed in that code since the last release, but you could see if the attached patch helps. It adds some defensive coding around saving the thumbnail to protect against any GDI+ errors.

[ShiningDragon]

Nope, it didn't helped. It does not seem to be picture related. The pictures were npvr froze before could now be opened, but now npvr is freezing on other images.

EDIT:
Just tried Video Library (there are a lot more pictures). Absolutely no problem. Generating thumbs and display them without any problem. While photo library seems to have problems generating thumbs. If i restart npvr i can browse through the folder, where it crashed/freezed before. Something happens while the thumbgenerating. Disk should be fast enough (Intel 320 Series SSD 80 GB) plus there are not much photos in those folders.

[sub]

Do you get any error message on the screen?

[ShiningDragon]

Do you get any error message on the screen?

Code:

Beschreibung:
  Stopped working

Problemsignatur:
  Problemereignisname:    CLR20r3
  Problemsignatur 01:    nextpvr.exe
  Problemsignatur 02:    1.0.0.0
  Problemsignatur 03:    4e0f9552
  Problemsignatur 04:    System.Drawing
  Problemsignatur 05:    2.0.0.0
  Problemsignatur 06:    4ca2bad4
  Problemsignatur 07:    144
  Problemsignatur 08:    3d
  Problemsignatur 09:    System.OutOfMemoryException
  Betriebsystemversion:    6.1.7601.2.1.0.256.48
  Gebietsschema-ID:    1031

Lesen Sie unsere Datenschutzbestimmungen online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0407

Wenn die Onlinedatenschutzbestimmungen nicht verfügbar sind, lesen Sie unsere Datenschutzbestimmungen offline:
  C:\Windows\system32\de-DE\erofflps.txt

I hope this information can help you.

EDIT:

"Out Of Memory" lol? 8 GB RAM? ^^; NextPVR.exe is using lesser then 200 MB while browsing through photolibrary before crash, if i can trust the task manager.

[sub]

Does this help?

[ShiningDragon]

Yeah, this makes it a lot better. No freeze anymore.
But entering a subfolder now takes a time. Are you pre generating thumbs before enter a folder now? If yes, then now it would be a good time to add something like a "busy indicator" - "Hey, i am doing something, i am not freezed" symbol like a flashing circle or so.

[sub]

Yeah, this makes it a lot better. No freeze anymore.
But entering a subfolder now takes a time. Are you pre generating thumbs before enter a folder now?

No, in theory its just the same as 2.1.3 (slow loads photos in the background and updates the screen as it goes). There were some changes to how the video and music library load their artwork, but this screen is supposed to be unchanged.